Many diff / status / update commands miss files with the deleted flag (patch check)

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Many diff / status / update commands miss files with the deleted flag (patch check)

Andrew Williams-5
(apologies, was not subscribed before - please disregard a dupe if it  
arrives)

I am sending this to the list before I try to commit (not certain I  
have privs tbh...) to make sure that folk are in agreement with this  
change:

Basically many commands (svn diff, status and up for a start) do not  
report files that have been deleted (reported so using the deleted  
flag) as the file no longer exists.
Surely fixing this has to be the right thing to do, as I want to know  
when my files have been deleted ;)

The only thing in this patch that I am not 100% sure of is in maven-
scm-providers/maven-scm-provider-bazaar/src/main/java/org/apache/maven/
scm/provider/bazaar/command/diff/BazaarDiffConsumer.java
it will allow a file that is marked deleted to appear in the log even  
though (looking at the code) it might have a preceding '/' - does the  
Bazaar parser really not know whether or not to expect a preceding  
slash?!?

if I don't hear any grumbles I will try to commit this - it is a major  
annoyance for me...

Andy




maven-scm-show-deleted.patch (3K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Many diff / status / update commands miss files with the deleted flag (patch check)

Emmanuel Venisse-2
You can commit it, I'll review it.
I'm not sure about bazaar.

Emmanuel

Andrew Williams a écrit :

> (apologies, was not subscribed before - please disregard a dupe if it
> arrives)
>
> I am sending this to the list before I try to commit (not certain I have
> privs tbh...) to make sure that folk are in agreement with this change:
>
> Basically many commands (svn diff, status and up for a start) do not
> report files that have been deleted (reported so using the deleted flag)
> as the file no longer exists.
> Surely fixing this has to be the right thing to do, as I want to know
> when my files have been deleted ;)
>
> The only thing in this patch that I am not 100% sure of is in
> maven-scm-providers/maven-scm-provider-bazaar/src/main/java/org/apache/maven/scm/provider/bazaar/command/diff/BazaarDiffConsumer.java
>
> it will allow a file that is marked deleted to appear in the log even
> though (looking at the code) it might have a preceding '/' - does the
> Bazaar parser really not know whether or not to expect a preceding slash?!?
>
> if I don't hear any grumbles I will try to commit this - it is a major
> annoyance for me...
>
> Andy
>
>
Reply | Threaded
Open this post in threaded view
|

Re: Many diff / status / update commands miss files with the deleted flag (patch check)

Andrew Williams-5
In. Might have some other scm patches up my sleeve too.

Andy

On 15 Dec 2007, at 15:06, Emmanuel Venisse wrote:

> You can commit it, I'll review it.
> I'm not sure about bazaar.
>
> Emmanuel
>
> Andrew Williams a écrit :
>> (apologies, was not subscribed before - please disregard a dupe if  
>> it arrives)
>> I am sending this to the list before I try to commit (not certain I  
>> have privs tbh...) to make sure that folk are in agreement with  
>> this change:
>> Basically many commands (svn diff, status and up for a start) do  
>> not report files that have been deleted (reported so using the  
>> deleted flag) as the file no longer exists.
>> Surely fixing this has to be the right thing to do, as I want to  
>> know when my files have been deleted ;)
>> The only thing in this patch that I am not 100% sure of is in maven-
>> scm-providers/maven-scm-provider-bazaar/src/main/java/org/apache/
>> maven/scm/provider/bazaar/command/diff/BazaarDiffConsumer.java it  
>> will allow a file that is marked deleted to appear in the log even  
>> though (looking at the code) it might have a preceding '/' - does  
>> the Bazaar parser really not know whether or not to expect a  
>> preceding slash?!?
>> if I don't hear any grumbles I will try to commit this - it is a  
>> major annoyance for me...
>> Andy
>