MNG-5175 : replace wagon http lightweight with wagon http 2.0

classic Classic list List threaded Threaded
14 messages Options
Reply | Threaded
Open this post in threaded view
|

MNG-5175 : replace wagon http lightweight with wagon http 2.0

olamy
Hi Folks,
With WAGON-348, the wagon-http based on Apache HttpClient include now
http connection pool mechanism.
This prevent creating http(s) connection for each artifacts requests !
The patch simply remove lightweight and replace it with a shaded jar
of wagon http with classes relocation of dependencies.

If no objections, I will commit this.

Thanks,
--
Olivier Lamy
Talend : http://talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: MNG-5175 : replace wagon http lightweight with wagon http 2.0

Jason van Zyl
I assume all the ITs pass with this change?

On Sep 17, 2011, at 2:13 PM, Olivier Lamy wrote:

> Hi Folks,
> With WAGON-348, the wagon-http based on Apache HttpClient include now
> http connection pool mechanism.
> This prevent creating http(s) connection for each artifacts requests !
> The patch simply remove lightweight and replace it with a shaded jar
> of wagon http with classes relocation of dependencies.
>
> If no objections, I will commit this.
>
> Thanks,
> --
> Olivier Lamy
> Talend : http://talend.com
> http://twitter.com/olamy | http://linkedin.com/in/olamy
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

Thanks,

Jason

----------------------------------------------------------
Jason van Zyl
Founder,  Apache Maven
http://twitter.com/jvanzyl
---------------------------------------------------------




Reply | Threaded
Open this post in threaded view
|

Re: MNG-5175 : replace wagon http lightweight with wagon http 2.0

Mark Struberg
In wagon-2 we approximately doubled the number of tests. I even finally activated the TCK which John wrote some time ago.

But what we miss imo are tests for the integration of wagon in maven core itself.
I think it's definitely worth a try, but we should be aware that we might get some corner cases where lightweight still works better.

LieGrue,
strub


----- Original Message -----

> From: Jason van Zyl <[hidden email]>
> To: Maven Developers List <[hidden email]>
> Cc:
> Sent: Saturday, September 17, 2011 8:38 PM
> Subject: Re: MNG-5175 : replace wagon http lightweight with wagon http 2.0
>
> I assume all the ITs pass with this change?
>
> On Sep 17, 2011, at 2:13 PM, Olivier Lamy wrote:
>
>>  Hi Folks,
>>  With WAGON-348, the wagon-http based on Apache HttpClient include now
>>  http connection pool mechanism.
>>  This prevent creating http(s) connection for each artifacts requests !
>>  The patch simply remove lightweight and replace it with a shaded jar
>>  of wagon http with classes relocation of dependencies.
>>
>>  If no objections, I will commit this.
>>
>>  Thanks,
>>  --
>>  Olivier Lamy
>>  Talend : http://talend.com
>>  http://twitter.com/olamy | http://linkedin.com/in/olamy
>>
>>  ---------------------------------------------------------------------
>>  To unsubscribe, e-mail: [hidden email]
>>  For additional commands, e-mail: [hidden email]
>>
>
> Thanks,
>
> Jason
>
> ----------------------------------------------------------
> Jason van Zyl
> Founder,  Apache Maven
> http://twitter.com/jvanzyl
> ---------------------------------------------------------
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: MNG-5175 : replace wagon http lightweight with wagon http 2.0

Jason van Zyl
At the very least all the current ITs must pass.

Otherwise I'm not in favour of switching out the default provider. The ITs are the acid test and the expectation for user-end behaviour.

On Sep 17, 2011, at 3:03 PM, Mark Struberg wrote:

> In wagon-2 we approximately doubled the number of tests. I even finally activated the TCK which John wrote some time ago.
>
> But what we miss imo are tests for the integration of wagon in maven core itself.
> I think it's definitely worth a try, but we should be aware that we might get some corner cases where lightweight still works better.
>
> LieGrue,
> strub
>
>
> ----- Original Message -----
>> From: Jason van Zyl <[hidden email]>
>> To: Maven Developers List <[hidden email]>
>> Cc:
>> Sent: Saturday, September 17, 2011 8:38 PM
>> Subject: Re: MNG-5175 : replace wagon http lightweight with wagon http 2.0
>>
>> I assume all the ITs pass with this change?
>>
>> On Sep 17, 2011, at 2:13 PM, Olivier Lamy wrote:
>>
>>> Hi Folks,
>>> With WAGON-348, the wagon-http based on Apache HttpClient include now
>>> http connection pool mechanism.
>>> This prevent creating http(s) connection for each artifacts requests !
>>> The patch simply remove lightweight and replace it with a shaded jar
>>> of wagon http with classes relocation of dependencies.
>>>
>>> If no objections, I will commit this.
>>>
>>> Thanks,
>>> --
>>> Olivier Lamy
>>> Talend : http://talend.com
>>> http://twitter.com/olamy | http://linkedin.com/in/olamy
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [hidden email]
>>> For additional commands, e-mail: [hidden email]
>>>
>>
>> Thanks,
>>
>> Jason
>>
>> ----------------------------------------------------------
>> Jason van Zyl
>> Founder,  Apache Maven
>> http://twitter.com/jvanzyl
>> ---------------------------------------------------------
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

Thanks,

Jason

----------------------------------------------------------
Jason van Zyl
Founder,  Apache Maven
http://twitter.com/jvanzyl
---------------------------------------------------------

In short, man creates for himself a new religion of a rational
and technical order to justify his work and to be justified in it.

  -- Jacques Ellul, The Technological Society



Reply | Threaded
Open this post in threaded view
|

Re: MNG-5175 : replace wagon http lightweight with wagon http 2.0

olamy
In reply to this post by Jason van Zyl
Results :

Failed tests:
testit(org.apache.maven.it.MavenITmng4387QuietLoggingTest):
expected:<[]> but
was:<[#############################################################,
JRebel 4.0.3 (201107251640),  (c) Copyright ZeroTurnaround OU,
Estonia, Tartu.,  Over the last 1 days JRebel prevented ,  at least 0
redeploys/restarts saving you about 0 hours.,  This product is
licensed to Olivier Lamy ([Open-Source] Jenkins) ,  until August 13,
2012,  With the following restrictions: ,  Only for open source
development,  The following plugins are disabled at the moment: ,  *
Apache Wink plugin 0.1 (set -Drebel.wink_plugin=true to enable),
JRebel Apache Wink Plugin,  * Click plugin (set
-Drebel.click_plugin=true to enable), Reloads menu.xml menu
definitions of Apache Click projects.,  * Glassfish METRO plugin (set
-Drebel.metro_plugin=true to enable), Supports METRO JAX-WS 2.2.3
implementation of the JAX-WS standard,  * IceFaces plugin (set
-Drebel.icefaces_plugin=true to enable), JRebel IceFaces Plugin,  *
JAXB Plugin (set -Drebel.jaxb_plugin=true to enable), Enables support
for class reloading to JAXB 2 RI,  * JBoss AOP plugin (set
-Drebel.jbossaop_plugin=true to enable), Integration with jboss aop
agent,  * Jackson plugin (set -Drebel.jackson_plugin=true to enable),
Supports reloading Jackson's JsonSerializer caches.,  * Lift plugin
(set -Drebel.lift_plugin=true to enable), Supports reloading singleton
objects that extend RestHelper, MVCHelper,, LiftScreen or Wizard.,  *
RESTEasy plugin (set -Drebel.resteasy_plugin=true to enable), Supports
adding/changing methods with @Path annotation for RESTEasy
application.,  * Seam-Wicket plugin (set
-Drebel.seam_wicket_plugin=true to enable), Integration with load time
weaving seam annotations to wicket classes,
(-javaagent:<path-to-jboss-seam-wicket-jar>),  * Spring WS plugin (set
-Drebel.springws_plugin=true to enable), Enables reloading of endpoint
mappings and wsdl definitions in Spring Web, Services 2,  * WebObjects
plugin (set -Drebel.webobjects_plugin=true to enable), WebObjects
JRebel Plugin, #############################################################]>
  testmng3652_UnConfiguredHttp(org.apache.maven.it.MavenITmng3652UserAgentHeaderTest):
Comparing User-Agent 'Apache-HttpClient/4.1.2 (java 1.5)'
expected:<Apache-[Maven/3.0.4-SNAPSHOT (Java 1.6.0_26; Mac OS X
10.7.1])> but was:<Apache-[HttpClient/4.1.2 (java 1.5])>
  testmng3652_ConfigurationInSettingsWithoutUserAgent(org.apache.maven.it.MavenITmng3652UserAgentHeaderTest):
Comparing User-Agent 'Apache-HttpClient/4.1.2 (java 1.5)'
expected:<Apache-[Maven/3.0.4-SNAPSHOT (Java 1.6.0_26; Mac OS X
10.7.1])> but was:<Apache-[HttpClient/4.1.2 (java 1.5])>
  testit(org.apache.maven.it.MavenITmng3183LoggingToFileTest):
expected:<[]> but
was:<[#############################################################,
JRebel 4.0.3 (201107251640),  (c) Copyright ZeroTurnaround OU,
Estonia, Tartu.,  Over the last 1 days JRebel prevented ,  at least 0
redeploys/restarts saving you about 0 hours.,  This product is
licensed to Olivier Lamy ([Open-Source] Jenkins) ,  until August 13,
2012,  With the following restrictions: ,  Only for open source
development,  The following plugins are disabled at the moment: ,  *
Apache Wink plugin 0.1 (set -Drebel.wink_plugin=true to enable),
JRebel Apache Wink Plugin,  * Click plugin (set
-Drebel.click_plugin=true to enable), Reloads menu.xml menu
definitions of Apache Click projects.,  * Glassfish METRO plugin (set
-Drebel.metro_plugin=true to enable), Supports METRO JAX-WS 2.2.3
implementation of the JAX-WS standard,  * IceFaces plugin (set
-Drebel.icefaces_plugin=true to enable), JRebel IceFaces Plugin,  *
JAXB Plugin (set -Drebel.jaxb_plugin=true to enable), Enables support
for class reloading to JAXB 2 RI,  * JBoss AOP plugin (set
-Drebel.jbossaop_plugin=true to enable), Integration with jboss aop
agent,  * Jackson plugin (set -Drebel.jackson_plugin=true to enable),
Supports reloading Jackson's JsonSerializer caches.,  * Lift plugin
(set -Drebel.lift_plugin=true to enable), Supports reloading singleton
objects that extend RestHelper, MVCHelper,, LiftScreen or Wizard.,  *
RESTEasy plugin (set -Drebel.resteasy_plugin=true to enable), Supports
adding/changing methods with @Path annotation for RESTEasy
application.,  * Seam-Wicket plugin (set
-Drebel.seam_wicket_plugin=true to enable), Integration with load time
weaving seam annotations to wicket classes,
(-javaagent:<path-to-jboss-seam-wicket-jar>),  * Spring WS plugin (set
-Drebel.springws_plugin=true to enable), Enables reloading of endpoint
mappings and wsdl definitions in Spring Web, Services 2,  * WebObjects
plugin (set -Drebel.webobjects_plugin=true to enable), WebObjects
JRebel Plugin, #############################################################]>
  testitPrefix(org.apache.maven.it.MavenITmng2741PluginMetadataResolutionErrorMessageTest):
Transfer error cause was not found
  testitVersion(org.apache.maven.it.MavenITmng2741PluginMetadataResolutionErrorMessageTest):
Transfer error cause was not found

Tests in error:
  testit(org.apache.maven.it.MavenITmng2305MultipleProxiesTest): Exit
code was non-zero: 1; command line and log =

Tests run: 699, Failures: 6, Errors: 1, Skipped: 0

It looks I have to remove jrebel from my MAVEN_OPTS to get it working :-)

I will check for the other ones especially for the header User-Agent.
MavenITmng4387QuietLoggingTest fail because there is a System.out in wagon-http.

So not so bad.

2011/9/17 Jason van Zyl <[hidden email]>:

> I assume all the ITs pass with this change?
>
> On Sep 17, 2011, at 2:13 PM, Olivier Lamy wrote:
>
>> Hi Folks,
>> With WAGON-348, the wagon-http based on Apache HttpClient include now
>> http connection pool mechanism.
>> This prevent creating http(s) connection for each artifacts requests !
>> The patch simply remove lightweight and replace it with a shaded jar
>> of wagon http with classes relocation of dependencies.
>>
>> If no objections, I will commit this.
>>
>> Thanks,
>> --
>> Olivier Lamy
>> Talend : http://talend.com
>> http://twitter.com/olamy | http://linkedin.com/in/olamy
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>
> Thanks,
>
> Jason
>
> ----------------------------------------------------------
> Jason van Zyl
> Founder,  Apache Maven
> http://twitter.com/jvanzyl
> ---------------------------------------------------------
>
>
>
>
>



--
Olivier Lamy
Talend : http://talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: MNG-5175 : replace wagon http lightweight with wagon http 2.0

olamy
Small fixes in wagon and now all its are fine.

Tests run: 699, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1,378.237 sec

Results :

Tests run: 699, Failures: 0, Errors: 0, Skipped: 0

So at least OMMIW  :-).

If no more objections, I will commit that and btw start a wagon 2.0 release.

Thanks,
--
Olivier Lamy
Talend : http://talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy


2011/9/17 Olivier Lamy <[hidden email]>:

> Results :
>
> Failed tests:
> testit(org.apache.maven.it.MavenITmng4387QuietLoggingTest):
> expected:<[]> but
> was:<[#############################################################,
> JRebel 4.0.3 (201107251640),  (c) Copyright ZeroTurnaround OU,
> Estonia, Tartu.,  Over the last 1 days JRebel prevented ,  at least 0
> redeploys/restarts saving you about 0 hours.,  This product is
> licensed to Olivier Lamy ([Open-Source] Jenkins) ,  until August 13,
> 2012,  With the following restrictions: ,  Only for open source
> development,  The following plugins are disabled at the moment: ,  *
> Apache Wink plugin 0.1 (set -Drebel.wink_plugin=true to enable),
> JRebel Apache Wink Plugin,  * Click plugin (set
> -Drebel.click_plugin=true to enable), Reloads menu.xml menu
> definitions of Apache Click projects.,  * Glassfish METRO plugin (set
> -Drebel.metro_plugin=true to enable), Supports METRO JAX-WS 2.2.3
> implementation of the JAX-WS standard,  * IceFaces plugin (set
> -Drebel.icefaces_plugin=true to enable), JRebel IceFaces Plugin,  *
> JAXB Plugin (set -Drebel.jaxb_plugin=true to enable), Enables support
> for class reloading to JAXB 2 RI,  * JBoss AOP plugin (set
> -Drebel.jbossaop_plugin=true to enable), Integration with jboss aop
> agent,  * Jackson plugin (set -Drebel.jackson_plugin=true to enable),
> Supports reloading Jackson's JsonSerializer caches.,  * Lift plugin
> (set -Drebel.lift_plugin=true to enable), Supports reloading singleton
> objects that extend RestHelper, MVCHelper,, LiftScreen or Wizard.,  *
> RESTEasy plugin (set -Drebel.resteasy_plugin=true to enable), Supports
> adding/changing methods with @Path annotation for RESTEasy
> application.,  * Seam-Wicket plugin (set
> -Drebel.seam_wicket_plugin=true to enable), Integration with load time
> weaving seam annotations to wicket classes,
> (-javaagent:<path-to-jboss-seam-wicket-jar>),  * Spring WS plugin (set
> -Drebel.springws_plugin=true to enable), Enables reloading of endpoint
> mappings and wsdl definitions in Spring Web, Services 2,  * WebObjects
> plugin (set -Drebel.webobjects_plugin=true to enable), WebObjects
> JRebel Plugin, #############################################################]>
>  testmng3652_UnConfiguredHttp(org.apache.maven.it.MavenITmng3652UserAgentHeaderTest):
> Comparing User-Agent 'Apache-HttpClient/4.1.2 (java 1.5)'
> expected:<Apache-[Maven/3.0.4-SNAPSHOT (Java 1.6.0_26; Mac OS X
> 10.7.1])> but was:<Apache-[HttpClient/4.1.2 (java 1.5])>
>  testmng3652_ConfigurationInSettingsWithoutUserAgent(org.apache.maven.it.MavenITmng3652UserAgentHeaderTest):
> Comparing User-Agent 'Apache-HttpClient/4.1.2 (java 1.5)'
> expected:<Apache-[Maven/3.0.4-SNAPSHOT (Java 1.6.0_26; Mac OS X
> 10.7.1])> but was:<Apache-[HttpClient/4.1.2 (java 1.5])>
>  testit(org.apache.maven.it.MavenITmng3183LoggingToFileTest):
> expected:<[]> but
> was:<[#############################################################,
> JRebel 4.0.3 (201107251640),  (c) Copyright ZeroTurnaround OU,
> Estonia, Tartu.,  Over the last 1 days JRebel prevented ,  at least 0
> redeploys/restarts saving you about 0 hours.,  This product is
> licensed to Olivier Lamy ([Open-Source] Jenkins) ,  until August 13,
> 2012,  With the following restrictions: ,  Only for open source
> development,  The following plugins are disabled at the moment: ,  *
> Apache Wink plugin 0.1 (set -Drebel.wink_plugin=true to enable),
> JRebel Apache Wink Plugin,  * Click plugin (set
> -Drebel.click_plugin=true to enable), Reloads menu.xml menu
> definitions of Apache Click projects.,  * Glassfish METRO plugin (set
> -Drebel.metro_plugin=true to enable), Supports METRO JAX-WS 2.2.3
> implementation of the JAX-WS standard,  * IceFaces plugin (set
> -Drebel.icefaces_plugin=true to enable), JRebel IceFaces Plugin,  *
> JAXB Plugin (set -Drebel.jaxb_plugin=true to enable), Enables support
> for class reloading to JAXB 2 RI,  * JBoss AOP plugin (set
> -Drebel.jbossaop_plugin=true to enable), Integration with jboss aop
> agent,  * Jackson plugin (set -Drebel.jackson_plugin=true to enable),
> Supports reloading Jackson's JsonSerializer caches.,  * Lift plugin
> (set -Drebel.lift_plugin=true to enable), Supports reloading singleton
> objects that extend RestHelper, MVCHelper,, LiftScreen or Wizard.,  *
> RESTEasy plugin (set -Drebel.resteasy_plugin=true to enable), Supports
> adding/changing methods with @Path annotation for RESTEasy
> application.,  * Seam-Wicket plugin (set
> -Drebel.seam_wicket_plugin=true to enable), Integration with load time
> weaving seam annotations to wicket classes,
> (-javaagent:<path-to-jboss-seam-wicket-jar>),  * Spring WS plugin (set
> -Drebel.springws_plugin=true to enable), Enables reloading of endpoint
> mappings and wsdl definitions in Spring Web, Services 2,  * WebObjects
> plugin (set -Drebel.webobjects_plugin=true to enable), WebObjects
> JRebel Plugin, #############################################################]>
>  testitPrefix(org.apache.maven.it.MavenITmng2741PluginMetadataResolutionErrorMessageTest):
> Transfer error cause was not found
>  testitVersion(org.apache.maven.it.MavenITmng2741PluginMetadataResolutionErrorMessageTest):
> Transfer error cause was not found
>
> Tests in error:
>  testit(org.apache.maven.it.MavenITmng2305MultipleProxiesTest): Exit
> code was non-zero: 1; command line and log =
>
> Tests run: 699, Failures: 6, Errors: 1, Skipped: 0
>
> It looks I have to remove jrebel from my MAVEN_OPTS to get it working :-)
>
> I will check for the other ones especially for the header User-Agent.
> MavenITmng4387QuietLoggingTest fail because there is a System.out in wagon-http.
>
> So not so bad.
>
> 2011/9/17 Jason van Zyl <[hidden email]>:
>> I assume all the ITs pass with this change?
>>
>> On Sep 17, 2011, at 2:13 PM, Olivier Lamy wrote:
>>
>>> Hi Folks,
>>> With WAGON-348, the wagon-http based on Apache HttpClient include now
>>> http connection pool mechanism.
>>> This prevent creating http(s) connection for each artifacts requests !
>>> The patch simply remove lightweight and replace it with a shaded jar
>>> of wagon http with classes relocation of dependencies.
>>>
>>> If no objections, I will commit this.
>>>
>>> Thanks,
>>> --
>>> Olivier Lamy
>>> Talend : http://talend.com
>>> http://twitter.com/olamy | http://linkedin.com/in/olamy
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [hidden email]
>>> For additional commands, e-mail: [hidden email]
>>>
>>
>> Thanks,
>>
>> Jason
>>
>> ----------------------------------------------------------
>> Jason van Zyl
>> Founder,  Apache Maven
>> http://twitter.com/jvanzyl
>> ---------------------------------------------------------
>>
>>
>>
>>
>>
>
>
>
> --
> Olivier Lamy
> Talend : http://talend.com
> http://twitter.com/olamy | http://linkedin.com/in/olamy
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: MNG-5175 : replace wagon http lightweight with wagon http 2.0

Kristian Rosenvold-4
Cool. Is there any noticeable performance difference?

K

Den 18. sep. 2011 kl. 18:17 skrev Olivier Lamy <[hidden email]>:

> Small fixes in wagon and now all its are fine.
>
> Tests run: 699, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1,378.237 sec
>
> Results :
>
> Tests run: 699, Failures: 0, Errors: 0, Skipped: 0
>
> So at least OMMIW  :-).
>
> If no more objections, I will commit that and btw start a wagon 2.0 release.
>
> Thanks,
> --
> Olivier Lamy
> Talend : http://talend.com
> http://twitter.com/olamy | http://linkedin.com/in/olamy
>
>
> 2011/9/17 Olivier Lamy <[hidden email]>:
>> Results :
>>
>> Failed tests:
>> testit(org.apache.maven.it.MavenITmng4387QuietLoggingTest):
>> expected:<[]> but
>> was:<[#############################################################,
>> JRebel 4.0.3 (201107251640),  (c) Copyright ZeroTurnaround OU,
>> Estonia, Tartu.,  Over the last 1 days JRebel prevented ,  at least 0
>> redeploys/restarts saving you about 0 hours.,  This product is
>> licensed to Olivier Lamy ([Open-Source] Jenkins) ,  until August 13,
>> 2012,  With the following restrictions: ,  Only for open source
>> development,  The following plugins are disabled at the moment: ,  *
>> Apache Wink plugin 0.1 (set -Drebel.wink_plugin=true to enable),
>> JRebel Apache Wink Plugin,  * Click plugin (set
>> -Drebel.click_plugin=true to enable), Reloads menu.xml menu
>> definitions of Apache Click projects.,  * Glassfish METRO plugin (set
>> -Drebel.metro_plugin=true to enable), Supports METRO JAX-WS 2.2.3
>> implementation of the JAX-WS standard,  * IceFaces plugin (set
>> -Drebel.icefaces_plugin=true to enable), JRebel IceFaces Plugin,  *
>> JAXB Plugin (set -Drebel.jaxb_plugin=true to enable), Enables support
>> for class reloading to JAXB 2 RI,  * JBoss AOP plugin (set
>> -Drebel.jbossaop_plugin=true to enable), Integration with jboss aop
>> agent,  * Jackson plugin (set -Drebel.jackson_plugin=true to enable),
>> Supports reloading Jackson's JsonSerializer caches.,  * Lift plugin
>> (set -Drebel.lift_plugin=true to enable), Supports reloading singleton
>> objects that extend RestHelper, MVCHelper,, LiftScreen or Wizard.,  *
>> RESTEasy plugin (set -Drebel.resteasy_plugin=true to enable), Supports
>> adding/changing methods with @Path annotation for RESTEasy
>> application.,  * Seam-Wicket plugin (set
>> -Drebel.seam_wicket_plugin=true to enable), Integration with load time
>> weaving seam annotations to wicket classes,
>> (-javaagent:<path-to-jboss-seam-wicket-jar>),  * Spring WS plugin (set
>> -Drebel.springws_plugin=true to enable), Enables reloading of endpoint
>> mappings and wsdl definitions in Spring Web, Services 2,  * WebObjects
>> plugin (set -Drebel.webobjects_plugin=true to enable), WebObjects
>> JRebel Plugin, #############################################################]>
>>  testmng3652_UnConfiguredHttp(org.apache.maven.it.MavenITmng3652UserAgentHeaderTest):
>> Comparing User-Agent 'Apache-HttpClient/4.1.2 (java 1.5)'
>> expected:<Apache-[Maven/3.0.4-SNAPSHOT (Java 1.6.0_26; Mac OS X
>> 10.7.1])> but was:<Apache-[HttpClient/4.1.2 (java 1.5])>
>>  testmng3652_ConfigurationInSettingsWithoutUserAgent(org.apache.maven.it.MavenITmng3652UserAgentHeaderTest):
>> Comparing User-Agent 'Apache-HttpClient/4.1.2 (java 1.5)'
>> expected:<Apache-[Maven/3.0.4-SNAPSHOT (Java 1.6.0_26; Mac OS X
>> 10.7.1])> but was:<Apache-[HttpClient/4.1.2 (java 1.5])>
>>  testit(org.apache.maven.it.MavenITmng3183LoggingToFileTest):
>> expected:<[]> but
>> was:<[#############################################################,
>> JRebel 4.0.3 (201107251640),  (c) Copyright ZeroTurnaround OU,
>> Estonia, Tartu.,  Over the last 1 days JRebel prevented ,  at least 0
>> redeploys/restarts saving you about 0 hours.,  This product is
>> licensed to Olivier Lamy ([Open-Source] Jenkins) ,  until August 13,
>> 2012,  With the following restrictions: ,  Only for open source
>> development,  The following plugins are disabled at the moment: ,  *
>> Apache Wink plugin 0.1 (set -Drebel.wink_plugin=true to enable),
>> JRebel Apache Wink Plugin,  * Click plugin (set
>> -Drebel.click_plugin=true to enable), Reloads menu.xml menu
>> definitions of Apache Click projects.,  * Glassfish METRO plugin (set
>> -Drebel.metro_plugin=true to enable), Supports METRO JAX-WS 2.2.3
>> implementation of the JAX-WS standard,  * IceFaces plugin (set
>> -Drebel.icefaces_plugin=true to enable), JRebel IceFaces Plugin,  *
>> JAXB Plugin (set -Drebel.jaxb_plugin=true to enable), Enables support
>> for class reloading to JAXB 2 RI,  * JBoss AOP plugin (set
>> -Drebel.jbossaop_plugin=true to enable), Integration with jboss aop
>> agent,  * Jackson plugin (set -Drebel.jackson_plugin=true to enable),
>> Supports reloading Jackson's JsonSerializer caches.,  * Lift plugin
>> (set -Drebel.lift_plugin=true to enable), Supports reloading singleton
>> objects that extend RestHelper, MVCHelper,, LiftScreen or Wizard.,  *
>> RESTEasy plugin (set -Drebel.resteasy_plugin=true to enable), Supports
>> adding/changing methods with @Path annotation for RESTEasy
>> application.,  * Seam-Wicket plugin (set
>> -Drebel.seam_wicket_plugin=true to enable), Integration with load time
>> weaving seam annotations to wicket classes,
>> (-javaagent:<path-to-jboss-seam-wicket-jar>),  * Spring WS plugin (set
>> -Drebel.springws_plugin=true to enable), Enables reloading of endpoint
>> mappings and wsdl definitions in Spring Web, Services 2,  * WebObjects
>> plugin (set -Drebel.webobjects_plugin=true to enable), WebObjects
>> JRebel Plugin, #############################################################]>
>>  testitPrefix(org.apache.maven.it.MavenITmng2741PluginMetadataResolutionErrorMessageTest):
>> Transfer error cause was not found
>>  testitVersion(org.apache.maven.it.MavenITmng2741PluginMetadataResolutionErrorMessageTest):
>> Transfer error cause was not found
>>
>> Tests in error:
>>  testit(org.apache.maven.it.MavenITmng2305MultipleProxiesTest): Exit
>> code was non-zero: 1; command line and log =
>>
>> Tests run: 699, Failures: 6, Errors: 1, Skipped: 0
>>
>> It looks I have to remove jrebel from my MAVEN_OPTS to get it working :-)
>>
>> I will check for the other ones especially for the header User-Agent.
>> MavenITmng4387QuietLoggingTest fail because there is a System.out in wagon-http.
>>
>> So not so bad.
>>
>> 2011/9/17 Jason van Zyl <[hidden email]>:
>>> I assume all the ITs pass with this change?
>>>
>>> On Sep 17, 2011, at 2:13 PM, Olivier Lamy wrote:
>>>
>>>> Hi Folks,
>>>> With WAGON-348, the wagon-http based on Apache HttpClient include now
>>>> http connection pool mechanism.
>>>> This prevent creating http(s) connection for each artifacts requests !
>>>> The patch simply remove lightweight and replace it with a shaded jar
>>>> of wagon http with classes relocation of dependencies.
>>>>
>>>> If no objections, I will commit this.
>>>>
>>>> Thanks,
>>>> --
>>>> Olivier Lamy
>>>> Talend : http://talend.com
>>>> http://twitter.com/olamy | http://linkedin.com/in/olamy
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: [hidden email]
>>>> For additional commands, e-mail: [hidden email]
>>>>
>>>
>>> Thanks,
>>>
>>> Jason
>>>
>>> ----------------------------------------------------------
>>> Jason van Zyl
>>> Founder,  Apache Maven
>>> http://twitter.com/jvanzyl
>>> ---------------------------------------------------------
>>>
>>>
>>>
>>>
>>>
>>
>>
>>
>> --
>> Olivier Lamy
>> Talend : http://talend.com
>> http://twitter.com/olamy | http://linkedin.com/in/olamy
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: MNG-5175 : replace wagon http lightweight with wagon http 2.0

olamy
Building maven3 trunk (with my patch means download of wagon snapshot
@ r.a.o ) with an empty repo : mvn clean install
-Dmaven.repo.local=/Users/olamy/repo-test-trunk -DskipTests

now with 3.0.4-SNAPSHOT
[INFO] Total time: 6:56.920s
[INFO] Final Memory: 29M/759M

with 3.0.3
[INFO] Total time: 7:28.919s
[INFO] Final Memory: 27M/759M

Building Jenkins (which has a lot of dependencies)
now with 3.0.4-SNAPSHOT
[INFO] Total time: 22:01.165s
[INFO] Final Memory: 75M/759M

with 3.0.3
[INFO] Total time: 23:54.088s
[INFO] Final Memory: 73M/759M

CXF trunk with mvn clean test-compile
-Dmaven.repo.local=/Users/olamy/repo-test-trunk
now with 3.0.4-SNAPSHOT
[INFO] Total time: 16:14.446s
[INFO] Final Memory: 105M/759M

with 3.0.3
[INFO] Total time: 16:55.837s
[INFO] Final Memory: 104M/759M

But those figures really depends on some external stuff : response
time from http://repo1.maven.org or http://maven.glassfish.org/, my
@home network :-).


2011/9/18 Kristian Rosenvold <[hidden email]>:

> Cool. Is there any noticeable performance difference?
>
> K
>
> Den 18. sep. 2011 kl. 18:17 skrev Olivier Lamy <[hidden email]>:
>
>> Small fixes in wagon and now all its are fine.
>>
>> Tests run: 699, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1,378.237 sec
>>
>> Results :
>>
>> Tests run: 699, Failures: 0, Errors: 0, Skipped: 0
>>
>> So at least OMMIW  :-).
>>
>> If no more objections, I will commit that and btw start a wagon 2.0 release.
>>
>> Thanks,
>> --
>> Olivier Lamy
>> Talend : http://talend.com
>> http://twitter.com/olamy | http://linkedin.com/in/olamy
>>
>>
>> 2011/9/17 Olivier Lamy <[hidden email]>:
>>> Results :
>>>
>>> Failed tests:
>>> testit(org.apache.maven.it.MavenITmng4387QuietLoggingTest):
>>> expected:<[]> but
>>> was:<[#############################################################,
>>> JRebel 4.0.3 (201107251640),  (c) Copyright ZeroTurnaround OU,
>>> Estonia, Tartu.,  Over the last 1 days JRebel prevented ,  at least 0
>>> redeploys/restarts saving you about 0 hours.,  This product is
>>> licensed to Olivier Lamy ([Open-Source] Jenkins) ,  until August 13,
>>> 2012,  With the following restrictions: ,  Only for open source
>>> development,  The following plugins are disabled at the moment: ,  *
>>> Apache Wink plugin 0.1 (set -Drebel.wink_plugin=true to enable),
>>> JRebel Apache Wink Plugin,  * Click plugin (set
>>> -Drebel.click_plugin=true to enable), Reloads menu.xml menu
>>> definitions of Apache Click projects.,  * Glassfish METRO plugin (set
>>> -Drebel.metro_plugin=true to enable), Supports METRO JAX-WS 2.2.3
>>> implementation of the JAX-WS standard,  * IceFaces plugin (set
>>> -Drebel.icefaces_plugin=true to enable), JRebel IceFaces Plugin,  *
>>> JAXB Plugin (set -Drebel.jaxb_plugin=true to enable), Enables support
>>> for class reloading to JAXB 2 RI,  * JBoss AOP plugin (set
>>> -Drebel.jbossaop_plugin=true to enable), Integration with jboss aop
>>> agent,  * Jackson plugin (set -Drebel.jackson_plugin=true to enable),
>>> Supports reloading Jackson's JsonSerializer caches.,  * Lift plugin
>>> (set -Drebel.lift_plugin=true to enable), Supports reloading singleton
>>> objects that extend RestHelper, MVCHelper,, LiftScreen or Wizard.,  *
>>> RESTEasy plugin (set -Drebel.resteasy_plugin=true to enable), Supports
>>> adding/changing methods with @Path annotation for RESTEasy
>>> application.,  * Seam-Wicket plugin (set
>>> -Drebel.seam_wicket_plugin=true to enable), Integration with load time
>>> weaving seam annotations to wicket classes,
>>> (-javaagent:<path-to-jboss-seam-wicket-jar>),  * Spring WS plugin (set
>>> -Drebel.springws_plugin=true to enable), Enables reloading of endpoint
>>> mappings and wsdl definitions in Spring Web, Services 2,  * WebObjects
>>> plugin (set -Drebel.webobjects_plugin=true to enable), WebObjects
>>> JRebel Plugin, #############################################################]>
>>>  testmng3652_UnConfiguredHttp(org.apache.maven.it.MavenITmng3652UserAgentHeaderTest):
>>> Comparing User-Agent 'Apache-HttpClient/4.1.2 (java 1.5)'
>>> expected:<Apache-[Maven/3.0.4-SNAPSHOT (Java 1.6.0_26; Mac OS X
>>> 10.7.1])> but was:<Apache-[HttpClient/4.1.2 (java 1.5])>
>>>  testmng3652_ConfigurationInSettingsWithoutUserAgent(org.apache.maven.it.MavenITmng3652UserAgentHeaderTest):
>>> Comparing User-Agent 'Apache-HttpClient/4.1.2 (java 1.5)'
>>> expected:<Apache-[Maven/3.0.4-SNAPSHOT (Java 1.6.0_26; Mac OS X
>>> 10.7.1])> but was:<Apache-[HttpClient/4.1.2 (java 1.5])>
>>>  testit(org.apache.maven.it.MavenITmng3183LoggingToFileTest):
>>> expected:<[]> but
>>> was:<[#############################################################,
>>> JRebel 4.0.3 (201107251640),  (c) Copyright ZeroTurnaround OU,
>>> Estonia, Tartu.,  Over the last 1 days JRebel prevented ,  at least 0
>>> redeploys/restarts saving you about 0 hours.,  This product is
>>> licensed to Olivier Lamy ([Open-Source] Jenkins) ,  until August 13,
>>> 2012,  With the following restrictions: ,  Only for open source
>>> development,  The following plugins are disabled at the moment: ,  *
>>> Apache Wink plugin 0.1 (set -Drebel.wink_plugin=true to enable),
>>> JRebel Apache Wink Plugin,  * Click plugin (set
>>> -Drebel.click_plugin=true to enable), Reloads menu.xml menu
>>> definitions of Apache Click projects.,  * Glassfish METRO plugin (set
>>> -Drebel.metro_plugin=true to enable), Supports METRO JAX-WS 2.2.3
>>> implementation of the JAX-WS standard,  * IceFaces plugin (set
>>> -Drebel.icefaces_plugin=true to enable), JRebel IceFaces Plugin,  *
>>> JAXB Plugin (set -Drebel.jaxb_plugin=true to enable), Enables support
>>> for class reloading to JAXB 2 RI,  * JBoss AOP plugin (set
>>> -Drebel.jbossaop_plugin=true to enable), Integration with jboss aop
>>> agent,  * Jackson plugin (set -Drebel.jackson_plugin=true to enable),
>>> Supports reloading Jackson's JsonSerializer caches.,  * Lift plugin
>>> (set -Drebel.lift_plugin=true to enable), Supports reloading singleton
>>> objects that extend RestHelper, MVCHelper,, LiftScreen or Wizard.,  *
>>> RESTEasy plugin (set -Drebel.resteasy_plugin=true to enable), Supports
>>> adding/changing methods with @Path annotation for RESTEasy
>>> application.,  * Seam-Wicket plugin (set
>>> -Drebel.seam_wicket_plugin=true to enable), Integration with load time
>>> weaving seam annotations to wicket classes,
>>> (-javaagent:<path-to-jboss-seam-wicket-jar>),  * Spring WS plugin (set
>>> -Drebel.springws_plugin=true to enable), Enables reloading of endpoint
>>> mappings and wsdl definitions in Spring Web, Services 2,  * WebObjects
>>> plugin (set -Drebel.webobjects_plugin=true to enable), WebObjects
>>> JRebel Plugin, #############################################################]>
>>>  testitPrefix(org.apache.maven.it.MavenITmng2741PluginMetadataResolutionErrorMessageTest):
>>> Transfer error cause was not found
>>>  testitVersion(org.apache.maven.it.MavenITmng2741PluginMetadataResolutionErrorMessageTest):
>>> Transfer error cause was not found
>>>
>>> Tests in error:
>>>  testit(org.apache.maven.it.MavenITmng2305MultipleProxiesTest): Exit
>>> code was non-zero: 1; command line and log =
>>>
>>> Tests run: 699, Failures: 6, Errors: 1, Skipped: 0
>>>
>>> It looks I have to remove jrebel from my MAVEN_OPTS to get it working :-)
>>>
>>> I will check for the other ones especially for the header User-Agent.
>>> MavenITmng4387QuietLoggingTest fail because there is a System.out in wagon-http.
>>>
>>> So not so bad.
>>>
>>> 2011/9/17 Jason van Zyl <[hidden email]>:
>>>> I assume all the ITs pass with this change?
>>>>
>>>> On Sep 17, 2011, at 2:13 PM, Olivier Lamy wrote:
>>>>
>>>>> Hi Folks,
>>>>> With WAGON-348, the wagon-http based on Apache HttpClient include now
>>>>> http connection pool mechanism.
>>>>> This prevent creating http(s) connection for each artifacts requests !
>>>>> The patch simply remove lightweight and replace it with a shaded jar
>>>>> of wagon http with classes relocation of dependencies.
>>>>>
>>>>> If no objections, I will commit this.
>>>>>
>>>>> Thanks,
>>>>> --
>>>>> Olivier Lamy
>>>>> Talend : http://talend.com
>>>>> http://twitter.com/olamy | http://linkedin.com/in/olamy
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: [hidden email]
>>>>> For additional commands, e-mail: [hidden email]
>>>>>
>>>>
>>>> Thanks,
>>>>
>>>> Jason
>>>>
>>>> ----------------------------------------------------------
>>>> Jason van Zyl
>>>> Founder,  Apache Maven
>>>> http://twitter.com/jvanzyl
>>>> ---------------------------------------------------------
>>>>
>>>>
>>>>
>>>>
>>>>
>>>
>>>
>>>
>>> --
>>> Olivier Lamy
>>> Talend : http://talend.com
>>> http://twitter.com/olamy | http://linkedin.com/in/olamy
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>



--
Olivier Lamy
Talend : http://talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: MNG-5175 : replace wagon http lightweight with wagon http 2.0

Jason van Zyl
In reply to this post by olamy
If all the ITs pass then that's the acid test. If you want to take care of a new transport then go for it.

On Sep 18, 2011, at 12:17 PM, Olivier Lamy wrote:

> Small fixes in wagon and now all its are fine.
>
> Tests run: 699, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1,378.237 sec
>
> Results :
>
> Tests run: 699, Failures: 0, Errors: 0, Skipped: 0
>
> So at least OMMIW  :-).
>
> If no more objections, I will commit that and btw start a wagon 2.0 release.
>
> Thanks,
> --
> Olivier Lamy
> Talend : http://talend.com
> http://twitter.com/olamy | http://linkedin.com/in/olamy
>
>
> 2011/9/17 Olivier Lamy <[hidden email]>:
>> Results :
>>
>> Failed tests:
>> testit(org.apache.maven.it.MavenITmng4387QuietLoggingTest):
>> expected:<[]> but
>> was:<[#############################################################,
>> JRebel 4.0.3 (201107251640),  (c) Copyright ZeroTurnaround OU,
>> Estonia, Tartu.,  Over the last 1 days JRebel prevented ,  at least 0
>> redeploys/restarts saving you about 0 hours.,  This product is
>> licensed to Olivier Lamy ([Open-Source] Jenkins) ,  until August 13,
>> 2012,  With the following restrictions: ,  Only for open source
>> development,  The following plugins are disabled at the moment: ,  *
>> Apache Wink plugin 0.1 (set -Drebel.wink_plugin=true to enable),
>> JRebel Apache Wink Plugin,  * Click plugin (set
>> -Drebel.click_plugin=true to enable), Reloads menu.xml menu
>> definitions of Apache Click projects.,  * Glassfish METRO plugin (set
>> -Drebel.metro_plugin=true to enable), Supports METRO JAX-WS 2.2.3
>> implementation of the JAX-WS standard,  * IceFaces plugin (set
>> -Drebel.icefaces_plugin=true to enable), JRebel IceFaces Plugin,  *
>> JAXB Plugin (set -Drebel.jaxb_plugin=true to enable), Enables support
>> for class reloading to JAXB 2 RI,  * JBoss AOP plugin (set
>> -Drebel.jbossaop_plugin=true to enable), Integration with jboss aop
>> agent,  * Jackson plugin (set -Drebel.jackson_plugin=true to enable),
>> Supports reloading Jackson's JsonSerializer caches.,  * Lift plugin
>> (set -Drebel.lift_plugin=true to enable), Supports reloading singleton
>> objects that extend RestHelper, MVCHelper,, LiftScreen or Wizard.,  *
>> RESTEasy plugin (set -Drebel.resteasy_plugin=true to enable), Supports
>> adding/changing methods with @Path annotation for RESTEasy
>> application.,  * Seam-Wicket plugin (set
>> -Drebel.seam_wicket_plugin=true to enable), Integration with load time
>> weaving seam annotations to wicket classes,
>> (-javaagent:<path-to-jboss-seam-wicket-jar>),  * Spring WS plugin (set
>> -Drebel.springws_plugin=true to enable), Enables reloading of endpoint
>> mappings and wsdl definitions in Spring Web, Services 2,  * WebObjects
>> plugin (set -Drebel.webobjects_plugin=true to enable), WebObjects
>> JRebel Plugin, #############################################################]>
>>  testmng3652_UnConfiguredHttp(org.apache.maven.it.MavenITmng3652UserAgentHeaderTest):
>> Comparing User-Agent 'Apache-HttpClient/4.1.2 (java 1.5)'
>> expected:<Apache-[Maven/3.0.4-SNAPSHOT (Java 1.6.0_26; Mac OS X
>> 10.7.1])> but was:<Apache-[HttpClient/4.1.2 (java 1.5])>
>>  testmng3652_ConfigurationInSettingsWithoutUserAgent(org.apache.maven.it.MavenITmng3652UserAgentHeaderTest):
>> Comparing User-Agent 'Apache-HttpClient/4.1.2 (java 1.5)'
>> expected:<Apache-[Maven/3.0.4-SNAPSHOT (Java 1.6.0_26; Mac OS X
>> 10.7.1])> but was:<Apache-[HttpClient/4.1.2 (java 1.5])>
>>  testit(org.apache.maven.it.MavenITmng3183LoggingToFileTest):
>> expected:<[]> but
>> was:<[#############################################################,
>> JRebel 4.0.3 (201107251640),  (c) Copyright ZeroTurnaround OU,
>> Estonia, Tartu.,  Over the last 1 days JRebel prevented ,  at least 0
>> redeploys/restarts saving you about 0 hours.,  This product is
>> licensed to Olivier Lamy ([Open-Source] Jenkins) ,  until August 13,
>> 2012,  With the following restrictions: ,  Only for open source
>> development,  The following plugins are disabled at the moment: ,  *
>> Apache Wink plugin 0.1 (set -Drebel.wink_plugin=true to enable),
>> JRebel Apache Wink Plugin,  * Click plugin (set
>> -Drebel.click_plugin=true to enable), Reloads menu.xml menu
>> definitions of Apache Click projects.,  * Glassfish METRO plugin (set
>> -Drebel.metro_plugin=true to enable), Supports METRO JAX-WS 2.2.3
>> implementation of the JAX-WS standard,  * IceFaces plugin (set
>> -Drebel.icefaces_plugin=true to enable), JRebel IceFaces Plugin,  *
>> JAXB Plugin (set -Drebel.jaxb_plugin=true to enable), Enables support
>> for class reloading to JAXB 2 RI,  * JBoss AOP plugin (set
>> -Drebel.jbossaop_plugin=true to enable), Integration with jboss aop
>> agent,  * Jackson plugin (set -Drebel.jackson_plugin=true to enable),
>> Supports reloading Jackson's JsonSerializer caches.,  * Lift plugin
>> (set -Drebel.lift_plugin=true to enable), Supports reloading singleton
>> objects that extend RestHelper, MVCHelper,, LiftScreen or Wizard.,  *
>> RESTEasy plugin (set -Drebel.resteasy_plugin=true to enable), Supports
>> adding/changing methods with @Path annotation for RESTEasy
>> application.,  * Seam-Wicket plugin (set
>> -Drebel.seam_wicket_plugin=true to enable), Integration with load time
>> weaving seam annotations to wicket classes,
>> (-javaagent:<path-to-jboss-seam-wicket-jar>),  * Spring WS plugin (set
>> -Drebel.springws_plugin=true to enable), Enables reloading of endpoint
>> mappings and wsdl definitions in Spring Web, Services 2,  * WebObjects
>> plugin (set -Drebel.webobjects_plugin=true to enable), WebObjects
>> JRebel Plugin, #############################################################]>
>>  testitPrefix(org.apache.maven.it.MavenITmng2741PluginMetadataResolutionErrorMessageTest):
>> Transfer error cause was not found
>>  testitVersion(org.apache.maven.it.MavenITmng2741PluginMetadataResolutionErrorMessageTest):
>> Transfer error cause was not found
>>
>> Tests in error:
>>  testit(org.apache.maven.it.MavenITmng2305MultipleProxiesTest): Exit
>> code was non-zero: 1; command line and log =
>>
>> Tests run: 699, Failures: 6, Errors: 1, Skipped: 0
>>
>> It looks I have to remove jrebel from my MAVEN_OPTS to get it working :-)
>>
>> I will check for the other ones especially for the header User-Agent.
>> MavenITmng4387QuietLoggingTest fail because there is a System.out in wagon-http.
>>
>> So not so bad.
>>
>> 2011/9/17 Jason van Zyl <[hidden email]>:
>>> I assume all the ITs pass with this change?
>>>
>>> On Sep 17, 2011, at 2:13 PM, Olivier Lamy wrote:
>>>
>>>> Hi Folks,
>>>> With WAGON-348, the wagon-http based on Apache HttpClient include now
>>>> http connection pool mechanism.
>>>> This prevent creating http(s) connection for each artifacts requests !
>>>> The patch simply remove lightweight and replace it with a shaded jar
>>>> of wagon http with classes relocation of dependencies.
>>>>
>>>> If no objections, I will commit this.
>>>>
>>>> Thanks,
>>>> --
>>>> Olivier Lamy
>>>> Talend : http://talend.com
>>>> http://twitter.com/olamy | http://linkedin.com/in/olamy
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: [hidden email]
>>>> For additional commands, e-mail: [hidden email]
>>>>
>>>
>>> Thanks,
>>>
>>> Jason
>>>
>>> ----------------------------------------------------------
>>> Jason van Zyl
>>> Founder,  Apache Maven
>>> http://twitter.com/jvanzyl
>>> ---------------------------------------------------------
>>>
>>>
>>>
>>>
>>>
>>
>>
>>
>> --
>> Olivier Lamy
>> Talend : http://talend.com
>> http://twitter.com/olamy | http://linkedin.com/in/olamy
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

Thanks,

Jason

----------------------------------------------------------
Jason van Zyl
Founder,  Apache Maven
http://twitter.com/jvanzyl
---------------------------------------------------------

believe nothing, no matter where you read it,
or who has said it,
not even if i have said it,
unless it agrees with your own reason
and your own common sense.

 -- Buddha



Reply | Threaded
Open this post in threaded view
|

Re: MNG-5175 : replace wagon http lightweight with wagon http 2.0

brettporter
Administrator
In reply to this post by olamy

On 18/09/2011, at 4:13 AM, Olivier Lamy wrote:

> Hi Folks,
> With WAGON-348, the wagon-http based on Apache HttpClient include now
> http connection pool mechanism.

Nice work :)

> If no objections, I will commit this.


I'd say go ahead and commit.

One thing we should test - John had an ongoing battle with the wagons and double uploading / checksum corruption. With the earlier versions of wagon-http, that problem still existed.

I expect it'd be fixed by the combination of upgrading the httpclient and http://jira.codehaus.org/browse/WAGON-347, but it'd be good if he could weigh in. I'll see if I can reproduce on my end too.

- Brett

--
Brett Porter
[hidden email]
http://brettporter.wordpress.com/
http://au.linkedin.com/in/brettporter





---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: MNG-5175 : replace wagon http lightweight with wagon http 2.0

olamy
FYI, I have committed this and leave the issue open until wagon 2.0 release.

I will start a wagon release later this week

2011/9/19 Brett Porter <[hidden email]>:

>
> On 18/09/2011, at 4:13 AM, Olivier Lamy wrote:
>
>> Hi Folks,
>> With WAGON-348, the wagon-http based on Apache HttpClient include now
>> http connection pool mechanism.
>
> Nice work :)
>
>> If no objections, I will commit this.
>
>
> I'd say go ahead and commit.
>
> One thing we should test - John had an ongoing battle with the wagons and double uploading / checksum corruption. With the earlier versions of wagon-http, that problem still existed.
>
> I expect it'd be fixed by the combination of upgrading the httpclient and http://jira.codehaus.org/browse/WAGON-347, but it'd be good if he could weigh in. I'll see if I can reproduce on my end too.
>
> - Brett
>
> --
> Brett Porter
> [hidden email]
> http://brettporter.wordpress.com/
> http://au.linkedin.com/in/brettporter
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>



--
Olivier Lamy
Talend : http://talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: MNG-5175 : replace wagon http lightweight with wagon http 2.0

jdcasey
In reply to this post by brettporter


On 9/19/11 4:14 AM, Brett Porter wrote:

>
> On 18/09/2011, at 4:13 AM, Olivier Lamy wrote:
>
>> Hi Folks,
>> With WAGON-348, the wagon-http based on Apache HttpClient include now
>> http connection pool mechanism.
>
> Nice work :)
>
>> If no objections, I will commit this.
>
>
> I'd say go ahead and commit.
>
> One thing we should test - John had an ongoing battle with the wagons and double uploading / checksum corruption. With the earlier versions of wagon-http, that problem still existed.
>
> I expect it'd be fixed by the combination of upgrading the httpclient and http://jira.codehaus.org/browse/WAGON-347, but it'd be good if he could weigh in. I'll see if I can reproduce on my end too.

IIRC, the big problem was that httpclient 3.x didn't use preemptive
authentication when you set a username/password. While the lightweight
implementation didn't either, it seemed to cache the fact that it used
authentication, and then preemptively use it on subsequent calls.

The effect of non-preemptive authentication was that you would PUT an
entire jar, zip, pom, whatever (some of which are quite large)...then
the server would reply with WWW-Authenticate, and you'd have to do it
all again, this time with credentials. I don't exactly remember how the
doubling of the checksum was resolved in the context of this problem, or
for sure that it was...but ISTR the checksums weren't the real problem
in the end, it was the upload timeouts on large files.

So, if httpclient 4.x has a better strategy for handling authentication,
I'd say we're good to go.

BTW, do any of the tests actually check PUTing a file and ensuring it
isn't sent twice?

>
> - Brett
>
> --
> Brett Porter
> [hidden email]
> http://brettporter.wordpress.com/
> http://au.linkedin.com/in/brettporter
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

--
John Casey
Developer, PMC Chair - Apache Maven (http://maven.apache.org)
Blog: http://www.johnofalltrades.name/

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: MNG-5175 : replace wagon http lightweight with wagon http 2.0

olamy
2011/9/19 John Casey <[hidden email]>:

>
>
> On 9/19/11 4:14 AM, Brett Porter wrote:
>>
>> On 18/09/2011, at 4:13 AM, Olivier Lamy wrote:
>>
>>> Hi Folks,
>>> With WAGON-348, the wagon-http based on Apache HttpClient include now
>>> http connection pool mechanism.
>>
>> Nice work :)
>>
>>> If no objections, I will commit this.
>>
>>
>> I'd say go ahead and commit.
>>
>> One thing we should test - John had an ongoing battle with the wagons and
>> double uploading / checksum corruption. With the earlier versions of
>> wagon-http, that problem still existed.
>>
>> I expect it'd be fixed by the combination of upgrading the httpclient and
>> http://jira.codehaus.org/browse/WAGON-347, but it'd be good if he could
>> weigh in. I'll see if I can reproduce on my end too.
>
> IIRC, the big problem was that httpclient 3.x didn't use preemptive
> authentication when you set a username/password. While the lightweight
> implementation didn't either, it seemed to cache the fact that it used
> authentication, and then preemptively use it on subsequent calls.
>
> The effect of non-preemptive authentication was that you would PUT an entire
> jar, zip, pom, whatever (some of which are quite large)...then the server
> would reply with WWW-Authenticate, and you'd have to do it all again, this
> time with credentials. I don't exactly remember how the doubling of the
> checksum was resolved in the context of this problem, or for sure that it
> was...but ISTR the checksums weren't the real problem in the end, it was the
> upload timeouts on large files.
>
> So, if httpclient 4.x has a better strategy for handling authentication, I'd
> say we're good to go.
>
> BTW, do any of the tests actually check PUTing a file and ensuring it isn't
> sent twice?
good idea to add a unit test for that: I will do it !

>
>>
>> - Brett
>>
>> --
>> Brett Porter
>> [hidden email]
>> http://brettporter.wordpress.com/
>> http://au.linkedin.com/in/brettporter
>>
>>
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>
> --
> John Casey
> Developer, PMC Chair - Apache Maven (http://maven.apache.org)
> Blog: http://www.johnofalltrades.name/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>



--
Olivier Lamy
Talend : http://talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: MNG-5175 : replace wagon http lightweight with wagon http 2.0

olamy
test added on trunk and branch.

2011/9/19 Olivier Lamy <[hidden email]>:

> 2011/9/19 John Casey <[hidden email]>:
>>
>>
>> On 9/19/11 4:14 AM, Brett Porter wrote:
>>>
>>> On 18/09/2011, at 4:13 AM, Olivier Lamy wrote:
>>>
>>>> Hi Folks,
>>>> With WAGON-348, the wagon-http based on Apache HttpClient include now
>>>> http connection pool mechanism.
>>>
>>> Nice work :)
>>>
>>>> If no objections, I will commit this.
>>>
>>>
>>> I'd say go ahead and commit.
>>>
>>> One thing we should test - John had an ongoing battle with the wagons and
>>> double uploading / checksum corruption. With the earlier versions of
>>> wagon-http, that problem still existed.
>>>
>>> I expect it'd be fixed by the combination of upgrading the httpclient and
>>> http://jira.codehaus.org/browse/WAGON-347, but it'd be good if he could
>>> weigh in. I'll see if I can reproduce on my end too.
>>
>> IIRC, the big problem was that httpclient 3.x didn't use preemptive
>> authentication when you set a username/password. While the lightweight
>> implementation didn't either, it seemed to cache the fact that it used
>> authentication, and then preemptively use it on subsequent calls.
>>
>> The effect of non-preemptive authentication was that you would PUT an entire
>> jar, zip, pom, whatever (some of which are quite large)...then the server
>> would reply with WWW-Authenticate, and you'd have to do it all again, this
>> time with credentials. I don't exactly remember how the doubling of the
>> checksum was resolved in the context of this problem, or for sure that it
>> was...but ISTR the checksums weren't the real problem in the end, it was the
>> upload timeouts on large files.
>>
>> So, if httpclient 4.x has a better strategy for handling authentication, I'd
>> say we're good to go.
>>
>> BTW, do any of the tests actually check PUTing a file and ensuring it isn't
>> sent twice?
> good idea to add a unit test for that: I will do it !
>>
>>>
>>> - Brett
>>>
>>> --
>>> Brett Porter
>>> [hidden email]
>>> http://brettporter.wordpress.com/
>>> http://au.linkedin.com/in/brettporter
>>>
>>>
>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [hidden email]
>>> For additional commands, e-mail: [hidden email]
>>>
>>
>> --
>> John Casey
>> Developer, PMC Chair - Apache Maven (http://maven.apache.org)
>> Blog: http://www.johnofalltrades.name/
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>>
>
>
>
> --
> Olivier Lamy
> Talend : http://talend.com
> http://twitter.com/olamy | http://linkedin.com/in/olamy
>



--
Olivier Lamy
Talend : http://talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]