MINSTALL-134 -

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

MINSTALL-134 -

Karl Heinz Marbaise-3
Hi to all,

I have taken a deeper look into the issue to remove the installation of
checksums and move that to the deployment part...This means to remove
the configuration for checksum generation (plus the code) in the
maven-artifact-transfer component and furthermore changes in the
maven-install-plugin.

But I came across a thing which I don't understand at the moment...

If I dive into the code of maven-artifact-transfer I found something
like this (this is originally transfered from maven-install-plugin):

         Artifact artifact = project.getArtifact();
         String packaging = project.getPackaging();
         File pomFile = project.getFile();

         List<Artifact> attachedArtifacts = project.getAttachedArtifacts();

         // TODO: push into transformation
         boolean isPomArtifact = "pom".equals( packaging );

         ProjectArtifactMetadata metadata;

         if ( updateReleaseInfo )
         {
             artifact.setRelease( true );
         }


in particular the last part...setting artifact.setRelease(true) which If
i correctly understand is simply wrong, cause that would set the
information of the artifact being a release and not a SNAPSHOT ...

Taken also a look into maven-install-plugin which has a property:

     @Parameter( property = "updateReleaseInfo", defaultValue = "false" )
     protected boolean updateReleaseInfo;

which from my point of view does not make sense cause an release
identified by not ending with "-SNAPSHOT" of the version....

So this means to me that this code can be / or better must be removed ?


Kind regards
Karl Heinz Marbaise


[1]: https://issues.apache.org/jira/browse/MINSTALL-134

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: MINSTALL-134 -

Karl Heinz Marbaise-3
Hi Robert,

On 06/08/17 23:29, Robert Scholte wrote:
> Hi Karl Heinz,
>
> Based on the blame on this file, you should be the one being able to
> explain this ;)

To be honest No..cause I've taken that code from maven-install-plugin
...I've rechecked it's exactly the same in current version 2.5.2 of
maven-install-plugin...see [1]

> I assume the base is coming from maven-install-plugin and some logic got
> lost during refactoring.

And checked it and there seemed to be not something gone lost...;-)

Maybe my question was not clear enough...

Do you have an idea for what the property in maven-install-plugin
(current version 2.5.2) is used: updateReleaseInfo ?

This would set the release boolean flag in
org.apache.maven.artifact.Artifact (maven-artifact package v:3.0)...

 From my point of view this property nor the usage make sense for me

If a release is a release should only being identified by *NOT* having
"-SNAPSHOT" in the version or not...Or do I misunderstand a thing here..

This would mean in consequence that the code in Artifact should be
changed or at least marked deprecated...maybe more...

Kind regards
Karl Heinz Marbaise


[1]:
http://svn.apache.org/viewvc/maven/plugins/tags/maven-install-plugin-2.5.2/src/main/java/org/apache/maven/plugin/install/InstallMojo.java?revision=1620968&view=markup#l173

>
> thanks,
> Robert
>
>
> On Sat, 05 Aug 2017 22:48:48 +0200, Karl Heinz Marbaise
> <[hidden email]> wrote:
>
>> Hi to all,
>>
>> I have taken a deeper look into the issue to remove the installation
>> of checksums and move that to the deployment part...This means to
>> remove the configuration for checksum generation (plus the code) in
>> the maven-artifact-transfer component and furthermore changes in the
>> maven-install-plugin.
>>
>> But I came across a thing which I don't understand at the moment...
>>
>> If I dive into the code of maven-artifact-transfer I found something
>> like this (this is originally transfered from maven-install-plugin):
>>
>>          Artifact artifact = project.getArtifact();
>>          String packaging = project.getPackaging();
>>          File pomFile = project.getFile();
>>
>>          List<Artifact> attachedArtifacts =
>> project.getAttachedArtifacts();
>>
>>          // TODO: push into transformation
>>          boolean isPomArtifact = "pom".equals( packaging );
>>
>>          ProjectArtifactMetadata metadata;
>>
>>          if ( updateReleaseInfo )
>>          {
>>              artifact.setRelease( true );
>>          }
>>
>>
>> in particular the last part...setting artifact.setRelease(true) which
>> If i correctly understand is simply wrong, cause that would set the
>> information of the artifact being a release and not a SNAPSHOT ...
>>
>> Taken also a look into maven-install-plugin which has a property:
>>
>>      @Parameter( property = "updateReleaseInfo", defaultValue = "false" )
>>      protected boolean updateReleaseInfo;
>>
>> which from my point of view does not make sense cause an release
>> identified by not ending with "-SNAPSHOT" of the version....
>>
>> So this means to me that this code can be / or better must be removed ?
>>
>>
>> Kind regards
>> Karl Heinz Marbaise
>>
>>
>> [1]: https://issues.apache.org/jira/browse/MINSTALL-134

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: MINSTALL-134 -

rfscholte
Just an idea: it is for the timestamped snapshot.
With M2 you had the option to upload a SNAPSHOT without timestamp, this  
has changed with M3.
But that should only has effect on deploy, not install.

Now that ASM-6.0_BETA is available I need to work on quite some plugins  
first in order to get most of them working before the launch of J9

Robert

On Mon, 07 Aug 2017 19:46:33 +0200, Karl Heinz Marbaise  
<[hidden email]> wrote:

> Hi Robert,
>
> On 06/08/17 23:29, Robert Scholte wrote:
>> Hi Karl Heinz,
>>  Based on the blame on this file, you should be the one being able to  
>> explain this ;)
>
> To be honest No..cause I've taken that code from maven-install-plugin  
> ...I've rechecked it's exactly the same in current version 2.5.2 of  
> maven-install-plugin...see [1]
>
>> I assume the base is coming from maven-install-plugin and some logic  
>> got lost during refactoring.
>
> And checked it and there seemed to be not something gone lost...;-)
>
> Maybe my question was not clear enough...
>
> Do you have an idea for what the property in maven-install-plugin  
> (current version 2.5.2) is used: updateReleaseInfo ?
>
> This would set the release boolean flag in  
> org.apache.maven.artifact.Artifact (maven-artifact package v:3.0)...
>
>  From my point of view this property nor the usage make sense for me
>
> If a release is a release should only being identified by *NOT* having  
> "-SNAPSHOT" in the version or not...Or do I misunderstand a thing here..
>
> This would mean in consequence that the code in Artifact should be  
> changed or at least marked deprecated...maybe more...
>
> Kind regards
> Karl Heinz Marbaise
>
>
> [1]:  
> http://svn.apache.org/viewvc/maven/plugins/tags/maven-install-plugin-2.5.2/src/main/java/org/apache/maven/plugin/install/InstallMojo.java?revision=1620968&view=markup#l173
>
>>  thanks,
>> Robert
>>   On Sat, 05 Aug 2017 22:48:48 +0200, Karl Heinz Marbaise  
>> <[hidden email]> wrote:
>>
>>> Hi to all,
>>>
>>> I have taken a deeper look into the issue to remove the installation  
>>> of checksums and move that to the deployment part...This means to  
>>> remove the configuration for checksum generation (plus the code) in  
>>> the maven-artifact-transfer component and furthermore changes in the  
>>> maven-install-plugin.
>>>
>>> But I came across a thing which I don't understand at the moment...
>>>
>>> If I dive into the code of maven-artifact-transfer I found something  
>>> like this (this is originally transfered from maven-install-plugin):
>>>
>>>          Artifact artifact = project.getArtifact();
>>>          String packaging = project.getPackaging();
>>>          File pomFile = project.getFile();
>>>
>>>          List<Artifact> attachedArtifacts =  
>>> project.getAttachedArtifacts();
>>>
>>>          // TODO: push into transformation
>>>          boolean isPomArtifact = "pom".equals( packaging );
>>>
>>>          ProjectArtifactMetadata metadata;
>>>
>>>          if ( updateReleaseInfo )
>>>          {
>>>              artifact.setRelease( true );
>>>          }
>>>
>>>
>>> in particular the last part...setting artifact.setRelease(true) which  
>>> If i correctly understand is simply wrong, cause that would set the  
>>> information of the artifact being a release and not a SNAPSHOT ...
>>>
>>> Taken also a look into maven-install-plugin which has a property:
>>>
>>>      @Parameter( property = "updateReleaseInfo", defaultValue =  
>>> "false" )
>>>      protected boolean updateReleaseInfo;
>>>
>>> which from my point of view does not make sense cause an release  
>>> identified by not ending with "-SNAPSHOT" of the version....
>>>
>>> So this means to me that this code can be / or better must be removed ?
>>>
>>>
>>> Kind regards
>>> Karl Heinz Marbaise
>>>
>>>
>>> [1]: https://issues.apache.org/jira/browse/MINSTALL-134
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Loading...