[MDEP-269] please review

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[MDEP-269] please review

nicolas de loof-2
Hi folks,

I'm working on MDEP-269 <http://jira.codehaus.org/browse/MDEP-269> - convert
a legacy lib/*.jar to maven <dependencies>
I've attached a patch to Jira as I'd like your opinion on the way to support
this use case.

My patch uses Nexus REST API to query the repository manager for artifacts
based on local files SHA1 hash.
The query URL is configurable, and the Xpath expression to extract data
should also, so that a non-nexus repository manager that provides comparable
feature may be user.

Maybe there is more performant/portable way to do this,
for example using repository index generated by Nexus (not sure if other
repository manager do the same) but this one doesn't include the artifacts
hash yet (NEXUS-3596 <http://issues.sonatype.org/browse/NEXUS-3596>)

WDYT ?

Nicolas
Reply | Threaded
Open this post in threaded view
|

Re: [MDEP-269] please review

Tamás Cservenák
I don't get it, what do you mean by "repository index generated by Nexus ...
doesn't include the artifact hash"?

What makes you think hash is not on the index?

Thanks,
~t~

On Fri, Jun 18, 2010 at 11:52 AM, nicolas de loof
<[hidden email]>wrote:

> Hi folks,
>
> I'm working on MDEP-269 <http://jira.codehaus.org/browse/MDEP-269> -
> convert
> a legacy lib/*.jar to maven <dependencies>
> I've attached a patch to Jira as I'd like your opinion on the way to
> support
> this use case.
>
> My patch uses Nexus REST API to query the repository manager for artifacts
> based on local files SHA1 hash.
> The query URL is configurable, and the Xpath expression to extract data
> should also, so that a non-nexus repository manager that provides
> comparable
> feature may be user.
>
> Maybe there is more performant/portable way to do this,
> for example using repository index generated by Nexus (not sure if other
> repository manager do the same) but this one doesn't include the artifacts
> hash yet (NEXUS-3596 <http://issues.sonatype.org/browse/NEXUS-3596>)
>
> WDYT ?
>
> Nicolas
>
Reply | Threaded
Open this post in threaded view
|

Re: [MDEP-269] please review

nicolas de loof-2
I discussed with the author of alf-maven-osecm (that suggested me this
feature) and he reported me he first tried to use the repo index but didn't
find the hash in it. I've not tried by myslef. If hash is included, please
close my Jira issue on Nexus and I'll double check this.

2010/6/18 Tamás Cservenák <[hidden email]>

> I don't get it, what do you mean by "repository index generated by Nexus
> ...
> doesn't include the artifact hash"?
>
> What makes you think hash is not on the index?
>
> Thanks,
> ~t~
>
> On Fri, Jun 18, 2010 at 11:52 AM, nicolas de loof
> <[hidden email]>wrote:
>
> > Hi folks,
> >
> > I'm working on MDEP-269 <http://jira.codehaus.org/browse/MDEP-269> -
> > convert
> > a legacy lib/*.jar to maven <dependencies>
> > I've attached a patch to Jira as I'd like your opinion on the way to
> > support
> > this use case.
> >
> > My patch uses Nexus REST API to query the repository manager for
> artifacts
> > based on local files SHA1 hash.
> > The query URL is configurable, and the Xpath expression to extract data
> > should also, so that a non-nexus repository manager that provides
> > comparable
> > feature may be user.
> >
> > Maybe there is more performant/portable way to do this,
> > for example using repository index generated by Nexus (not sure if other
> > repository manager do the same) but this one doesn't include the
> artifacts
> > hash yet (NEXUS-3596 <http://issues.sonatype.org/browse/NEXUS-3596>)
> >
> > WDYT ?
> >
> > Nicolas
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: [MDEP-269] please review

Tamás Cservenák
Well, we had an issue:

https://issues.sonatype.org/browse/NEXUS-644

but it was fixed more then a year ago... maybe he suffered from that one?

But index downloaded from central was never suffering from this issue (it is
not a Nexus instance, and Central would not be a group anyway). Use the
latest release of Nexus Indexer and please test it. If you find hashes
usable, please close the issue.

Note: In issue above MD5 hashes are mentioned, but MD5 is not supported
anymore, not on index. Only SHA1 hashes are.

Thanks,
~t~

On Fri, Jun 18, 2010 at 10:35 PM, nicolas de loof
<[hidden email]>wrote:

> I discussed with the author of alf-maven-osecm (that suggested me this
> feature) and he reported me he first tried to use the repo index but didn't
> find the hash in it. I've not tried by myslef. If hash is included, please
> close my Jira issue on Nexus and I'll double check this.
>
> 2010/6/18 Tamás Cservenák <[hidden email]>
>
> > I don't get it, what do you mean by "repository index generated by Nexus
> > ...
> > doesn't include the artifact hash"?
> >
> > What makes you think hash is not on the index?
> >
> > Thanks,
> > ~t~
> >
> > On Fri, Jun 18, 2010 at 11:52 AM, nicolas de loof
> > <[hidden email]>wrote:
> >
> > > Hi folks,
> > >
> > > I'm working on MDEP-269 <http://jira.codehaus.org/browse/MDEP-269> -
> > > convert
> > > a legacy lib/*.jar to maven <dependencies>
> > > I've attached a patch to Jira as I'd like your opinion on the way to
> > > support
> > > this use case.
> > >
> > > My patch uses Nexus REST API to query the repository manager for
> > artifacts
> > > based on local files SHA1 hash.
> > > The query URL is configurable, and the Xpath expression to extract data
> > > should also, so that a non-nexus repository manager that provides
> > > comparable
> > > feature may be user.
> > >
> > > Maybe there is more performant/portable way to do this,
> > > for example using repository index generated by Nexus (not sure if
> other
> > > repository manager do the same) but this one doesn't include the
> > artifacts
> > > hash yet (NEXUS-3596 <http://issues.sonatype.org/browse/NEXUS-3596>)
> > >
> > > WDYT ?
> > >
> > > Nicolas
> > >
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: [MDEP-269] please review

nicolas de loof-2
I tried to write an alternate implementation of MDEP-269 using nexus indexer
API, based on samples found on sonatype blog.

I got some few issues :

I had to add sonatype forge as repository to resolve dependencies, not
really pleasant as the maven plugin is expected to build using central repo.

I had to stub the plexus Logger Component with SilentLoger - maven 2.2.1
doesn't provides such component

I get an error when running the indexUpdater
: java.lang.ClassNotFoundException:
org.eclipse.jetty.client.security.Authorization - I can't find a dependency
to this eclipse plugin in nexus-indexer POM.xml

Maybe you can help me on last issue, but the first one is a blocker AFAIK to
be used in Maven Dependency Plugin.

Nicolas

2010/6/18 Tamás Cservenák <[hidden email]>

> Well, we had an issue:
>
> https://issues.sonatype.org/browse/NEXUS-644
>
> but it was fixed more then a year ago... maybe he suffered from that one?
>
> But index downloaded from central was never suffering from this issue (it
> is
> not a Nexus instance, and Central would not be a group anyway). Use the
> latest release of Nexus Indexer and please test it. If you find hashes
> usable, please close the issue.
>
> Note: In issue above MD5 hashes are mentioned, but MD5 is not supported
> anymore, not on index. Only SHA1 hashes are.
>
> Thanks,
> ~t~
>
> On Fri, Jun 18, 2010 at 10:35 PM, nicolas de loof
> <[hidden email]>wrote:
>
> > I discussed with the author of alf-maven-osecm (that suggested me this
> > feature) and he reported me he first tried to use the repo index but
> didn't
> > find the hash in it. I've not tried by myslef. If hash is included,
> please
> > close my Jira issue on Nexus and I'll double check this.
> >
> > 2010/6/18 Tamás Cservenák <[hidden email]>
> >
> > > I don't get it, what do you mean by "repository index generated by
> Nexus
> > > ...
> > > doesn't include the artifact hash"?
> > >
> > > What makes you think hash is not on the index?
> > >
> > > Thanks,
> > > ~t~
> > >
> > > On Fri, Jun 18, 2010 at 11:52 AM, nicolas de loof
> > > <[hidden email]>wrote:
> > >
> > > > Hi folks,
> > > >
> > > > I'm working on MDEP-269 <http://jira.codehaus.org/browse/MDEP-269> -
> > > > convert
> > > > a legacy lib/*.jar to maven <dependencies>
> > > > I've attached a patch to Jira as I'd like your opinion on the way to
> > > > support
> > > > this use case.
> > > >
> > > > My patch uses Nexus REST API to query the repository manager for
> > > artifacts
> > > > based on local files SHA1 hash.
> > > > The query URL is configurable, and the Xpath expression to extract
> data
> > > > should also, so that a non-nexus repository manager that provides
> > > > comparable
> > > > feature may be user.
> > > >
> > > > Maybe there is more performant/portable way to do this,
> > > > for example using repository index generated by Nexus (not sure if
> > other
> > > > repository manager do the same) but this one doesn't include the
> > > artifacts
> > > > hash yet (NEXUS-3596 <http://issues.sonatype.org/browse/NEXUS-3596>)
> > > >
> > > > WDYT ?
> > > >
> > > > Nicolas
> > > >
> > >
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: [MDEP-269] please review

nicolas de loof-2
>
> I get an error when running the indexUpdater
> : java.lang.ClassNotFoundException:
> org.eclipse.jetty.client.security.Authorization - I can't find a dependency
> to this eclipse plugin in nexus-indexer POM.xml
>
>
> This one is solved, I wasn't looking at the correct POM :-/
sory

Nicolas
Reply | Threaded
Open this post in threaded view
|

Re: [MDEP-269] please review

Brian Fox-2
In reply to this post by nicolas de loof-2
If you're using the nexus api, then this belongs in the
nexus-maven-plugin, not the maven-dependency-plugin.

On Mon, Jun 21, 2010 at 8:39 AM, nicolas de loof
<[hidden email]> wrote:

> I tried to write an alternate implementation of MDEP-269 using nexus indexer
> API, based on samples found on sonatype blog.
>
> I got some few issues :
>
> I had to add sonatype forge as repository to resolve dependencies, not
> really pleasant as the maven plugin is expected to build using central repo.
>
> I had to stub the plexus Logger Component with SilentLoger - maven 2.2.1
> doesn't provides such component
>
> I get an error when running the indexUpdater
> : java.lang.ClassNotFoundException:
> org.eclipse.jetty.client.security.Authorization - I can't find a dependency
> to this eclipse plugin in nexus-indexer POM.xml
>
> Maybe you can help me on last issue, but the first one is a blocker AFAIK to
> be used in Maven Dependency Plugin.
>
> Nicolas
>
> 2010/6/18 Tamás Cservenák <[hidden email]>
>
>> Well, we had an issue:
>>
>> https://issues.sonatype.org/browse/NEXUS-644
>>
>> but it was fixed more then a year ago... maybe he suffered from that one?
>>
>> But index downloaded from central was never suffering from this issue (it
>> is
>> not a Nexus instance, and Central would not be a group anyway). Use the
>> latest release of Nexus Indexer and please test it. If you find hashes
>> usable, please close the issue.
>>
>> Note: In issue above MD5 hashes are mentioned, but MD5 is not supported
>> anymore, not on index. Only SHA1 hashes are.
>>
>> Thanks,
>> ~t~
>>
>> On Fri, Jun 18, 2010 at 10:35 PM, nicolas de loof
>> <[hidden email]>wrote:
>>
>> > I discussed with the author of alf-maven-osecm (that suggested me this
>> > feature) and he reported me he first tried to use the repo index but
>> didn't
>> > find the hash in it. I've not tried by myslef. If hash is included,
>> please
>> > close my Jira issue on Nexus and I'll double check this.
>> >
>> > 2010/6/18 Tamás Cservenák <[hidden email]>
>> >
>> > > I don't get it, what do you mean by "repository index generated by
>> Nexus
>> > > ...
>> > > doesn't include the artifact hash"?
>> > >
>> > > What makes you think hash is not on the index?
>> > >
>> > > Thanks,
>> > > ~t~
>> > >
>> > > On Fri, Jun 18, 2010 at 11:52 AM, nicolas de loof
>> > > <[hidden email]>wrote:
>> > >
>> > > > Hi folks,
>> > > >
>> > > > I'm working on MDEP-269 <http://jira.codehaus.org/browse/MDEP-269> -
>> > > > convert
>> > > > a legacy lib/*.jar to maven <dependencies>
>> > > > I've attached a patch to Jira as I'd like your opinion on the way to
>> > > > support
>> > > > this use case.
>> > > >
>> > > > My patch uses Nexus REST API to query the repository manager for
>> > > artifacts
>> > > > based on local files SHA1 hash.
>> > > > The query URL is configurable, and the Xpath expression to extract
>> data
>> > > > should also, so that a non-nexus repository manager that provides
>> > > > comparable
>> > > > feature may be user.
>> > > >
>> > > > Maybe there is more performant/portable way to do this,
>> > > > for example using repository index generated by Nexus (not sure if
>> > other
>> > > > repository manager do the same) but this one doesn't include the
>> > > artifacts
>> > > > hash yet (NEXUS-3596 <http://issues.sonatype.org/browse/NEXUS-3596>)
>> > > >
>> > > > WDYT ?
>> > > >
>> > > > Nicolas
>> > > >
>> > >
>> >
>>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [MDEP-269] please review

nicolas de loof-2
True,

I'll commit the REST-based code in maven-dependency-plugin, as it is easier
to configure for any other repository manager, and try to prepare a contrib
to nexus-maven-plugin

Cheers,
Nicolas



2010/6/21 Brian Fox <[hidden email]>

> If you're using the nexus api, then this belongs in the
> nexus-maven-plugin, not the maven-dependency-plugin.
>
> On Mon, Jun 21, 2010 at 8:39 AM, nicolas de loof
> <[hidden email]> wrote:
> > I tried to write an alternate implementation of MDEP-269 using nexus
> indexer
> > API, based on samples found on sonatype blog.
> >
> > I got some few issues :
> >
> > I had to add sonatype forge as repository to resolve dependencies, not
> > really pleasant as the maven plugin is expected to build using central
> repo.
> >
> > I had to stub the plexus Logger Component with SilentLoger - maven 2.2.1
> > doesn't provides such component
> >
> > I get an error when running the indexUpdater
> > : java.lang.ClassNotFoundException:
> > org.eclipse.jetty.client.security.Authorization - I can't find a
> dependency
> > to this eclipse plugin in nexus-indexer POM.xml
> >
> > Maybe you can help me on last issue, but the first one is a blocker AFAIK
> to
> > be used in Maven Dependency Plugin.
> >
> > Nicolas
> >
> > 2010/6/18 Tamás Cservenák <[hidden email]>
> >
> >> Well, we had an issue:
> >>
> >> https://issues.sonatype.org/browse/NEXUS-644
> >>
> >> but it was fixed more then a year ago... maybe he suffered from that
> one?
> >>
> >> But index downloaded from central was never suffering from this issue
> (it
> >> is
> >> not a Nexus instance, and Central would not be a group anyway). Use the
> >> latest release of Nexus Indexer and please test it. If you find hashes
> >> usable, please close the issue.
> >>
> >> Note: In issue above MD5 hashes are mentioned, but MD5 is not supported
> >> anymore, not on index. Only SHA1 hashes are.
> >>
> >> Thanks,
> >> ~t~
> >>
> >> On Fri, Jun 18, 2010 at 10:35 PM, nicolas de loof
> >> <[hidden email]>wrote:
> >>
> >> > I discussed with the author of alf-maven-osecm (that suggested me this
> >> > feature) and he reported me he first tried to use the repo index but
> >> didn't
> >> > find the hash in it. I've not tried by myslef. If hash is included,
> >> please
> >> > close my Jira issue on Nexus and I'll double check this.
> >> >
> >> > 2010/6/18 Tamás Cservenák <[hidden email]>
> >> >
> >> > > I don't get it, what do you mean by "repository index generated by
> >> Nexus
> >> > > ...
> >> > > doesn't include the artifact hash"?
> >> > >
> >> > > What makes you think hash is not on the index?
> >> > >
> >> > > Thanks,
> >> > > ~t~
> >> > >
> >> > > On Fri, Jun 18, 2010 at 11:52 AM, nicolas de loof
> >> > > <[hidden email]>wrote:
> >> > >
> >> > > > Hi folks,
> >> > > >
> >> > > > I'm working on MDEP-269 <http://jira.codehaus.org/browse/MDEP-269>
> -
> >> > > > convert
> >> > > > a legacy lib/*.jar to maven <dependencies>
> >> > > > I've attached a patch to Jira as I'd like your opinion on the way
> to
> >> > > > support
> >> > > > this use case.
> >> > > >
> >> > > > My patch uses Nexus REST API to query the repository manager for
> >> > > artifacts
> >> > > > based on local files SHA1 hash.
> >> > > > The query URL is configurable, and the Xpath expression to extract
> >> data
> >> > > > should also, so that a non-nexus repository manager that provides
> >> > > > comparable
> >> > > > feature may be user.
> >> > > >
> >> > > > Maybe there is more performant/portable way to do this,
> >> > > > for example using repository index generated by Nexus (not sure if
> >> > other
> >> > > > repository manager do the same) but this one doesn't include the
> >> > > artifacts
> >> > > > hash yet (NEXUS-3596 <
> http://issues.sonatype.org/browse/NEXUS-3596>)
> >> > > >
> >> > > > WDYT ?
> >> > > >
> >> > > > Nicolas
> >> > > >
> >> > >
> >> >
> >>
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [MDEP-269] please review

Jason van Zyl-2
This is out of scope for the dependency plugin. It's like the site plugin growing out of control. The dependency plugin is manipulating dependencies not finding them and doing migrations.

On Jun 21, 2010, at 10:48 AM, nicolas de loof wrote:

> True,
>
> I'll commit the REST-based code in maven-dependency-plugin, as it is easier
> to configure for any other repository manager, and try to prepare a contrib
> to nexus-maven-plugin
>
> Cheers,
> Nicolas
>
>
>
> 2010/6/21 Brian Fox <[hidden email]>
>
>> If you're using the nexus api, then this belongs in the
>> nexus-maven-plugin, not the maven-dependency-plugin.
>>
>> On Mon, Jun 21, 2010 at 8:39 AM, nicolas de loof
>> <[hidden email]> wrote:
>>> I tried to write an alternate implementation of MDEP-269 using nexus
>> indexer
>>> API, based on samples found on sonatype blog.
>>>
>>> I got some few issues :
>>>
>>> I had to add sonatype forge as repository to resolve dependencies, not
>>> really pleasant as the maven plugin is expected to build using central
>> repo.
>>>
>>> I had to stub the plexus Logger Component with SilentLoger - maven 2.2.1
>>> doesn't provides such component
>>>
>>> I get an error when running the indexUpdater
>>> : java.lang.ClassNotFoundException:
>>> org.eclipse.jetty.client.security.Authorization - I can't find a
>> dependency
>>> to this eclipse plugin in nexus-indexer POM.xml
>>>
>>> Maybe you can help me on last issue, but the first one is a blocker AFAIK
>> to
>>> be used in Maven Dependency Plugin.
>>>
>>> Nicolas
>>>
>>> 2010/6/18 Tamás Cservenák <[hidden email]>
>>>
>>>> Well, we had an issue:
>>>>
>>>> https://issues.sonatype.org/browse/NEXUS-644
>>>>
>>>> but it was fixed more then a year ago... maybe he suffered from that
>> one?
>>>>
>>>> But index downloaded from central was never suffering from this issue
>> (it
>>>> is
>>>> not a Nexus instance, and Central would not be a group anyway). Use the
>>>> latest release of Nexus Indexer and please test it. If you find hashes
>>>> usable, please close the issue.
>>>>
>>>> Note: In issue above MD5 hashes are mentioned, but MD5 is not supported
>>>> anymore, not on index. Only SHA1 hashes are.
>>>>
>>>> Thanks,
>>>> ~t~
>>>>
>>>> On Fri, Jun 18, 2010 at 10:35 PM, nicolas de loof
>>>> <[hidden email]>wrote:
>>>>
>>>>> I discussed with the author of alf-maven-osecm (that suggested me this
>>>>> feature) and he reported me he first tried to use the repo index but
>>>> didn't
>>>>> find the hash in it. I've not tried by myslef. If hash is included,
>>>> please
>>>>> close my Jira issue on Nexus and I'll double check this.
>>>>>
>>>>> 2010/6/18 Tamás Cservenák <[hidden email]>
>>>>>
>>>>>> I don't get it, what do you mean by "repository index generated by
>>>> Nexus
>>>>>> ...
>>>>>> doesn't include the artifact hash"?
>>>>>>
>>>>>> What makes you think hash is not on the index?
>>>>>>
>>>>>> Thanks,
>>>>>> ~t~
>>>>>>
>>>>>> On Fri, Jun 18, 2010 at 11:52 AM, nicolas de loof
>>>>>> <[hidden email]>wrote:
>>>>>>
>>>>>>> Hi folks,
>>>>>>>
>>>>>>> I'm working on MDEP-269 <http://jira.codehaus.org/browse/MDEP-269>
>> -
>>>>>>> convert
>>>>>>> a legacy lib/*.jar to maven <dependencies>
>>>>>>> I've attached a patch to Jira as I'd like your opinion on the way
>> to
>>>>>>> support
>>>>>>> this use case.
>>>>>>>
>>>>>>> My patch uses Nexus REST API to query the repository manager for
>>>>>> artifacts
>>>>>>> based on local files SHA1 hash.
>>>>>>> The query URL is configurable, and the Xpath expression to extract
>>>> data
>>>>>>> should also, so that a non-nexus repository manager that provides
>>>>>>> comparable
>>>>>>> feature may be user.
>>>>>>>
>>>>>>> Maybe there is more performant/portable way to do this,
>>>>>>> for example using repository index generated by Nexus (not sure if
>>>>> other
>>>>>>> repository manager do the same) but this one doesn't include the
>>>>>> artifacts
>>>>>>> hash yet (NEXUS-3596 <
>> http://issues.sonatype.org/browse/NEXUS-3596>)
>>>>>>>
>>>>>>> WDYT ?
>>>>>>>
>>>>>>> Nicolas
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>>

Thanks,

Jason

----------------------------------------------------------
Jason van Zyl
Founder,  Apache Maven
http://twitter.com/jvanzyl
---------------------------------------------------------

{script:nopre:"/Users/jvanzyl/signature/signature.sh"}