(MCHECKSTYLE-172) Checkstyle runs aggregate report on projects without modules

SebbASF created MCHECKSTYLE-172:
-----------------------------------

             Summary: Checkstyle runs aggregate report on projects without modules
                 Key: MCHECKSTYLE-172
                 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-172
             Project: Maven 2.x Checkstyle Plugin
          Issue Type: Bug
    Affects Versions: 2.8
         Environment: {{{
mvn --version
Apache Maven 3.0.4 (r1206075; 2011-11-25 09:20:29+0100)
Maven home: /usr/local/Cellar/maven/current/libexec
Java version: 1.6.0_29, vendor: Apple Inc.
Java home: /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
Default locale: de_DE, platform encoding: MacRoman
OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
}}}
            Reporter: SebbASF
            Assignee: Olivier Lamy
             Fix For: 2.9


Using a very simple single module project, the aggregated report is created by default and reports an incorrect number of violations, it just doubles the numbers. I checked out http://svn.apache.org/repos/asf/maven/plugins/tags/maven-checkstyle-plugin-2.8 and modified the integration test project {{checkstyle-report}} a little bit:
* I deleted the {{reportSets}} configuration from the {{pom.xml}}.
* I modified {{src/main/java/org/MyClass.java}} to actually have errors.

The build log looks like this:
{code}
[mirko@borg checkstyle-report]$ mvn clean site
[INFO] Scanning for projects...
[INFO]                                                                        
[INFO] ------------------------------------------------------------------------
[INFO] Building check-pass 1.0-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- maven-clean-plugin:2.4.1:clean (default-clean) @ check-pass ---
[INFO] Deleting /Users/mirko/Documents/workspace/maven-checkstyle-plugin/target/it/checkstyle-report/target
[INFO]
[INFO] --- maven-site-plugin:3.0:site (default-site) @ check-pass ---
[INFO] configuring report plugin org.apache.maven.plugins:maven-checkstyle-plugin:2.8
[INFO] Relativizing decoration links with respect to project URL: http://maven.apache.org/
[INFO] Rendering site with org.apache.maven.skins:maven-default-skin:jar:1.0 skin.
[INFO] Generating "Checkstyle" report    --- maven-checkstyle-plugin:2.8
[INFO]
[INFO] There are 2 checkstyle errors.
[WARNING] Unable to locate Source XRef to link to - DISABLED
[INFO] Generating "Checkstyle" report    --- maven-checkstyle-plugin:2.8
[INFO]
[INFO] There are 4 checkstyle errors.
[WARNING] Unable to locate Source XRef to link to - DISABLED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 4.847s
[INFO] Finished at: Tue Nov 29 21:13:40 CET 2011
[INFO] Final Memory: 12M/81M
[INFO] ------------------------------------------------------------------------
{code}

{{target/checkstyle-result.xml}} looks like this and reports the same errors twice:
{code}
<?xml version="1.0" encoding="UTF-8"?>
<checkstyle version="5.4">
<file name="/Users/mirko/Documents/workspace/maven-checkstyle-plugin/target/it/checkstyle-report/src/main/java/org/MyClass.java">
<error line="7" column="5" severity="error" message="Missing a Javadoc comment." source="com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck"/>
<error line="7" column="22" severity="error" message="Parameter args should be final." source="com.puppycrawl.tools.checkstyle.checks.FinalParametersCheck"/>
</file>
<file name="/Users/mirko/Documents/workspace/maven-checkstyle-plugin/target/it/checkstyle-report/src/main/java/org/MyClass.java">
<error line="7" column="5" severity="error" message="Missing a Javadoc comment." source="com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck"/>
<error line="7" column="22" severity="error" message="Parameter args should be final." source="com.puppycrawl.tools.checkstyle.checks.FinalParametersCheck"/>
</file>
</checkstyle>
{code}

Both the {{checkstyle}} and {{checkstyle-aggregate}} report are generated and {{checkstyle-aggregate}} reports the same errors twice. I attach the patched project which includes a check in {{verify.groovy}} to assert that only one {{file}} entry is present in the created {{target/checkstyle-result.xml}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

     [ https://jira.codehaus.org/browse/MCHECKSTYLE-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Lundberg updated MCHECKSTYLE-172:
----------------------------------------

    Fix Version/s:     (was: 2.9)
         Assignee:     (was: Olivier Lamy)
   

> Checkstyle runs aggregate report on projects without modules
> ------------------------------------------------------------
>
>                 Key: MCHECKSTYLE-172
>                 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-172
>             Project: Maven 2.x Checkstyle Plugin
>          Issue Type: Bug
>    Affects Versions: 2.8
>         Environment: {{{
> mvn --version
> Apache Maven 3.0.4 (r1206075; 2011-11-25 09:20:29+0100)
> Maven home: /usr/local/Cellar/maven/current/libexec
> Java version: 1.6.0_29, vendor: Apple Inc.
> Java home: /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
> Default locale: de_DE, platform encoding: MacRoman
> OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
> }}}
>            Reporter: SebbASF
>
> Using a very simple single module project, the aggregated report is created by default and reports an incorrect number of violations, it just doubles the numbers. I checked out http://svn.apache.org/repos/asf/maven/plugins/tags/maven-checkstyle-plugin-2.8 and modified the integration test project {{checkstyle-report}} a little bit:
> * I deleted the {{reportSets}} configuration from the {{pom.xml}}.
> * I modified {{src/main/java/org/MyClass.java}} to actually have errors.
> The build log looks like this:
> {code}
> [mirko@borg checkstyle-report]$ mvn clean site
> [INFO] Scanning for projects...
> [INFO]                                                                        
> [INFO] ------------------------------------------------------------------------
> [INFO] Building check-pass 1.0-SNAPSHOT
> [INFO] ------------------------------------------------------------------------
> [INFO]
> [INFO] --- maven-clean-plugin:2.4.1:clean (default-clean) @ check-pass ---
> [INFO] Deleting /Users/mirko/Documents/workspace/maven-checkstyle-plugin/target/it/checkstyle-report/target
> [INFO]
> [INFO] --- maven-site-plugin:3.0:site (default-site) @ check-pass ---
> [INFO] configuring report plugin org.apache.maven.plugins:maven-checkstyle-plugin:2.8
> [INFO] Relativizing decoration links with respect to project URL: http://maven.apache.org/
> [INFO] Rendering site with org.apache.maven.skins:maven-default-skin:jar:1.0 skin.
> [INFO] Generating "Checkstyle" report    --- maven-checkstyle-plugin:2.8
> [INFO]
> [INFO] There are 2 checkstyle errors.
> [WARNING] Unable to locate Source XRef to link to - DISABLED
> [INFO] Generating "Checkstyle" report    --- maven-checkstyle-plugin:2.8
> [INFO]
> [INFO] There are 4 checkstyle errors.
> [WARNING] Unable to locate Source XRef to link to - DISABLED
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 4.847s
> [INFO] Finished at: Tue Nov 29 21:13:40 CET 2011
> [INFO] Final Memory: 12M/81M
> [INFO] ------------------------------------------------------------------------
> {code}
> {{target/checkstyle-result.xml}} looks like this and reports the same errors twice:
> {code}
> <?xml version="1.0" encoding="UTF-8"?>
> <checkstyle version="5.4">
> <file name="/Users/mirko/Documents/workspace/maven-checkstyle-plugin/target/it/checkstyle-report/src/main/java/org/MyClass.java">
> <error line="7" column="5" severity="error" message="Missing a Javadoc comment." source="com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck"/>
> <error line="7" column="22" severity="error" message="Parameter args should be final." source="com.puppycrawl.tools.checkstyle.checks.FinalParametersCheck"/>
> </file>
> <file name="/Users/mirko/Documents/workspace/maven-checkstyle-plugin/target/it/checkstyle-report/src/main/java/org/MyClass.java">
> <error line="7" column="5" severity="error" message="Missing a Javadoc comment." source="com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck"/>
> <error line="7" column="22" severity="error" message="Parameter args should be final." source="com.puppycrawl.tools.checkstyle.checks.FinalParametersCheck"/>
> </file>
> </checkstyle>
> {code}
> Both the {{checkstyle}} and {{checkstyle-aggregate}} report are generated and {{checkstyle-aggregate}} reports the same errors twice. I attach the patched project which includes a check in {{verify.groovy}} to assert that only one {{file}} entry is present in the created {{target/checkstyle-result.xml}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ https://jira.codehaus.org/browse/MCHECKSTYLE-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=292089#comment-292089 ]

Dennis Lundberg commented on MCHECKSTYLE-172:
---------------------------------------------

Sebb,

This issue was cloned from MCHECKSTYLE-167, which was fixed in 2.9. That issue was that the numbers in the report was wrong. I think your issue is that the aggregate report is enabled by default, which is a change compared to previous versions. Is that the case?
               

> Checkstyle runs aggregate report on projects without modules
> ------------------------------------------------------------
>
>                 Key: MCHECKSTYLE-172
>                 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-172
>             Project: Maven 2.x Checkstyle Plugin
>          Issue Type: Bug
>    Affects Versions: 2.8
>         Environment: {{{
> mvn --version
> Apache Maven 3.0.4 (r1206075; 2011-11-25 09:20:29+0100)
> Maven home: /usr/local/Cellar/maven/current/libexec
> Java version: 1.6.0_29, vendor: Apple Inc.
> Java home: /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
> Default locale: de_DE, platform encoding: MacRoman
> OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
> }}}
>            Reporter: SebbASF
>
> Using a very simple single module project, the aggregated report is created by default and reports an incorrect number of violations, it just doubles the numbers. I checked out http://svn.apache.org/repos/asf/maven/plugins/tags/maven-checkstyle-plugin-2.8 and modified the integration test project {{checkstyle-report}} a little bit:
> * I deleted the {{reportSets}} configuration from the {{pom.xml}}.
> * I modified {{src/main/java/org/MyClass.java}} to actually have errors.
> The build log looks like this:
> {code}
> [mirko@borg checkstyle-report]$ mvn clean site
> [INFO] Scanning for projects...
> [INFO]                                                                        
> [INFO] ------------------------------------------------------------------------
> [INFO] Building check-pass 1.0-SNAPSHOT
> [INFO] ------------------------------------------------------------------------
> [INFO]
> [INFO] --- maven-clean-plugin:2.4.1:clean (default-clean) @ check-pass ---
> [INFO] Deleting /Users/mirko/Documents/workspace/maven-checkstyle-plugin/target/it/checkstyle-report/target
> [INFO]
> [INFO] --- maven-site-plugin:3.0:site (default-site) @ check-pass ---
> [INFO] configuring report plugin org.apache.maven.plugins:maven-checkstyle-plugin:2.8
> [INFO] Relativizing decoration links with respect to project URL: http://maven.apache.org/
> [INFO] Rendering site with org.apache.maven.skins:maven-default-skin:jar:1.0 skin.
> [INFO] Generating "Checkstyle" report    --- maven-checkstyle-plugin:2.8
> [INFO]
> [INFO] There are 2 checkstyle errors.
> [WARNING] Unable to locate Source XRef to link to - DISABLED
> [INFO] Generating "Checkstyle" report    --- maven-checkstyle-plugin:2.8
> [INFO]
> [INFO] There are 4 checkstyle errors.
> [WARNING] Unable to locate Source XRef to link to - DISABLED
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 4.847s
> [INFO] Finished at: Tue Nov 29 21:13:40 CET 2011
> [INFO] Final Memory: 12M/81M
> [INFO] ------------------------------------------------------------------------
> {code}
> {{target/checkstyle-result.xml}} looks like this and reports the same errors twice:
> {code}
> <?xml version="1.0" encoding="UTF-8"?>
> <checkstyle version="5.4">
> <file name="/Users/mirko/Documents/workspace/maven-checkstyle-plugin/target/it/checkstyle-report/src/main/java/org/MyClass.java">
> <error line="7" column="5" severity="error" message="Missing a Javadoc comment." source="com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck"/>
> <error line="7" column="22" severity="error" message="Parameter args should be final." source="com.puppycrawl.tools.checkstyle.checks.FinalParametersCheck"/>
> </file>
> <file name="/Users/mirko/Documents/workspace/maven-checkstyle-plugin/target/it/checkstyle-report/src/main/java/org/MyClass.java">
> <error line="7" column="5" severity="error" message="Missing a Javadoc comment." source="com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck"/>
> <error line="7" column="22" severity="error" message="Parameter args should be final." source="com.puppycrawl.tools.checkstyle.checks.FinalParametersCheck"/>
> </file>
> </checkstyle>
> {code}
> Both the {{checkstyle}} and {{checkstyle-aggregate}} report are generated and {{checkstyle-aggregate}} reports the same errors twice. I attach the patched project which includes a check in {{verify.groovy}} to assert that only one {{file}} entry is present in the created {{target/checkstyle-result.xml}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ https://jira.codehaus.org/browse/MCHECKSTYLE-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=292280#comment-292280 ]

SebbASF commented on MCHECKSTYLE-172:
-------------------------------------

Yes.

The original report that triggered the JIRA is here:
http://www.mailinglistarchive.com/html/users@.../2011-12/thrd4.html#00134

AIUI, the OP was complaining about two issues:
- 2.8 now generates an additional aggregate report
- the aggregate report has incorrect counts

2.9 fixes the incorrect count problem, but not the additional aggregate report.

Unfortunately, the JIRA settings at Codehaus are such that I could not re-open the original JIRA so I had to clone it.
[I intended to add some further explanation, but obviously forgot, sorry.]

It does not seem right that since 2.8 every Maven project now gets an additional aggregate report, regardless of whether the project actually has any modules to aggregate.
               

> Checkstyle runs aggregate report on projects without modules
> ------------------------------------------------------------
>
>                 Key: MCHECKSTYLE-172
>                 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-172
>             Project: Maven 2.x Checkstyle Plugin
>          Issue Type: Bug
>    Affects Versions: 2.8
>         Environment: {{{
> mvn --version
> Apache Maven 3.0.4 (r1206075; 2011-11-25 09:20:29+0100)
> Maven home: /usr/local/Cellar/maven/current/libexec
> Java version: 1.6.0_29, vendor: Apple Inc.
> Java home: /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
> Default locale: de_DE, platform encoding: MacRoman
> OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
> }}}
>            Reporter: SebbASF
>
> Using a very simple single module project, the aggregated report is created by default and reports an incorrect number of violations, it just doubles the numbers. I checked out http://svn.apache.org/repos/asf/maven/plugins/tags/maven-checkstyle-plugin-2.8 and modified the integration test project {{checkstyle-report}} a little bit:
> * I deleted the {{reportSets}} configuration from the {{pom.xml}}.
> * I modified {{src/main/java/org/MyClass.java}} to actually have errors.
> The build log looks like this:
> {code}
> [mirko@borg checkstyle-report]$ mvn clean site
> [INFO] Scanning for projects...
> [INFO]                                                                        
> [INFO] ------------------------------------------------------------------------
> [INFO] Building check-pass 1.0-SNAPSHOT
> [INFO] ------------------------------------------------------------------------
> [INFO]
> [INFO] --- maven-clean-plugin:2.4.1:clean (default-clean) @ check-pass ---
> [INFO] Deleting /Users/mirko/Documents/workspace/maven-checkstyle-plugin/target/it/checkstyle-report/target
> [INFO]
> [INFO] --- maven-site-plugin:3.0:site (default-site) @ check-pass ---
> [INFO] configuring report plugin org.apache.maven.plugins:maven-checkstyle-plugin:2.8
> [INFO] Relativizing decoration links with respect to project URL: http://maven.apache.org/
> [INFO] Rendering site with org.apache.maven.skins:maven-default-skin:jar:1.0 skin.
> [INFO] Generating "Checkstyle" report    --- maven-checkstyle-plugin:2.8
> [INFO]
> [INFO] There are 2 checkstyle errors.
> [WARNING] Unable to locate Source XRef to link to - DISABLED
> [INFO] Generating "Checkstyle" report    --- maven-checkstyle-plugin:2.8
> [INFO]
> [INFO] There are 4 checkstyle errors.
> [WARNING] Unable to locate Source XRef to link to - DISABLED
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 4.847s
> [INFO] Finished at: Tue Nov 29 21:13:40 CET 2011
> [INFO] Final Memory: 12M/81M
> [INFO] ------------------------------------------------------------------------
> {code}
> {{target/checkstyle-result.xml}} looks like this and reports the same errors twice:
> {code}
> <?xml version="1.0" encoding="UTF-8"?>
> <checkstyle version="5.4">
> <file name="/Users/mirko/Documents/workspace/maven-checkstyle-plugin/target/it/checkstyle-report/src/main/java/org/MyClass.java">
> <error line="7" column="5" severity="error" message="Missing a Javadoc comment." source="com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck"/>
> <error line="7" column="22" severity="error" message="Parameter args should be final." source="com.puppycrawl.tools.checkstyle.checks.FinalParametersCheck"/>
> </file>
> <file name="/Users/mirko/Documents/workspace/maven-checkstyle-plugin/target/it/checkstyle-report/src/main/java/org/MyClass.java">
> <error line="7" column="5" severity="error" message="Missing a Javadoc comment." source="com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck"/>
> <error line="7" column="22" severity="error" message="Parameter args should be final." source="com.puppycrawl.tools.checkstyle.checks.FinalParametersCheck"/>
> </file>
> </checkstyle>
> {code}
> Both the {{checkstyle}} and {{checkstyle-aggregate}} report are generated and {{checkstyle-aggregate}} reports the same errors twice. I attach the patched project which includes a check in {{verify.groovy}} to assert that only one {{file}} entry is present in the created {{target/checkstyle-result.xml}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

     [ https://jira.codehaus.org/browse/MCHECKSTYLE-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Lundberg updated MCHECKSTYLE-172:
----------------------------------------

          Description:
Using a very simple single module project, the aggregated report is created by default.

Both the {{checkstyle}} and {{checkstyle-aggregate}} report are generated.

  was:
Using a very simple single module project, the aggregated report is created by default and reports an incorrect number of violations, it just doubles the numbers. I checked out http://svn.apache.org/repos/asf/maven/plugins/tags/maven-checkstyle-plugin-2.8 and modified the integration test project {{checkstyle-report}} a little bit:
* I deleted the {{reportSets}} configuration from the {{pom.xml}}.
* I modified {{src/main/java/org/MyClass.java}} to actually have errors.

The build log looks like this:
{code}
[mirko@borg checkstyle-report]$ mvn clean site
[INFO] Scanning for projects...
[INFO]                                                                        
[INFO] ------------------------------------------------------------------------
[INFO] Building check-pass 1.0-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- maven-clean-plugin:2.4.1:clean (default-clean) @ check-pass ---
[INFO] Deleting /Users/mirko/Documents/workspace/maven-checkstyle-plugin/target/it/checkstyle-report/target
[INFO]
[INFO] --- maven-site-plugin:3.0:site (default-site) @ check-pass ---
[INFO] configuring report plugin org.apache.maven.plugins:maven-checkstyle-plugin:2.8
[INFO] Relativizing decoration links with respect to project URL: http://maven.apache.org/
[INFO] Rendering site with org.apache.maven.skins:maven-default-skin:jar:1.0 skin.
[INFO] Generating "Checkstyle" report    --- maven-checkstyle-plugin:2.8
[INFO]
[INFO] There are 2 checkstyle errors.
[WARNING] Unable to locate Source XRef to link to - DISABLED
[INFO] Generating "Checkstyle" report    --- maven-checkstyle-plugin:2.8
[INFO]
[INFO] There are 4 checkstyle errors.
[WARNING] Unable to locate Source XRef to link to - DISABLED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 4.847s
[INFO] Finished at: Tue Nov 29 21:13:40 CET 2011
[INFO] Final Memory: 12M/81M
[INFO] ------------------------------------------------------------------------
{code}

{{target/checkstyle-result.xml}} looks like this and reports the same errors twice:
{code}
<?xml version="1.0" encoding="UTF-8"?>
<checkstyle version="5.4">
<file name="/Users/mirko/Documents/workspace/maven-checkstyle-plugin/target/it/checkstyle-report/src/main/java/org/MyClass.java">
<error line="7" column="5" severity="error" message="Missing a Javadoc comment." source="com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck"/>
<error line="7" column="22" severity="error" message="Parameter args should be final." source="com.puppycrawl.tools.checkstyle.checks.FinalParametersCheck"/>
</file>
<file name="/Users/mirko/Documents/workspace/maven-checkstyle-plugin/target/it/checkstyle-report/src/main/java/org/MyClass.java">
<error line="7" column="5" severity="error" message="Missing a Javadoc comment." source="com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck"/>
<error line="7" column="22" severity="error" message="Parameter args should be final." source="com.puppycrawl.tools.checkstyle.checks.FinalParametersCheck"/>
</file>
</checkstyle>
{code}

Both the {{checkstyle}} and {{checkstyle-aggregate}} report are generated and {{checkstyle-aggregate}} reports the same errors twice. I attach the patched project which includes a check in {{verify.groovy}} to assert that only one {{file}} entry is present in the created {{target/checkstyle-result.xml}}.

    Affects Version/s: 2.9
              Summary: Checkstyle Plugin 2.8+ generates an additional aggregate report  (was: Checkstyle runs aggregate report on projects without modules)
   

> Checkstyle Plugin 2.8+ generates an additional aggregate report
> ---------------------------------------------------------------
>
>                 Key: MCHECKSTYLE-172
>                 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-172
>             Project: Maven 2.x Checkstyle Plugin
>          Issue Type: Bug
>    Affects Versions: 2.8, 2.9
>         Environment: {{{
> mvn --version
> Apache Maven 3.0.4 (r1206075; 2011-11-25 09:20:29+0100)
> Maven home: /usr/local/Cellar/maven/current/libexec
> Java version: 1.6.0_29, vendor: Apple Inc.
> Java home: /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
> Default locale: de_DE, platform encoding: MacRoman
> OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
> }}}
>            Reporter: SebbASF
>
> Using a very simple single module project, the aggregated report is created by default.
> Both the {{checkstyle}} and {{checkstyle-aggregate}} report are generated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

     [ https://jira.codehaus.org/browse/MCHECKSTYLE-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Lundberg updated MCHECKSTYLE-172:
----------------------------------------

    Testcase included:   (was: yes)
   

> Checkstyle Plugin 2.8+ generates an additional aggregate report
> ---------------------------------------------------------------
>
>                 Key: MCHECKSTYLE-172
>                 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-172
>             Project: Maven 2.x Checkstyle Plugin
>          Issue Type: Bug
>    Affects Versions: 2.8, 2.9
>         Environment: {{{
> mvn --version
> Apache Maven 3.0.4 (r1206075; 2011-11-25 09:20:29+0100)
> Maven home: /usr/local/Cellar/maven/current/libexec
> Java version: 1.6.0_29, vendor: Apple Inc.
> Java home: /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
> Default locale: de_DE, platform encoding: MacRoman
> OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
> }}}
>            Reporter: SebbASF
>
> Using a very simple single module project, the aggregated report is created by default.
> Both the {{checkstyle}} and {{checkstyle-aggregate}} report are generated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ https://jira.codehaus.org/browse/MCHECKSTYLE-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=296447#comment-296447 ]

SebbASF commented on MCHECKSTYLE-172:
-------------------------------------

Work-round (see [1]):

{code}
  <reporting>
    <plugins>
.....
          <plugin>
            <groupId>org.apache.maven.plugins</groupId>
            <artifactId>maven-checkstyle-plugin</artifactId>
            <version>2.8</version>
            <inherited>false</inherited>
            <reportSets>
              <reportSet>
                <reports>
                  <report>checkstyle-aggregate</report>
                </reports>
              </reportSet>
            </reportSets>
          </plugin>
      ...
    </plugins>
  </reporting>
{code}

[1] http://www.mailinglistarchive.com/html/users@.../2011-12/msg00134.html
               

> Checkstyle Plugin 2.8+ generates an additional aggregate report
> ---------------------------------------------------------------
>
>                 Key: MCHECKSTYLE-172
>                 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-172
>             Project: Maven 2.x Checkstyle Plugin
>          Issue Type: Bug
>    Affects Versions: 2.8, 2.9
>         Environment: {{{
> mvn --version
> Apache Maven 3.0.4 (r1206075; 2011-11-25 09:20:29+0100)
> Maven home: /usr/local/Cellar/maven/current/libexec
> Java version: 1.6.0_29, vendor: Apple Inc.
> Java home: /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
> Default locale: de_DE, platform encoding: MacRoman
> OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
> }}}
>            Reporter: SebbASF
>
> Using a very simple single module project, the aggregated report is created by default.
> Both the {{checkstyle}} and {{checkstyle-aggregate}} report are generated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ https://jira.codehaus.org/browse/MCHECKSTYLE-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=297601#comment-297601 ]

Andrew Hunt commented on MCHECKSTYLE-172:
-----------------------------------------

Not sure that the reported fix to the count problem MCHECKSTYLE-167 has been fixed in the checkstyle-aggregate report. If you have a look at http://maven.apache.org/plugins/maven-checkstyle-plugin/project-reports.html, you will see the report repetition AND that the first report has double the issues of the second report.  In the checkstyle-aggregate report, each error is reported twice.
               

> Checkstyle Plugin 2.8+ generates an additional aggregate report
> ---------------------------------------------------------------
>
>                 Key: MCHECKSTYLE-172
>                 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-172
>             Project: Maven 2.x Checkstyle Plugin
>          Issue Type: Bug
>    Affects Versions: 2.8, 2.9
>         Environment: {{{
> mvn --version
> Apache Maven 3.0.4 (r1206075; 2011-11-25 09:20:29+0100)
> Maven home: /usr/local/Cellar/maven/current/libexec
> Java version: 1.6.0_29, vendor: Apple Inc.
> Java home: /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
> Default locale: de_DE, platform encoding: MacRoman
> OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
> }}}
>            Reporter: SebbASF
>
> Using a very simple single module project, the aggregated report is created by default.
> Both the {{checkstyle}} and {{checkstyle-aggregate}} report are generated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ https://jira.codehaus.org/browse/MCHECKSTYLE-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=297601#comment-297601 ]

Andrew Hunt edited comment on MCHECKSTYLE-172 at 5/1/12 3:11 AM:
-----------------------------------------------------------------

Not sure that the reported fix to the count problem MCHECKSTYLE-167 has been fixed in the checkstyle-aggregate report. If you have a look at http://maven.apache.org/plugins/maven-checkstyle-plugin/project-reports.html, you will see the report repetition AND that the first report has double the issues of the second report.  In the checkstyle-aggregate report, each error is reported twice.

The workaround works great!
               
      was (Author: andrew.hunt):
    Not sure that the reported fix to the count problem MCHECKSTYLE-167 has been fixed in the checkstyle-aggregate report. If you have a look at http://maven.apache.org/plugins/maven-checkstyle-plugin/project-reports.html, you will see the report repetition AND that the first report has double the issues of the second report.  In the checkstyle-aggregate report, each error is reported twice.
                 

> Checkstyle Plugin 2.8+ generates an additional aggregate report
> ---------------------------------------------------------------
>
>                 Key: MCHECKSTYLE-172
>                 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-172
>             Project: Maven 2.x Checkstyle Plugin
>          Issue Type: Bug
>    Affects Versions: 2.8, 2.9
>         Environment: {{{
> mvn --version
> Apache Maven 3.0.4 (r1206075; 2011-11-25 09:20:29+0100)
> Maven home: /usr/local/Cellar/maven/current/libexec
> Java version: 1.6.0_29, vendor: Apple Inc.
> Java home: /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
> Default locale: de_DE, platform encoding: MacRoman
> OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
> }}}
>            Reporter: SebbASF
>
> Using a very simple single module project, the aggregated report is created by default.
> Both the {{checkstyle}} and {{checkstyle-aggregate}} report are generated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ https://jira.codehaus.org/browse/MCHECKSTYLE-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=297601#comment-297601 ]

Andrew Hunt edited comment on MCHECKSTYLE-172 at 5/1/12 3:14 AM:
-----------------------------------------------------------------

Not sure that the reported fix to the count problem MCHECKSTYLE-167 has been fixed in the checkstyle-aggregate report. If you have a look at http://maven.apache.org/plugins/maven-checkstyle-plugin/project-reports.html, you will see the report repetition AND that the first report has double the issues of the second report.  In the checkstyle-aggregate report, each error is reported twice.

The workaround works great, though with this minor adjustment...
{panel}
  <reporting>
      ...
        <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-checkstyle-plugin</artifactId>
           <version>2.9</version>
           <inherited>false</inherited>
           <reportSets>
             <reportSet>
                <reports>
                  <report>checkstyle</report>
                </reports>
             </reportSet>
           </reportSets>
           <configuration>
             <configLocation>group_default_checkstyles.xml</configLocation>
           </configuration>
         </plugin>
      ...
{panel}
               
      was (Author: andrew.hunt):
    Not sure that the reported fix to the count problem MCHECKSTYLE-167 has been fixed in the checkstyle-aggregate report. If you have a look at http://maven.apache.org/plugins/maven-checkstyle-plugin/project-reports.html, you will see the report repetition AND that the first report has double the issues of the second report.  In the checkstyle-aggregate report, each error is reported twice.

The workaround works great!
                 

> Checkstyle Plugin 2.8+ generates an additional aggregate report
> ---------------------------------------------------------------
>
>                 Key: MCHECKSTYLE-172
>                 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-172
>             Project: Maven 2.x Checkstyle Plugin
>          Issue Type: Bug
>    Affects Versions: 2.8, 2.9
>         Environment: {{{
> mvn --version
> Apache Maven 3.0.4 (r1206075; 2011-11-25 09:20:29+0100)
> Maven home: /usr/local/Cellar/maven/current/libexec
> Java version: 1.6.0_29, vendor: Apple Inc.
> Java home: /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
> Default locale: de_DE, platform encoding: MacRoman
> OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
> }}}
>            Reporter: SebbASF
>
> Using a very simple single module project, the aggregated report is created by default.
> Both the {{checkstyle}} and {{checkstyle-aggregate}} report are generated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ https://jira.codehaus.org/browse/MCHECKSTYLE-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=297601#comment-297601 ]

Andrew Hunt edited comment on MCHECKSTYLE-172 at 5/1/12 3:16 AM:
-----------------------------------------------------------------

Not sure that the reported fix to the count problem MCHECKSTYLE-167 has been fixed in the checkstyle-aggregate report. If you have a look at http://maven.apache.org/plugins/maven-checkstyle-plugin/project-reports.html, you will see the report repetition AND that the first report has double the issues of the second report.  In the checkstyle-aggregate report, each error is reported twice.

The workaround works great, though with this minor adjustment...
{code}
  <reporting>
      ...
        <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-checkstyle-plugin</artifactId>
           <version>2.9</version>
           <inherited>false</inherited>
           <reportSets>
             <reportSet>
                <reports>
                  <report>checkstyle</report>
                </reports>
             </reportSet>
           </reportSets>
           <configuration>
             <configLocation>group_default_checkstyles.xml</configLocation>
           </configuration>
         </plugin>
      ...
{code}
               
      was (Author: andrew.hunt):
    Not sure that the reported fix to the count problem MCHECKSTYLE-167 has been fixed in the checkstyle-aggregate report. If you have a look at http://maven.apache.org/plugins/maven-checkstyle-plugin/project-reports.html, you will see the report repetition AND that the first report has double the issues of the second report.  In the checkstyle-aggregate report, each error is reported twice.

The workaround works great, though with this minor adjustment...
{panel}
  <reporting>
      ...
        <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-checkstyle-plugin</artifactId>
           <version>2.9</version>
           <inherited>false</inherited>
           <reportSets>
             <reportSet>
                <reports>
                  <report>checkstyle</report>
                </reports>
             </reportSet>
           </reportSets>
           <configuration>
             <configLocation>group_default_checkstyles.xml</configLocation>
           </configuration>
         </plugin>
      ...
{panel}
                 

> Checkstyle Plugin 2.8+ generates an additional aggregate report
> ---------------------------------------------------------------
>
>                 Key: MCHECKSTYLE-172
>                 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-172
>             Project: Maven 2.x Checkstyle Plugin
>          Issue Type: Bug
>    Affects Versions: 2.8, 2.9
>         Environment: {{{
> mvn --version
> Apache Maven 3.0.4 (r1206075; 2011-11-25 09:20:29+0100)
> Maven home: /usr/local/Cellar/maven/current/libexec
> Java version: 1.6.0_29, vendor: Apple Inc.
> Java home: /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
> Default locale: de_DE, platform encoding: MacRoman
> OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
> }}}
>            Reporter: SebbASF
>
> Using a very simple single module project, the aggregated report is created by default.
> Both the {{checkstyle}} and {{checkstyle-aggregate}} report are generated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ https://jira.codehaus.org/browse/MCHECKSTYLE-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=297601#comment-297601 ]

Andrew Hunt edited comment on MCHECKSTYLE-172 at 5/1/12 3:18 AM:
-----------------------------------------------------------------

Not sure that the reported fix to the count problem MCHECKSTYLE-167 has been fixed in the checkstyle-aggregate report. If you have a look at http://maven.apache.org/plugins/maven-checkstyle-plugin/project-reports.html, you will see the report repetition AND that the first report has double the issues of the second report.  In the checkstyle-aggregate report, each error is reported twice.

The workaround works great, though with this minor adjustment (full definition)...
{code}
  <reporting>
      ...
        <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-checkstyle-plugin</artifactId>
           <version>2.9</version>
           <inherited>false</inherited>
           <reportSets>
             <reportSet>
                <reports>
                  <report>checkstyle</report>        <!-- This is changed from above -->
                </reports>
             </reportSet>
           </reportSets>
           <configuration>
             <configLocation>group_default_checkstyles.xml</configLocation>
           </configuration>
         </plugin>
      ...
{code}
               
      was (Author: andrew.hunt):
    Not sure that the reported fix to the count problem MCHECKSTYLE-167 has been fixed in the checkstyle-aggregate report. If you have a look at http://maven.apache.org/plugins/maven-checkstyle-plugin/project-reports.html, you will see the report repetition AND that the first report has double the issues of the second report.  In the checkstyle-aggregate report, each error is reported twice.

The workaround works great, though with this minor adjustment...
{code}
  <reporting>
      ...
        <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-checkstyle-plugin</artifactId>
           <version>2.9</version>
           <inherited>false</inherited>
           <reportSets>
             <reportSet>
                <reports>
                  <report>checkstyle</report>
                </reports>
             </reportSet>
           </reportSets>
           <configuration>
             <configLocation>group_default_checkstyles.xml</configLocation>
           </configuration>
         </plugin>
      ...
{code}
                 

> Checkstyle Plugin 2.8+ generates an additional aggregate report
> ---------------------------------------------------------------
>
>                 Key: MCHECKSTYLE-172
>                 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-172
>             Project: Maven 2.x Checkstyle Plugin
>          Issue Type: Bug
>    Affects Versions: 2.8, 2.9
>         Environment: {{{
> mvn --version
> Apache Maven 3.0.4 (r1206075; 2011-11-25 09:20:29+0100)
> Maven home: /usr/local/Cellar/maven/current/libexec
> Java version: 1.6.0_29, vendor: Apple Inc.
> Java home: /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
> Default locale: de_DE, platform encoding: MacRoman
> OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
> }}}
>            Reporter: SebbASF
>
> Using a very simple single module project, the aggregated report is created by default.
> Both the {{checkstyle}} and {{checkstyle-aggregate}} report are generated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ https://jira.codehaus.org/browse/MCHECKSTYLE-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=297601#comment-297601 ]

Andrew Hunt edited comment on MCHECKSTYLE-172 at 5/1/12 3:19 AM:
-----------------------------------------------------------------

Not sure that the reported fix to the count problem MCHECKSTYLE-167 has been fixed in the checkstyle-aggregate report. If you have a look at http://maven.apache.org/plugins/maven-checkstyle-plugin/project-reports.html, you will see the report repetition AND that the first report has double the issues of the second report.  In the checkstyle-aggregate report, each error is reported twice.

The workaround works great (in terms of providing one report and removing the repeats), though I had to make a minor adjustment (my full config shown)...
{code}
  <reporting>
      ...
        <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-checkstyle-plugin</artifactId>
           <version>2.9</version>
           <inherited>false</inherited>
           <reportSets>
             <reportSet>
                <reports>
                  <report>checkstyle</report>        <!-- This is changed from above -->
                </reports>
             </reportSet>
           </reportSets>
           <configuration>
             <configLocation>group_default_checkstyles.xml</configLocation>
           </configuration>
         </plugin>
      ...
{code}
               
      was (Author: andrew.hunt):
    Not sure that the reported fix to the count problem MCHECKSTYLE-167 has been fixed in the checkstyle-aggregate report. If you have a look at http://maven.apache.org/plugins/maven-checkstyle-plugin/project-reports.html, you will see the report repetition AND that the first report has double the issues of the second report.  In the checkstyle-aggregate report, each error is reported twice.

The workaround works great, though with this minor adjustment (full definition)...
{code}
  <reporting>
      ...
        <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-checkstyle-plugin</artifactId>
           <version>2.9</version>
           <inherited>false</inherited>
           <reportSets>
             <reportSet>
                <reports>
                  <report>checkstyle</report>        <!-- This is changed from above -->
                </reports>
             </reportSet>
           </reportSets>
           <configuration>
             <configLocation>group_default_checkstyles.xml</configLocation>
           </configuration>
         </plugin>
      ...
{code}
                 

> Checkstyle Plugin 2.8+ generates an additional aggregate report
> ---------------------------------------------------------------
>
>                 Key: MCHECKSTYLE-172
>                 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-172
>             Project: Maven 2.x Checkstyle Plugin
>          Issue Type: Bug
>    Affects Versions: 2.8, 2.9
>         Environment: {{{
> mvn --version
> Apache Maven 3.0.4 (r1206075; 2011-11-25 09:20:29+0100)
> Maven home: /usr/local/Cellar/maven/current/libexec
> Java version: 1.6.0_29, vendor: Apple Inc.
> Java home: /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
> Default locale: de_DE, platform encoding: MacRoman
> OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
> }}}
>            Reporter: SebbASF
>
> Using a very simple single module project, the aggregated report is created by default.
> Both the {{checkstyle}} and {{checkstyle-aggregate}} report are generated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ https://jira.codehaus.org/browse/MCHECKSTYLE-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=296447#comment-296447 ]

SebbASF edited comment on MCHECKSTYLE-172 at 5/1/12 4:52 AM:
-------------------------------------------------------------

Work-round (see [1]):

{code}
  <reporting>
    <plugins>
.....
          <plugin>
            <groupId>org.apache.maven.plugins</groupId>
            <artifactId>maven-checkstyle-plugin</artifactId>
            <version>2.8</version>
            <inherited>false</inherited>
            <reportSets>
              <reportSet>
                <reports>
                  <report>checkstyle</report> <!-- editted 2012-05-01; was previously "checkstyle-aggregate" which was wrong -->
                </reports>
              </reportSet>
            </reportSets>
          </plugin>
      ...
    </plugins>
  </reporting>
{code}

[1] http://www.mailinglistarchive.com/html/users@.../2011-12/msg00134.html
               
      was (Author: sebbasf):
    Work-round (see [1]):

{code}
  <reporting>
    <plugins>
.....
          <plugin>
            <groupId>org.apache.maven.plugins</groupId>
            <artifactId>maven-checkstyle-plugin</artifactId>
            <version>2.8</version>
            <inherited>false</inherited>
            <reportSets>
              <reportSet>
                <reports>
                  <report>checkstyle-aggregate</report>
                </reports>
              </reportSet>
            </reportSets>
          </plugin>
      ...
    </plugins>
  </reporting>
{code}

[1] http://www.mailinglistarchive.com/html/users@.../2011-12/msg00134.html
                 

> Checkstyle Plugin 2.8+ generates an additional aggregate report
> ---------------------------------------------------------------
>
>                 Key: MCHECKSTYLE-172
>                 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-172
>             Project: Maven 2.x Checkstyle Plugin
>          Issue Type: Bug
>    Affects Versions: 2.8, 2.9
>         Environment: {{{
> mvn --version
> Apache Maven 3.0.4 (r1206075; 2011-11-25 09:20:29+0100)
> Maven home: /usr/local/Cellar/maven/current/libexec
> Java version: 1.6.0_29, vendor: Apple Inc.
> Java home: /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
> Default locale: de_DE, platform encoding: MacRoman
> OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
> }}}
>            Reporter: SebbASF
>
> Using a very simple single module project, the aggregated report is created by default.
> Both the {{checkstyle}} and {{checkstyle-aggregate}} report are generated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ https://jira.codehaus.org/browse/MCHECKSTYLE-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=297608#comment-297608 ]

SebbASF commented on MCHECKSTYLE-172:
-------------------------------------

@Andrew: thanks, fixed incorrect copy-paste in my earlier comment.
               

> Checkstyle Plugin 2.8+ generates an additional aggregate report
> ---------------------------------------------------------------
>
>                 Key: MCHECKSTYLE-172
>                 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-172
>             Project: Maven 2.x Checkstyle Plugin
>          Issue Type: Bug
>    Affects Versions: 2.8, 2.9
>         Environment: {{{
> mvn --version
> Apache Maven 3.0.4 (r1206075; 2011-11-25 09:20:29+0100)
> Maven home: /usr/local/Cellar/maven/current/libexec
> Java version: 1.6.0_29, vendor: Apple Inc.
> Java home: /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
> Default locale: de_DE, platform encoding: MacRoman
> OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
> }}}
>            Reporter: SebbASF
>
> Using a very simple single module project, the aggregated report is created by default.
> Both the {{checkstyle}} and {{checkstyle-aggregate}} report are generated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

     [ https://jira.codehaus.org/browse/MCHECKSTYLE-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Lundberg updated MCHECKSTYLE-172:
----------------------------------------

      Environment:
mvn --version
Apache Maven 3.0.4 (r1206075; 2011-11-25 09:20:29+0100)
Maven home: /usr/local/Cellar/maven/current/libexec
Java version: 1.6.0_29, vendor: Apple Inc.
Java home: /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
Default locale: de_DE, platform encoding: MacRoman
OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"

  was:
{{{
mvn --version
Apache Maven 3.0.4 (r1206075; 2011-11-25 09:20:29+0100)
Maven home: /usr/local/Cellar/maven/current/libexec
Java version: 1.6.0_29, vendor: Apple Inc.
Java home: /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
Default locale: de_DE, platform encoding: MacRoman
OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
}}}

    Fix Version/s: 2.10
         Assignee: Dennis Lundberg
   

> Checkstyle Plugin 2.8+ generates an additional aggregate report
> ---------------------------------------------------------------
>
>                 Key: MCHECKSTYLE-172
>                 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-172
>             Project: Maven 2.x Checkstyle Plugin
>          Issue Type: Bug
>    Affects Versions: 2.8, 2.9
>         Environment: mvn --version
> Apache Maven 3.0.4 (r1206075; 2011-11-25 09:20:29+0100)
> Maven home: /usr/local/Cellar/maven/current/libexec
> Java version: 1.6.0_29, vendor: Apple Inc.
> Java home: /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
> Default locale: de_DE, platform encoding: MacRoman
> OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
>            Reporter: SebbASF
>            Assignee: Dennis Lundberg
>             Fix For: 2.10
>
>
> Using a very simple single module project, the aggregated report is created by default.
> Both the {{checkstyle}} and {{checkstyle-aggregate}} report are generated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ https://jira.codehaus.org/browse/MCHECKSTYLE-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=311938#comment-311938 ]

Justin Ye commented on MCHECKSTYLE-172:
---------------------------------------

Is there any update on this issue? I know we have workaround for this.
But it seems this issue is blocking the release of new version 2.10
               

> Checkstyle Plugin 2.8+ generates an additional aggregate report
> ---------------------------------------------------------------
>
>                 Key: MCHECKSTYLE-172
>                 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-172
>             Project: Maven 2.x Checkstyle Plugin
>          Issue Type: Bug
>    Affects Versions: 2.8, 2.9
>         Environment: mvn --version
> Apache Maven 3.0.4 (r1206075; 2011-11-25 09:20:29+0100)
> Maven home: /usr/local/Cellar/maven/current/libexec
> Java version: 1.6.0_29, vendor: Apple Inc.
> Java home: /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
> Default locale: de_DE, platform encoding: MacRoman
> OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
>            Reporter: SebbASF
>            Assignee: Dennis Lundberg
>             Fix For: 2.10
>
>
> Using a very simple single module project, the aggregated report is created by default.
> Both the {{checkstyle}} and {{checkstyle-aggregate}} report are generated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ https://jira.codehaus.org/browse/MCHECKSTYLE-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=312076#comment-312076 ]

Dennis Lundberg commented on MCHECKSTYLE-172:
---------------------------------------------

Sorry, haven't had time to finish this yet.
There is no rush to get 2.10 out the door.
               

> Checkstyle Plugin 2.8+ generates an additional aggregate report
> ---------------------------------------------------------------
>
>                 Key: MCHECKSTYLE-172
>                 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-172
>             Project: Maven 2.x Checkstyle Plugin
>          Issue Type: Bug
>    Affects Versions: 2.8, 2.9
>         Environment: mvn --version
> Apache Maven 3.0.4 (r1206075; 2011-11-25 09:20:29+0100)
> Maven home: /usr/local/Cellar/maven/current/libexec
> Java version: 1.6.0_29, vendor: Apple Inc.
> Java home: /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
> Default locale: de_DE, platform encoding: MacRoman
> OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
>            Reporter: SebbASF
>            Assignee: Dennis Lundberg
>             Fix For: 2.10
>
>
> Using a very simple single module project, the aggregated report is created by default.
> Both the {{checkstyle}} and {{checkstyle-aggregate}} report are generated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

    [ https://jira.codehaus.org/browse/MCHECKSTYLE-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=317914#comment-317914 ]

Justin Ye commented on MCHECKSTYLE-172:
---------------------------------------

Our company wants to upgrade to Checkstyle5.6 for a new feature(accessing suppression file on network).
Since we are using maven in Jenkins for continious integration, we are looking forward to a coresponding upgrade in maven-checkstyle-plugin so that we can apply the upgrade to the whole company.
This issue is not critical from my perspective since we have a workaround.
So is it possible we can move this issue's fix to next release so that 2.10 would not be blocked.
Many thanks!

               

> Checkstyle Plugin 2.8+ generates an additional aggregate report
> ---------------------------------------------------------------
>
>                 Key: MCHECKSTYLE-172
>                 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-172
>             Project: Maven 2.x Checkstyle Plugin
>          Issue Type: Bug
>    Affects Versions: 2.8, 2.9
>         Environment: mvn --version
> Apache Maven 3.0.4 (r1206075; 2011-11-25 09:20:29+0100)
> Maven home: /usr/local/Cellar/maven/current/libexec
> Java version: 1.6.0_29, vendor: Apple Inc.
> Java home: /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
> Default locale: de_DE, platform encoding: MacRoman
> OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
>            Reporter: SebbASF
>            Assignee: Dennis Lundberg
>             Fix For: 2.10
>
>
> Using a very simple single module project, the aggregated report is created by default.
> Both the {{checkstyle}} and {{checkstyle-aggregate}} report are generated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

     [ https://jira.codehaus.org/browse/MCHECKSTYLE-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Lundberg closed MCHECKSTYLE-172.
---------------------------------------

    Resolution: Fixed

Fixed in [r1438951|http://svn.apache.org/viewvc?view=revision&revision=1438951].
I've taken care of the really simple single module case in this fix. Please give it a test.

If you have more advanced projects that generate an aggregate report when they shouldn't - please open a separate issue for that.
               

> Checkstyle Plugin 2.8+ generates an additional aggregate report
> ---------------------------------------------------------------
>
>                 Key: MCHECKSTYLE-172
>                 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-172
>             Project: Maven 2.x Checkstyle Plugin
>          Issue Type: Bug
>    Affects Versions: 2.8, 2.9
>         Environment: mvn --version
> Apache Maven 3.0.4 (r1206075; 2011-11-25 09:20:29+0100)
> Maven home: /usr/local/Cellar/maven/current/libexec
> Java version: 1.6.0_29, vendor: Apple Inc.
> Java home: /Library/Java/JavaVirtualMachines/1.6.0_29-b11-402.jdk/Contents/Home
> Default locale: de_DE, platform encoding: MacRoman
> OS name: "mac os x", version: "10.7.2", arch: "x86_64", family: "mac"
>            Reporter: SebbASF
>            Assignee: Dennis Lundberg
>             Fix For: 2.10
>
>
> Using a very simple single module project, the aggregated report is created by default.
> Both the {{checkstyle}} and {{checkstyle-aggregate}} report are generated.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira