[Issue Comment Deleted] (MNG-6350) Maven 3.5.2 Command Line mvn.cmd fails on path names containing round bracket "()" chars

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[Issue Comment Deleted] (MNG-6350) Maven 3.5.2 Command Line mvn.cmd fails on path names containing round bracket "()" chars

JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/MNG-6350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Scholte updated MNG-6350:
--------------------------------
    Comment: was deleted

(was: mickaelistria commented on a change in pull request #194: MNG-6350 - Test + System property to disable global model cache
URL: https://github.com/apache/maven/pull/194#discussion_r238852589
 
 

 ##########
 File path: maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuilder.java
 ##########
 @@ -355,7 +365,8 @@ private ModelSource createStubModelSource( Artifact artifact )
 
         ReactorModelPool modelPool = new ReactorModelPool();
 
-        InternalConfig config = new InternalConfig( request, modelPool );
+        InternalConfig config = new InternalConfig( request, modelPool,
+                useGlobalModelCache() ? getModelCache() : new ReactorModelCache() );
 
 Review comment:
   I'm basically restoring the behavior before changes for MNG-6311 were applied.
   I think in case of reading a single project, we don't need a cache as there is no risk that we will read the same pom multiple times; but in the case of using `build(listOfProject,...)`, then the cache is necessary to make sure that poms are read only once (so that 2 children module of the same parent would reference the same parent as MavenProject and not instantiate 2 clones of it).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]
)

> Maven 3.5.2 Command Line mvn.cmd fails on path names containing round bracket "()" chars
> ----------------------------------------------------------------------------------------
>
>                 Key: MNG-6350
>                 URL: https://issues.apache.org/jira/browse/MNG-6350
>             Project: Maven
>          Issue Type: Bug
>          Components: Command Line
>    Affects Versions: 3.5.2
>         Environment: Windows OS
>            Reporter: Markus Hoffrogge
>            Assignee: Robert Scholte
>            Priority: Major
>              Labels: windows
>         Attachments: mvn.cmd_roundBrackets_1.png, mvn.cmd_roundBrackets_2.png
>
>
> If the absolute path name of the -f command line parameter contains round bracket characters "(" or ")", then the command line mvn.cmd fails with "... was unexpected at this time".
> The issue can be easily fixed in mvn.cmd, 3.5.2 for he appropriate echo statements:
> line 120: enclose %FILE_ARGS% by "" -> "%FILE_ARGS%"
> line 129: same for %POM_DIR% and %FILE_ARGS%
> The screenshots attached have been created with env var MAVEN_BATCH_ECHO=on.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)