Handling emails in pom.xml

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

Handling emails in pom.xml

Maxim Solodovnik
Hello All,

Recently I noticed the issue with site generation [1]
<developers>
    <developer>
        <email>mailto:mailaddrr</email>
    </developer>
<developers>
Section is not being properly processed after switching to maven report
plugin 3.0 (please see [2])

What is the proper way to get well formatted emails?

[1]
https://github.com/devacfr/reflow-maven-skin/issues/40#issuecomment-445304386
[2]
https://builds.apache.org/view/M-R/view/OpenMeetings/job/openmeetings/site/openmeetings-server/team.html

--
WBR
Maxim aka solomax
Reply | Threaded
Open this post in threaded view
|

Re: Handling emails in pom.xml

Andreas Sewe-2
Hi Maxim,

> Recently I noticed the issue with site generation [1]
> <developers>
>     <developer>
>         <email>mailto:mailaddrr</email>

AFAIK, the <email> element takes just the plain e-mail address, not a
(mailto) URI:

 <email>[hidden email]</email>

See [1] for a longer example.

Hope that helps.

Andreas

[1] <https://maven.apache.org/pom.html#Developers>


signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Handling emails in pom.xml

Maxim Solodovnik
Thanks for the quick response
To illustrate the issue I have modified pom [1] to have both prefixed and
non prefixed emails
The result is here: [2] as you can see prefixed emails are correctly being
displayed as mailto: links, but has wrong text
Not prefixed has valid text, but wrong links ...

According to Frederich's investigation available here [3] this was working
with previous versions of maven report plugin
I'm OK with changing the pom.xml, but unfortunately it seems both ways are
wrong :(

[1] https://github.com/apache/openmeetings/blob/master/pom.xml#L150
[2]
https://builds.apache.org/view/M-R/view/OpenMeetings/job/openmeetings/site/openmeetings-server/team.html
[3]
https://github.com/devacfr/reflow-maven-skin/issues/40#issuecomment-445304386


On Mon, 10 Dec 2018 at 15:08, Andreas Sewe <
[hidden email]> wrote:

> Hi Maxim,
>
> > Recently I noticed the issue with site generation [1]
> > <developers>
> >     <developer>
> >         <email>mailto:mailaddrr</email>
>
> AFAIK, the <email> element takes just the plain e-mail address, not a
> (mailto) URI:
>
>  <email>[hidden email]</email>
>
> See [1] for a longer example.
>
> Hope that helps.
>
> Andreas
>
> [1] <https://maven.apache.org/pom.html#Developers>
>
>

--
WBR
Maxim aka solomax
Reply | Threaded
Open this post in threaded view
|

Re: Handling emails in pom.xml

Maxim Solodovnik
Maybe I should write to some other mailing list?

On Mon, 10 Dec 2018 at 16:11, Maxim Solodovnik <[hidden email]> wrote:

> Thanks for the quick response
> To illustrate the issue I have modified pom [1] to have both prefixed and
> non prefixed emails
> The result is here: [2] as you can see prefixed emails are correctly being
> displayed as mailto: links, but has wrong text
> Not prefixed has valid text, but wrong links ...
>
> According to Frederich's investigation available here [3] this was working
> with previous versions of maven report plugin
> I'm OK with changing the pom.xml, but unfortunately it seems both ways are
> wrong :(
>
> [1] https://github.com/apache/openmeetings/blob/master/pom.xml#L150
> [2]
> https://builds.apache.org/view/M-R/view/OpenMeetings/job/openmeetings/site/openmeetings-server/team.html
> [3]
> https://github.com/devacfr/reflow-maven-skin/issues/40#issuecomment-445304386
>
>
> On Mon, 10 Dec 2018 at 15:08, Andreas Sewe <
> [hidden email]> wrote:
>
>> Hi Maxim,
>>
>> > Recently I noticed the issue with site generation [1]
>> > <developers>
>> >     <developer>
>> >         <email>mailto:mailaddrr</email>
>>
>> AFAIK, the <email> element takes just the plain e-mail address, not a
>> (mailto) URI:
>>
>>  <email>[hidden email]</email>
>>
>> See [1] for a longer example.
>>
>> Hope that helps.
>>
>> Andreas
>>
>> [1] <https://maven.apache.org/pom.html#Developers>
>>
>>
>
> --
> WBR
> Maxim aka solomax
>


--
WBR
Maxim aka solomax
Reply | Threaded
Open this post in threaded view
|

Re: Handling emails in pom.xml

Maxim Solodovnik
Maybe version 3.0 of maven-project-info-reports-plugin shouldn't be used
for project site generation?

I have to manually fix "team" page after each release, please help me

On Mon, 17 Dec 2018 at 22:46, Maxim Solodovnik <[hidden email]> wrote:

> Maybe I should write to some other mailing list?
>
> On Mon, 10 Dec 2018 at 16:11, Maxim Solodovnik <[hidden email]>
> wrote:
>
>> Thanks for the quick response
>> To illustrate the issue I have modified pom [1] to have both prefixed and
>> non prefixed emails
>> The result is here: [2] as you can see prefixed emails are correctly
>> being displayed as mailto: links, but has wrong text
>> Not prefixed has valid text, but wrong links ...
>>
>> According to Frederich's investigation available here [3] this was
>> working with previous versions of maven report plugin
>> I'm OK with changing the pom.xml, but unfortunately it seems both ways
>> are wrong :(
>>
>> [1] https://github.com/apache/openmeetings/blob/master/pom.xml#L150
>> [2]
>> https://builds.apache.org/view/M-R/view/OpenMeetings/job/openmeetings/site/openmeetings-server/team.html
>> [3]
>> https://github.com/devacfr/reflow-maven-skin/issues/40#issuecomment-445304386
>>
>>
>> On Mon, 10 Dec 2018 at 15:08, Andreas Sewe <
>> [hidden email]> wrote:
>>
>>> Hi Maxim,
>>>
>>> > Recently I noticed the issue with site generation [1]
>>> > <developers>
>>> >     <developer>
>>> >         <email>mailto:mailaddrr</email>
>>>
>>> AFAIK, the <email> element takes just the plain e-mail address, not a
>>> (mailto) URI:
>>>
>>>  <email>[hidden email]</email>
>>>
>>> See [1] for a longer example.
>>>
>>> Hope that helps.
>>>
>>> Andreas
>>>
>>> [1] <https://maven.apache.org/pom.html#Developers>
>>>
>>>
>>
>> --
>> WBR
>> Maxim aka solomax
>>
>
>
> --
> WBR
> Maxim aka solomax
>


--
WBR
Maxim aka solomax
Reply | Threaded
Open this post in threaded view
|

Re: Handling emails in pom.xml

rfscholte
We might be more explicit in the definition, but it should be
<email>[hidden email]</email>

the mailto: is only an URI scheme for email addresses, but here we already  
know we're working with an email.

Not sure what must done to help you manually fix your team-page.

thanks,
Robrt

On Fri, 18 Jan 2019 18:15:32 +0100, Maxim Solodovnik  
<[hidden email]> wrote:

> Maybe version 3.0 of maven-project-info-reports-plugin shouldn't be used
> for project site generation?
>
> I have to manually fix "team" page after each release, please help me
>
> On Mon, 17 Dec 2018 at 22:46, Maxim Solodovnik <[hidden email]>  
> wrote:
>
>> Maybe I should write to some other mailing list?
>>
>> On Mon, 10 Dec 2018 at 16:11, Maxim Solodovnik <[hidden email]>
>> wrote:
>>
>>> Thanks for the quick response
>>> To illustrate the issue I have modified pom [1] to have both prefixed  
>>> and
>>> non prefixed emails
>>> The result is here: [2] as you can see prefixed emails are correctly
>>> being displayed as mailto: links, but has wrong text
>>> Not prefixed has valid text, but wrong links ...
>>>
>>> According to Frederich's investigation available here [3] this was
>>> working with previous versions of maven report plugin
>>> I'm OK with changing the pom.xml, but unfortunately it seems both ways
>>> are wrong :(
>>>
>>> [1] https://github.com/apache/openmeetings/blob/master/pom.xml#L150
>>> [2]
>>> https://builds.apache.org/view/M-R/view/OpenMeetings/job/openmeetings/site/openmeetings-server/team.html
>>> [3]
>>> https://github.com/devacfr/reflow-maven-skin/issues/40#issuecomment-445304386
>>>
>>>
>>> On Mon, 10 Dec 2018 at 15:08, Andreas Sewe <
>>> [hidden email]> wrote:
>>>
>>>> Hi Maxim,
>>>>
>>>> > Recently I noticed the issue with site generation [1]
>>>> > <developers>
>>>> >     <developer>
>>>> >         <email>mailto:mailaddrr</email>
>>>>
>>>> AFAIK, the <email> element takes just the plain e-mail address, not a
>>>> (mailto) URI:
>>>>
>>>>  <email>[hidden email]</email>
>>>>
>>>> See [1] for a longer example.
>>>>
>>>> Hope that helps.
>>>>
>>>> Andreas
>>>>
>>>> [1] <https://maven.apache.org/pom.html#Developers>
>>>>
>>>>
>>>
>>> --
>>> WBR
>>> Maxim aka solomax
>>>
>>
>>
>> --
>> WBR
>> Maxim aka solomax
>>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Handling emails in pom.xml

Maxim Solodovnik
Hello Robert,

Thanks for quick answer
It seems I wasn't clear enough (I'm not native English speaker)

To it seems to be the issue with maven-project-info-reports-plugin

Here is test case can be used:
1) download this [1] pom file to the new folder
2) run `mvn clean site`
3) open target/site/team-list.html in browser
Result: email is converted to "mailto:" link

4) open this file in your favorite text editor
5) uncomment line 13 <!--
maven-project-info-reports-plugin.version>3.0.0</maven-project-info-reports-plugin.version-->
6) comment line
14 <maven-project-info-reports-plugin.version>2.9</maven-project-info-reports-plugin.version>
7) uncomment line 81 <!-- report>team</report-->
8) comment line 82 <report>project-team</report>
9) run `mvn clean site`
10) open target/site/team.html in browser
Result: email is displayed as plain link to nowhere

Does it make sense?

[1] https://gist.github.com/solomax/2ce33116bb56cc5c5b1942f245f6d1b8


On Sat, 19 Jan 2019 at 01:21, Robert Scholte <[hidden email]> wrote:

> We might be more explicit in the definition, but it should be
> <email>[hidden email]</email>
>
> the mailto: is only an URI scheme for email addresses, but here we
> already
> know we're working with an email.
>
> Not sure what must done to help you manually fix your team-page.
>
> thanks,
> Robrt
>
> On Fri, 18 Jan 2019 18:15:32 +0100, Maxim Solodovnik
> <[hidden email]> wrote:
>
> > Maybe version 3.0 of maven-project-info-reports-plugin shouldn't be used
> > for project site generation?
> >
> > I have to manually fix "team" page after each release, please help me
> >
> > On Mon, 17 Dec 2018 at 22:46, Maxim Solodovnik <[hidden email]>
> > wrote:
> >
> >> Maybe I should write to some other mailing list?
> >>
> >> On Mon, 10 Dec 2018 at 16:11, Maxim Solodovnik <[hidden email]>
> >> wrote:
> >>
> >>> Thanks for the quick response
> >>> To illustrate the issue I have modified pom [1] to have both prefixed
> >>> and
> >>> non prefixed emails
> >>> The result is here: [2] as you can see prefixed emails are correctly
> >>> being displayed as mailto: links, but has wrong text
> >>> Not prefixed has valid text, but wrong links ...
> >>>
> >>> According to Frederich's investigation available here [3] this was
> >>> working with previous versions of maven report plugin
> >>> I'm OK with changing the pom.xml, but unfortunately it seems both ways
> >>> are wrong :(
> >>>
> >>> [1] https://github.com/apache/openmeetings/blob/master/pom.xml#L150
> >>> [2]
> >>>
> https://builds.apache.org/view/M-R/view/OpenMeetings/job/openmeetings/site/openmeetings-server/team.html
> >>> [3]
> >>>
> https://github.com/devacfr/reflow-maven-skin/issues/40#issuecomment-445304386
> >>>
> >>>
> >>> On Mon, 10 Dec 2018 at 15:08, Andreas Sewe <
> >>> [hidden email]> wrote:
> >>>
> >>>> Hi Maxim,
> >>>>
> >>>> > Recently I noticed the issue with site generation [1]
> >>>> > <developers>
> >>>> >     <developer>
> >>>> >         <email>mailto:mailaddrr</email>
> >>>>
> >>>> AFAIK, the <email> element takes just the plain e-mail address, not a
> >>>> (mailto) URI:
> >>>>
> >>>>  <email>[hidden email]</email>
> >>>>
> >>>> See [1] for a longer example.
> >>>>
> >>>> Hope that helps.
> >>>>
> >>>> Andreas
> >>>>
> >>>> [1] <https://maven.apache.org/pom.html#Developers>
> >>>>
> >>>>
> >>>
> >>> --
> >>> WBR
> >>> Maxim aka solomax
> >>>
> >>
> >>
> >> --
> >> WBR
> >> Maxim aka solomax
> >>
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>

--
WBR
Maxim aka solomax
Reply | Threaded
Open this post in threaded view
|

Re: Handling emails in pom.xml

rfscholte
Congratulations, you found a bug in the team-report code.

Please file an issue at MPIR[1]
Consider creating a pull request[2] too, this one isn't that hard to solve  
(but don't forget to add a test to prevent regression in the future).

thanks,
Robert

[1] https://issues.apache.org/jira/browse/MPIR
[2] https://github.com/apache/maven-project-info-reports-plugin/

On Sat, 19 Jan 2019 05:27:05 +0100, Maxim Solodovnik  
<[hidden email]> wrote:

> Hello Robert,
>
> Thanks for quick answer
> It seems I wasn't clear enough (I'm not native English speaker)
>
> To it seems to be the issue with maven-project-info-reports-plugin
>
> Here is test case can be used:
> 1) download this [1] pom file to the new folder
> 2) run `mvn clean site`
> 3) open target/site/team-list.html in browser
> Result: email is converted to "mailto:" link
>
> 4) open this file in your favorite text editor
> 5) uncomment line 13 <!--
> maven-project-info-reports-plugin.version>3.0.0</maven-project-info-reports-plugin.version-->
> 6) comment line
> 14  
> <maven-project-info-reports-plugin.version>2.9</maven-project-info-reports-plugin.version>
> 7) uncomment line 81 <!-- report>team</report-->
> 8) comment line 82 <report>project-team</report>
> 9) run `mvn clean site`
> 10) open target/site/team.html in browser
> Result: email is displayed as plain link to nowhere
>
> Does it make sense?
>
> [1] https://gist.github.com/solomax/2ce33116bb56cc5c5b1942f245f6d1b8
>
>
> On Sat, 19 Jan 2019 at 01:21, Robert Scholte <[hidden email]>  
> wrote:
>
>> We might be more explicit in the definition, but it should be
>> <email>[hidden email]</email>
>>
>> the mailto: is only an URI scheme for email addresses, but here we
>> already
>> know we're working with an email.
>>
>> Not sure what must done to help you manually fix your team-page.
>>
>> thanks,
>> Robrt
>>
>> On Fri, 18 Jan 2019 18:15:32 +0100, Maxim Solodovnik
>> <[hidden email]> wrote:
>>
>> > Maybe version 3.0 of maven-project-info-reports-plugin shouldn't be  
>> used
>> > for project site generation?
>> >
>> > I have to manually fix "team" page after each release, please help me
>> >
>> > On Mon, 17 Dec 2018 at 22:46, Maxim Solodovnik <[hidden email]>
>> > wrote:
>> >
>> >> Maybe I should write to some other mailing list?
>> >>
>> >> On Mon, 10 Dec 2018 at 16:11, Maxim Solodovnik <[hidden email]>
>> >> wrote:
>> >>
>> >>> Thanks for the quick response
>> >>> To illustrate the issue I have modified pom [1] to have both  
>> prefixed
>> >>> and
>> >>> non prefixed emails
>> >>> The result is here: [2] as you can see prefixed emails are correctly
>> >>> being displayed as mailto: links, but has wrong text
>> >>> Not prefixed has valid text, but wrong links ...
>> >>>
>> >>> According to Frederich's investigation available here [3] this was
>> >>> working with previous versions of maven report plugin
>> >>> I'm OK with changing the pom.xml, but unfortunately it seems both  
>> ways
>> >>> are wrong :(
>> >>>
>> >>> [1] https://github.com/apache/openmeetings/blob/master/pom.xml#L150
>> >>> [2]
>> >>>
>> https://builds.apache.org/view/M-R/view/OpenMeetings/job/openmeetings/site/openmeetings-server/team.html
>> >>> [3]
>> >>>
>> https://github.com/devacfr/reflow-maven-skin/issues/40#issuecomment-445304386
>> >>>
>> >>>
>> >>> On Mon, 10 Dec 2018 at 15:08, Andreas Sewe <
>> >>> [hidden email]> wrote:
>> >>>
>> >>>> Hi Maxim,
>> >>>>
>> >>>> > Recently I noticed the issue with site generation [1]
>> >>>> > <developers>
>> >>>> >     <developer>
>> >>>> >         <email>mailto:mailaddrr</email>
>> >>>>
>> >>>> AFAIK, the <email> element takes just the plain e-mail address,  
>> not a
>> >>>> (mailto) URI:
>> >>>>
>> >>>>  <email>[hidden email]</email>
>> >>>>
>> >>>> See [1] for a longer example.
>> >>>>
>> >>>> Hope that helps.
>> >>>>
>> >>>> Andreas
>> >>>>
>> >>>> [1] <https://maven.apache.org/pom.html#Developers>
>> >>>>
>> >>>>
>> >>>
>> >>> --
>> >>> WBR
>> >>> Maxim aka solomax
>> >>>
>> >>
>> >>
>> >> --
>> >> WBR
>> >> Maxim aka solomax
>> >>
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Handling emails in pom.xml

Maxim Solodovnik
Done: https://issues.apache.org/jira/projects/MPIR/issues/MPIR-380
Will check if I can create PR
Maven is something I'm unable to fix :(

On Sat, 19 Jan 2019 at 17:15, Robert Scholte <[hidden email]> wrote:

> Congratulations, you found a bug in the team-report code.
>
> Please file an issue at MPIR[1]
> Consider creating a pull request[2] too, this one isn't that hard to
> solve
> (but don't forget to add a test to prevent regression in the future).
>
> thanks,
> Robert
>
> [1] https://issues.apache.org/jira/browse/MPIR
> [2] https://github.com/apache/maven-project-info-reports-plugin/
>
> On Sat, 19 Jan 2019 05:27:05 +0100, Maxim Solodovnik
> <[hidden email]> wrote:
>
> > Hello Robert,
> >
> > Thanks for quick answer
> > It seems I wasn't clear enough (I'm not native English speaker)
> >
> > To it seems to be the issue with maven-project-info-reports-plugin
> >
> > Here is test case can be used:
> > 1) download this [1] pom file to the new folder
> > 2) run `mvn clean site`
> > 3) open target/site/team-list.html in browser
> > Result: email is converted to "mailto:" link
> >
> > 4) open this file in your favorite text editor
> > 5) uncomment line 13 <!--
> >
> maven-project-info-reports-plugin.version>3.0.0</maven-project-info-reports-plugin.version-->
> > 6) comment line
> > 14
> >
> <maven-project-info-reports-plugin.version>2.9</maven-project-info-reports-plugin.version>
> > 7) uncomment line 81 <!-- report>team</report-->
> > 8) comment line 82 <report>project-team</report>
> > 9) run `mvn clean site`
> > 10) open target/site/team.html in browser
> > Result: email is displayed as plain link to nowhere
> >
> > Does it make sense?
> >
> > [1] https://gist.github.com/solomax/2ce33116bb56cc5c5b1942f245f6d1b8
> >
> >
> > On Sat, 19 Jan 2019 at 01:21, Robert Scholte <[hidden email]>
> > wrote:
> >
> >> We might be more explicit in the definition, but it should be
> >> <email>[hidden email]</email>
> >>
> >> the mailto: is only an URI scheme for email addresses, but here we
> >> already
> >> know we're working with an email.
> >>
> >> Not sure what must done to help you manually fix your team-page.
> >>
> >> thanks,
> >> Robrt
> >>
> >> On Fri, 18 Jan 2019 18:15:32 +0100, Maxim Solodovnik
> >> <[hidden email]> wrote:
> >>
> >> > Maybe version 3.0 of maven-project-info-reports-plugin shouldn't be
> >> used
> >> > for project site generation?
> >> >
> >> > I have to manually fix "team" page after each release, please help me
> >> >
> >> > On Mon, 17 Dec 2018 at 22:46, Maxim Solodovnik <[hidden email]>
> >> > wrote:
> >> >
> >> >> Maybe I should write to some other mailing list?
> >> >>
> >> >> On Mon, 10 Dec 2018 at 16:11, Maxim Solodovnik <[hidden email]
> >
> >> >> wrote:
> >> >>
> >> >>> Thanks for the quick response
> >> >>> To illustrate the issue I have modified pom [1] to have both
> >> prefixed
> >> >>> and
> >> >>> non prefixed emails
> >> >>> The result is here: [2] as you can see prefixed emails are correctly
> >> >>> being displayed as mailto: links, but has wrong text
> >> >>> Not prefixed has valid text, but wrong links ...
> >> >>>
> >> >>> According to Frederich's investigation available here [3] this was
> >> >>> working with previous versions of maven report plugin
> >> >>> I'm OK with changing the pom.xml, but unfortunately it seems both
> >> ways
> >> >>> are wrong :(
> >> >>>
> >> >>> [1] https://github.com/apache/openmeetings/blob/master/pom.xml#L150
> >> >>> [2]
> >> >>>
> >>
> https://builds.apache.org/view/M-R/view/OpenMeetings/job/openmeetings/site/openmeetings-server/team.html
> >> >>> [3]
> >> >>>
> >>
> https://github.com/devacfr/reflow-maven-skin/issues/40#issuecomment-445304386
> >> >>>
> >> >>>
> >> >>> On Mon, 10 Dec 2018 at 15:08, Andreas Sewe <
> >> >>> [hidden email]> wrote:
> >> >>>
> >> >>>> Hi Maxim,
> >> >>>>
> >> >>>> > Recently I noticed the issue with site generation [1]
> >> >>>> > <developers>
> >> >>>> >     <developer>
> >> >>>> >         <email>mailto:mailaddrr</email>
> >> >>>>
> >> >>>> AFAIK, the <email> element takes just the plain e-mail address,
> >> not a
> >> >>>> (mailto) URI:
> >> >>>>
> >> >>>>  <email>[hidden email]</email>
> >> >>>>
> >> >>>> See [1] for a longer example.
> >> >>>>
> >> >>>> Hope that helps.
> >> >>>>
> >> >>>> Andreas
> >> >>>>
> >> >>>> [1] <https://maven.apache.org/pom.html#Developers>
> >> >>>>
> >> >>>>
> >> >>>
> >> >>> --
> >> >>> WBR
> >> >>> Maxim aka solomax
> >> >>>
> >> >>
> >> >>
> >> >> --
> >> >> WBR
> >> >> Maxim aka solomax
> >> >>
> >> >
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: [hidden email]
> >> For additional commands, e-mail: [hidden email]
> >>
> >>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>

--
WBR
Maxim aka solomax