[GitHub] [maven-war-plugin] pzygielo opened a new pull request #8: [MWAR-430] Discover Jakarta Servlet API as excuse for not having web.xml

classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-war-plugin] pzygielo opened a new pull request #8: [MWAR-430] Discover Jakarta Servlet API as excuse for not having web.xml

GitBox

pzygielo opened a new pull request #8:
URL: https://github.com/apache/maven-war-plugin/pull/8


   @olamy may I ask for review, please?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-war-plugin] khmarbaise commented on pull request #8: [MWAR-430] Discover Jakarta Servlet API as excuse for not having web.xml

GitBox

khmarbaise commented on pull request #8:
URL: https://github.com/apache/maven-war-plugin/pull/8#issuecomment-638970731


   @olamy WDYT?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-war-plugin] pzygielo commented on pull request #8: [MWAR-430] Discover Jakarta Servlet API as excuse for not having web.xml

GitBox
In reply to this post by GitBox

pzygielo commented on pull request #8:
URL: https://github.com/apache/maven-war-plugin/pull/8#issuecomment-638984980


   @khmarbaise - commits squashed


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-war-plugin] pzygielo commented on pull request #8: [MWAR-430] Discover Jakarta Servlet API as excuse for not having web.xml

GitBox
In reply to this post by GitBox

pzygielo commented on pull request #8:
URL: https://github.com/apache/maven-war-plugin/pull/8#issuecomment-639327437


   1. so it seems that (failed) :red_circle: [build 1](https://builds.apache.org/job/maven-box/job/maven-war-plugin/job/pzygielo-mwar-430/1/) ran against 4 commits (it should not matter as contents is the same)
   2. I executed `verify -P run-its` (before push) locally on linux/jdk8 and as on Jenkins - it's ok in my env
   3. on first read of [1/consoleFull](https://builds.apache.org/job/maven-box/job/maven-war-plugin/job/pzygielo-mwar-430/1/consoleFull) failure is not obvious for me.
   I suspected that new class from jakarta
   ```
   $ file WebServlet.class
   WebServlet.class: compiled Java class data, version 52.0 (Java 1.8)
   ```
   could not collaborate with JDK7.:
   ```
   Caused by: java.lang.UnsupportedClassVersionError: jakarta/servlet/annotation/WebServlet : Unsupported major.minor version 52.0
   ...
       at org.apache.maven.plugins.war.WarMojo.hasClassInClasspath (WarMojo.java:341)
   ```
   but a lot more ITs fail with JDK7, not new one only, so I'm a bit confused...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-war-plugin] pzygielo commented on pull request #8: [MWAR-430] Discover Jakarta Servlet API as excuse for not having web.xml

GitBox
In reply to this post by GitBox

pzygielo commented on pull request #8:
URL: https://github.com/apache/maven-war-plugin/pull/8#issuecomment-639329270


   In [blue ocean/pipeline](https://builds.apache.org/blue/organizations/jenkins/maven-box%2Fmaven-war-plugin/detail/pzygielo-mwar-430/1/pipeline) view it's clear that JDK7 is common factor.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-war-plugin] pzygielo edited a comment on pull request #8: [MWAR-430] Discover Jakarta Servlet API as excuse for not having web.xml

GitBox
In reply to this post by GitBox

pzygielo edited a comment on pull request #8:
URL: https://github.com/apache/maven-war-plugin/pull/8#issuecomment-639327437


   1. so it seems that (failed) :red_circle: [build 1](https://builds.apache.org/job/maven-box/job/maven-war-plugin/job/pzygielo-mwar-430/1/) ran against 4 commits (it should not matter as contents is the same)
   2. I executed `verify -P run-its` (before push) locally on linux/jdk8 and as on Jenkins - it's ok in my env
   3. on first read of [1/consoleFull](https://builds.apache.org/job/maven-box/job/maven-war-plugin/job/pzygielo-mwar-430/1/consoleFull) failure is not obvious for me.
   I suspected that new class from jakarta
   ```
   $ file WebServlet.class
   WebServlet.class: compiled Java class data, version 52.0 (Java 1.8)
   ```
   could not collaborate with JDK7.:
   ```
   Caused by: java.lang.UnsupportedClassVersionError: jakarta/servlet/annotation/WebServlet : Unsupported major.minor version 52.0
   ...
       at org.apache.maven.plugins.war.WarMojo.hasClassInClasspath (WarMojo.java:341)
   ```
   but a lot more ITs fail with JDK7, not new one only, so I'm a bit confused...
   
   ---
   <sup>Some ITs fail locally due to no other reason but</sup>
   ```
   Caused by: javax.net.ssl.SSLException: Received fatal alert: protocol_version
   ```
   <sup>for artifacts that are missing in my repository, and maven on JDK7 can't establish connection with central. Setting `-Dhttps.protocols=TLSv1.2` doesn't help, but getting dependency/plugin in other way into repository - does.</sup>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-war-plugin] hboutemy commented on pull request #8: [MWAR-430] Discover Jakarta Servlet API as excuse for not having web.xml

GitBox
In reply to this post by GitBox

hboutemy commented on pull request #8:
URL: https://github.com/apache/maven-war-plugin/pull/8#issuecomment-639601581


   if the new IT requires Java 8, you can mark it with invoker.properties
   see for example https://github.com/apache/maven-pmd-plugin/blob/master/src/it/MPMD-302-JDK14/invoker.properties


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-war-plugin] pzygielo commented on pull request #8: [MWAR-430] Discover Jakarta Servlet API as excuse for not having web.xml

GitBox
In reply to this post by GitBox

pzygielo commented on pull request #8:
URL: https://github.com/apache/maven-war-plugin/pull/8#issuecomment-639602830


   > if the new IT requires Java 8, you can mark it with invoker.properties
   > see for example https://github.com/apache/maven-pmd-plugin/blob/master/src/it/MPMD-302-JDK14/invoker.properties
   
   Thanks, that's what I did in #9.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-war-plugin] pzygielo commented on pull request #8: [MWAR-430] Discover Jakarta Servlet API as excuse for not having web.xml

GitBox
In reply to this post by GitBox

pzygielo commented on pull request #8:
URL: https://github.com/apache/maven-war-plugin/pull/8#issuecomment-639604848


   @hboutemy - but with your confirmation that it's the way to go I'll squash #9 here and push new commit for review.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-war-plugin] hboutemy commented on pull request #8: [MWAR-430] Discover Jakarta Servlet API as excuse for not having web.xml

GitBox
In reply to this post by GitBox

hboutemy commented on pull request #8:
URL: https://github.com/apache/maven-war-plugin/pull/8#issuecomment-639608710


   IMHO, no need for UnsupportedClassVersionError check: this won't happen for end-users
   limiting the execution of the IT to 8+ JDK versions is sufficient


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-war-plugin] pzygielo commented on pull request #8: [MWAR-430] Discover Jakarta Servlet API as excuse for not having web.xml

GitBox
In reply to this post by GitBox

pzygielo commented on pull request #8:
URL: https://github.com/apache/maven-war-plugin/pull/8#issuecomment-639615037


   > IMHO, no need for UnsupportedClassVersionError check: this won't happen for end-users
   limiting the execution of the IT to 8+ JDK versions is sufficient.
   
   Just to clarify my understanding: if there is jakarta's web servlet annotation in CP (only then plugin would load this class), it means also that project is already compiled with JDK8+. Right? In such case, catching UCVE isn't needed indeed!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-war-plugin] olamy merged pull request #8: [MWAR-430] Discover Jakarta Servlet API as excuse for not having web.xml

GitBox
In reply to this post by GitBox

olamy merged pull request #8:
URL: https://github.com/apache/maven-war-plugin/pull/8


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]