[GitHub] [maven-wagon] olamy commented on a change in pull request #57: WAGON-567: support retry on server side errors

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-wagon] olamy commented on a change in pull request #57: WAGON-567: support retry on server side errors

GitBox
olamy commented on a change in pull request #57: WAGON-567: support retry on server side errors
URL: https://github.com/apache/maven-wagon/pull/57#discussion_r332842474
 
 

 ##########
 File path: wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
 ##########
 @@ -487,6 +487,8 @@ private static CloseableHttpClient createClient()
             .disableConnectionState() //
             .setConnectionManager( httpClientConnectionManager ) //
             .setRetryHandler( createRetryHandler() )
+            .setServiceUnavailableRetryStrategy(
+                    new SimpleServiceUnavailableRetryStrategy( 10, 1000 ) )
 
 Review comment:
   if we implement this it should be optional and retry number/time between retry configurable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services