[GitHub] [maven-wagon] michael-o commented on issue #60: [WAGON-574] advertise jsoup license for shaded jar

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-wagon] michael-o commented on issue #60: [WAGON-574] advertise jsoup license for shaded jar

GitBox
michael-o commented on issue #60: [WAGON-574] advertise jsoup license for shaded jar
URL: https://github.com/apache/maven-wagon/pull/60#issuecomment-552499958
 
 
   @hboutemy, I did not test anything. The interface implies that the underlying protocol has a notion of directories and collections. HTTP has neither. Assuming that some server will deliver some collection is wrong because it breaks a basic principle: never do an assumption about an unknown environment. Having that said, the given implementation cannot work reliably on any type of HTML style listing. Also Wagon is not necessary limited for repository manager.
   
   All I am saying is that if a protocol does not define collections/directories, don't try to implement them by some crude means with some assumptions, simply return `UnimplementedException`. Since HTTP really does not, see RFC 7230+, deprecate and mark it for removal.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services