[GitHub] [maven-wagon] hboutemy commented on issue #60: [WAGON-574] advertise jsoup license for shaded jar

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-wagon] hboutemy commented on issue #60: [WAGON-574] advertise jsoup license for shaded jar

GitBox
hboutemy commented on issue #60: [WAGON-574] advertise jsoup license for shaded jar
URL: https://github.com/apache/maven-wagon/pull/60#issuecomment-552397188
 
 
   @michael-o
   
   > First of all, Maven Core does not rely on that. Can you search for method in our code case?!
   
   sure, core does not, but core provides Wagon implementation to plugins: the issue is more subtle, people will have features that may not work with newer Maven versions
   
   > The implementation is highly coupled to a 10+ y/o Apache HTTPd mod_userdir output.
   
   you mean that it does not work for current central directory listing, like https://repo.maven.apache.org/maven2/org/apache/maven/wagon/ ? or it does not work for classical repository manager directory listing, like https://repository.apache.org/content/groups/snapshots/org/apache/maven/wagon/wagon/ ?
   
   > It was a misconception from the beginning.
   
   it's usual for repository managers to provide directory listing, it's a useful idea
   
   Now:
   1. once we figure out if the feature is really working or not, we could perhaps avoid this jsoup dependency: html we're looking for is probably not that complex
   2. the MIT license in artifact's pom.xml with comment looks to me a reasonable quick first step

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services