[GitHub] [maven] tolikz commented on issue #292: [MNG-6762] - Multimodule project with .mvn/settings.xml not working properly

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven] tolikz commented on issue #292: [MNG-6762] - Multimodule project with .mvn/settings.xml not working properly

GitBox
tolikz commented on issue #292: [MNG-6762] - Multimodule project with .mvn/settings.xml not working properly
URL: https://github.com/apache/maven/pull/292#issuecomment-540267801
 
 
   Thank you for such a prompt feedback! I created a separate JIRA issue and a pull request for duplicate resolveFile removal: https://issues.apache.org/jira/browse/MNG-6777.
   As to the formatting: I actually used the provided https://maven.apache.org/developers/maven-idea-codestyle.xml for my IDEA configuration, though I am not used to this particular code style, so I cannot easily spot its violations - could you, please, point out some examples?
   
   Overall, I agree that these changes are quite extensive and might need some discussion, so this pull request should probably be dropped. I will instead create a separate JIRA issue about possible changes in handling of command-line options with file path arguments.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services