Quantcast

[GitHub] maven-surefire pull request: SUREFIRE-1216: TEST-*.xml files gener...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
24 messages Options
12
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven-surefire pull request: SUREFIRE-1216: TEST-*.xml files gener...

mkrizmanic
GitHub user mfriedenhagen opened a pull request:

    https://github.com/apache/maven-surefire/pull/110

    SUREFIRE-1216: TEST-*.xml files generated by Surefire are invalid.

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mfriedenhagen/maven-surefire SUREFIRE-1216

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven-surefire/pull/110.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #110
   
----
commit 104ff2b71bd587fc08edbcc5e91fa1b20b1efccb
Author: Mirko Friedenhagen <[hidden email]>
Date:   2016-01-09T20:21:43Z

    SUREFIRE-1216: TEST-*.xml files generated by Surefire are invalid.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven-surefire pull request: SUREFIRE-1216: TEST-*.xml files gener...

mkrizmanic
Github user Tibor17 commented on the pull request:

    https://github.com/apache/maven-surefire/pull/110#issuecomment-170281272
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven-surefire pull request: SUREFIRE-1216: TEST-*.xml files gener...

mkrizmanic
In reply to this post by mkrizmanic
Github user Tibor17 commented on the pull request:

    https://github.com/apache/maven-surefire/pull/110#issuecomment-170281465
 
    @mfriedenhagen
    Can you answer my question to the exec time we spoke abot in https://issues.apache.org/jira/browse/SUREFIRE-964 ? It is related to this issue but I could not reproduce 66.864949.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven-surefire pull request: SUREFIRE-1216: TEST-*.xml files gener...

mkrizmanic
In reply to this post by mkrizmanic
Github user mfriedenhagen commented on the pull request:

    https://github.com/apache/maven-surefire/pull/110#issuecomment-170283705
 
    * @Tibor17, I think I was confused by test files in the Jenkins' XUnit plugin (see https://github.com/jenkinsci/xunit-plugin/blob/master/src/test/resources/org/jenkinsci/plugins/xunit/types/junit/testcase1/input.xml).
    * To reproduce the Jenkins issue I just copied `input.xml` to testcase5 and added the schema declarations.
    * Now this firstly failed because of SUREFIRE-1216 and after I used `nonamespaceschemalocation` lateron the input data was just incorrect (more than 3 digits after the decimal separator). Sorry for the confusion. I can go ahead and just rebase this patch into master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven-surefire pull request: SUREFIRE-1216: TEST-*.xml files gener...

mkrizmanic
In reply to this post by mkrizmanic
Github user Tibor17 commented on the pull request:

    https://github.com/apache/maven-surefire/pull/110#issuecomment-170285026
 
    Feel free to push it to master. I will then update a branch 3.0-rc1.
    You can then close it in jira.
    If you have time we would need to alter `StatelessXmlReporter` with surefire|failsafe xsd. Now they are same but in the future both may split. The same as we are going to do with system properties which lack of prefix surefire|failsafe. Additionally this xsd https://maven.apache.org/surefire/maven-failsafe-plugin/xsd/surefire-test-report.xsd needs to be renamed to `failsafe-test-report.xsd` which is still possible because the class `StatelessXmlReporter` does not alter such xsd. They are both the same, hopefully now, but may necessarily not to be same.
    Thx.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven-surefire pull request: SUREFIRE-1216: TEST-*.xml files gener...

mkrizmanic
In reply to this post by mkrizmanic
Github user asfgit closed the pull request at:

    https://github.com/apache/maven-surefire/pull/110


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven-surefire issue #110: SUREFIRE-1216: TEST-*.xml files generated by Sure...

mkrizmanic
In reply to this post by mkrizmanic
Github user stdweird commented on the issue:

    https://github.com/apache/maven-surefire/pull/110
 
    is there any ETA for a release with this fix? or should i try to patch the local `.m2` cache?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven-surefire issue #110: SUREFIRE-1216: TEST-*.xml files generated by Sure...

mkrizmanic
In reply to this post by mkrizmanic
Github user Tibor17 commented on the issue:

    https://github.com/apache/maven-surefire/pull/110
 
    I will start release 2.19.2 with this fix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven-surefire issue #110: SUREFIRE-1216: TEST-*.xml files generated by Sure...

mkrizmanic
In reply to this post by mkrizmanic
Github user stdweird commented on the issue:

    https://github.com/apache/maven-surefire/pull/110
 
    @Tibor17 is there and ETA for 2.19.2?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven-surefire issue #110: SUREFIRE-1216: TEST-*.xml files generated by Sure...

mkrizmanic
In reply to this post by mkrizmanic
Github user justinharringa commented on the issue:

    https://github.com/apache/maven-surefire/pull/110
 
    @Tibor17 I'm also broken on this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven-surefire issue #110: SUREFIRE-1216: TEST-*.xml files generated by Sure...

mkrizmanic
In reply to this post by mkrizmanic
Github user Tibor17 commented on the issue:

    https://github.com/apache/maven-surefire/pull/110
 
    @justinharringa
    We are close to cut release version 2.19.2. Only 2 issues are still open and other critical/blocker issues must be fixed in 2.19.3.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven-surefire issue #110: SUREFIRE-1216: TEST-*.xml files generated by Sure...

mkrizmanic
In reply to this post by mkrizmanic
Github user justinharringa commented on the issue:

    https://github.com/apache/maven-surefire/pull/110
 
    Cool. Thanks for the update @Tibor17! :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven-surefire issue #110: SUREFIRE-1216: TEST-*.xml files generated by Sure...

mkrizmanic
In reply to this post by mkrizmanic
Github user stdweird commented on the issue:

    https://github.com/apache/maven-surefire/pull/110
 
    @Tibor17 i almost don't dare to ask, but is there any release coming up with this fix?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven-surefire issue #110: SUREFIRE-1216: TEST-*.xml files generated by Sure...

mkrizmanic
In reply to this post by mkrizmanic
Github user jonenst commented on the issue:

    https://github.com/apache/maven-surefire/pull/110
 
    @Tibor17 Hi, thanks for working on this. I'm also waiting for the release. Cheers.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven-surefire issue #110: SUREFIRE-1216: TEST-*.xml files generated by Sure...

mkrizmanic
In reply to this post by mkrizmanic
Github user Tibor17 commented on the issue:

    https://github.com/apache/maven-surefire/pull/110
 
    @justinharringa
    Yes fixing the critical issues is never ending story.
    I will release 2.19.2 and 2.19.3 later.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven-surefire issue #110: SUREFIRE-1216: TEST-*.xml files generated by Sure...

mkrizmanic
In reply to this post by mkrizmanic
Github user jonenst commented on the issue:

    https://github.com/apache/maven-surefire/pull/110
 
    @Tibor17 Hi, thanks for the releases. Any idea of the release date ? Cheers.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven-surefire issue #110: SUREFIRE-1216: TEST-*.xml files generated by Sure...

mkrizmanic
In reply to this post by mkrizmanic
Github user Tibor17 commented on the issue:

    https://github.com/apache/maven-surefire/pull/110
 
    @jonenst
    Next week on Friday it should be already in Maven Central.
    See the raod map [1]. We have last issue in good progress with 100% coverage of stream encoder and the only decoder is missing. I can push a new pull request to see the progress or commit directly.
    [1] https://issues.apache.org/jira/browse/SUREFIRE/?selectedTab=com.atlassian.jira.jira-projects-plugin:roadmap-panel


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven-surefire issue #110: SUREFIRE-1216: TEST-*.xml files generated by Sure...

mkrizmanic
In reply to this post by mkrizmanic
Github user jonenst commented on the issue:

    https://github.com/apache/maven-surefire/pull/110
 
    Hi @Tibor17, congratulations on the progress, 42/43 issues fixed. Any idea of the release date ? Cheers.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven-surefire issue #110: SUREFIRE-1216: TEST-*.xml files generated by Sure...

mkrizmanic
In reply to this post by mkrizmanic
Github user jonenst commented on the issue:

    https://github.com/apache/maven-surefire/pull/110
 
    Hi @Tibor17
    "54 of 55 issues have been resolved" on the roadmap, when can we expect a release ...?
    Is there something I can do to help with the release ?
    Cheers,
    Jon


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven-surefire issue #110: SUREFIRE-1216: TEST-*.xml files generated by Sure...

mkrizmanic
In reply to this post by mkrizmanic
Github user Tibor17 commented on the issue:

    https://github.com/apache/maven-surefire/pull/110
 
    @jonenst
    I was about to finish the last one and suddenly we had internal collision and now we reverted 11 commits. I am going to fix them but the procedure will be that we have to create branch for each cherry pick, make code review and then merge with master. I don't want to blame anyone in ASF so I will rather work now and make you happy.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

12
Loading...