[GitHub] maven-surefire pull request #174: https://issues.apache.org/jira/browse/SURE...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-surefire pull request #174: https://issues.apache.org/jira/browse/SURE...

bentatham
GitHub user awallgren opened a pull request:

    https://github.com/apache/maven-surefire/pull/174

    https://issues.apache.org/jira/browse/SUREFIRE-1475

    Don't assume wmic is on the path on windows.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/awallgren/maven-surefire master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven-surefire/pull/174.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #174
   
----
commit e5fba76e2a2e94489978da86a80a86e7cd6b0996
Author: Anders Wallgren <anders_wallgren@...>
Date:   2018-02-10T00:39:35Z

    https://issues.apache.org/jira/browse/SUREFIRE-1475
   
    Don't assume wmic is on the path on windows.

----


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-surefire issue #174: https://issues.apache.org/jira/browse/SUREFIRE-14...

bentatham
Github user Tibor17 commented on the issue:

    https://github.com/apache/maven-surefire/pull/174
 
    Did we take right path here as well? Did Microsoft mention this link in their documentation?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-surefire issue #174: https://issues.apache.org/jira/browse/SUREFIRE-14...

bentatham
In reply to this post by bentatham
Github user awallgren commented on the issue:

    https://github.com/apache/maven-surefire/pull/174
 
    Yes and yes.
    On Fri, Feb 9, 2018 at 19:22 Tibor Digana <[hidden email]> wrote:
   
    > Did we take right path here as well? Did Microsoft mention this link in
    > their documentation?
    >
    > —
    > You are receiving this because you authored the thread.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/maven-surefire/pull/174#issuecomment-364622261>,
    > or mute the thread
    > <https://github.com/notifications/unsubscribe-auth/AAo4-XXOJFHMquUq6N_beA24cCc0LowMks5tTQt5gaJpZM4SAuOL>
    > .
    >
    --
    anders



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-surefire issue #174: https://issues.apache.org/jira/browse/SUREFIRE-14...

bentatham
In reply to this post by bentatham
Github user awallgren commented on the issue:

    https://github.com/apache/maven-surefire/pull/174
 
    And certainly more correct than whatever random wmic.exe is on the path, if
    any. Also, it would be great if errors from the ping invocation weren't
    suppressed as thoroughly as they currently are.
   
   
    On Fri, Feb 9, 2018 at 22:59 Anders Wallgren <[hidden email]>
    wrote:
   
    > Yes and yes.
    > On Fri, Feb 9, 2018 at 19:22 Tibor Digana <[hidden email]>
    > wrote:
    >
    >> Did we take right path here as well? Did Microsoft mention this link in
    >> their documentation?
    >>
    >> —
    >> You are receiving this because you authored the thread.
    >> Reply to this email directly, view it on GitHub
    >> <https://github.com/apache/maven-surefire/pull/174#issuecomment-364622261>,
    >> or mute the thread
    >> <https://github.com/notifications/unsubscribe-auth/AAo4-XXOJFHMquUq6N_beA24cCc0LowMks5tTQt5gaJpZM4SAuOL>
    >> .
    >>
    > --
    > anders
    >
    --
    anders



---
Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-surefire issue #174: https://issues.apache.org/jira/browse/SUREFIRE-14...

bentatham
In reply to this post by bentatham
Github user Tibor17 commented on the issue:

    https://github.com/apache/maven-surefire/pull/174
 
    Logging errors can be added to the dump file, but right now please add the Microsoft link, as you said 'yes'.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-surefire issue #174: https://issues.apache.org/jira/browse/SUREFIRE-14...

bentatham
In reply to this post by bentatham
Github user Tibor17 commented on the issue:

    https://github.com/apache/maven-surefire/pull/174
 
    First of all do it similar like we do in *NIX.
    Resolve `%SystemRoot%\System32\Wbem\wmic.exe` in Java and check that the file exists.
    If it exists use it, otherwise do it as we did before.


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-surefire issue #174: https://issues.apache.org/jira/browse/SUREFIRE-14...

bentatham
In reply to this post by bentatham
Github user Tibor17 commented on the issue:

    https://github.com/apache/maven-surefire/pull/174
 
    Of course you should push only single commit in PR.
    `git commit --amend`
    and the title must be
    `[SUREFIRE-1475] ...here is title as in Jira...`


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-surefire issue #174: https://issues.apache.org/jira/browse/SUREFIRE-14...

bentatham
In reply to this post by bentatham
Github user Tibor17 commented on the issue:

    https://github.com/apache/maven-surefire/pull/174
 
    @awallgren
    Are you here?


---
Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-surefire issue #174: https://issues.apache.org/jira/browse/SUREFIRE-14...

bentatham
In reply to this post by bentatham
Github user Tibor17 commented on the issue:

    https://github.com/apache/maven-surefire/pull/174
 
    @awallgren
    You can close this PR. There is already a branch with dedicated fix:
    https://git-wip-us.apache.org/repos/asf?p=maven-surefire.git;a=shortlog;h=refs/heads/SUREFIRE-1475
    Thx for contributing!


---