[GitHub] maven-surefire pull request #171: [SUREFIRE-1445] Explicitly define Surefire...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-surefire pull request #171: [SUREFIRE-1445] Explicitly define Surefire...

Tibor17-2
Github user Tibor17 commented on a diff in the pull request:

    https://github.com/apache/maven-surefire/pull/171#discussion_r153650439
 
    --- Diff: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/SurefireProperties.java ---
    @@ -71,13 +71,22 @@ public SurefireProperties( KeyValueSource source )
             }
         }
     
    +    @Override
    +    public synchronized void putAll(Map<?, ?> t) {
    --- End diff --
   
    We have different conventions. Please see the spaces around brackets and new lines.
    The checkstyle plugin would crash the build. Did you try to run "mvn install -P run-its"?
    It would take quite long time to complete the build, cca one hour.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]