[GitHub] maven-surefire pull request #168: SUREFIRE-1424 javax.transaction.Transactio...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-surefire pull request #168: SUREFIRE-1424 javax.transaction.Transactio...

Tcharl
GitHub user eolivelli opened a pull request:

    https://github.com/apache/maven-surefire/pull/168

    SUREFIRE-1424 javax.transaction.TransactionManager not visible with Java9

    Contents of the patch:
    - drop --add-modules=java.ee.se
    - add a testcase on javax.transaction.TransactionManager


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/eolivelli/maven-surefire SUREFIRE-1424-noaddmodules

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven-surefire/pull/168.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #168
   
----
commit 42a8b161ebdd38837ba66be3588514df2b8c2b05
Author: Enrico Olivelli <[hidden email]>
Date:   2017-10-26T11:44:29Z

    SUREFIRE-1424 javax.transaction.TransactionManager not visible with Java9

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-surefire pull request #168: SUREFIRE-1424 javax.transaction.Transactio...

Tcharl
Github user Tibor17 commented on a diff in the pull request:

    https://github.com/apache/maven-surefire/pull/168#discussion_r151860070
 
    --- Diff: surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/Java9FullApiIT.java ---
    @@ -78,12 +83,13 @@ public void shouldLoadMultipleJavaModules_ToolchainsXML() throws IOException
                                                 .addGoal( "--toolchains" )
                                                 .addGoal( System.getProperty( "maven.toolchains.file" ) )
                                                 .execute( "verify" )
    -                                            .verifyErrorFree( 2 );
    +                                            .verifyErrorFree( 1 );
    --- End diff --
   
    Why it has changed from 2 to 1?
    There was two tests?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-surefire issue #168: SUREFIRE-1424 javax.transaction.TransactionManage...

Tcharl
In reply to this post by Tcharl
Github user Tibor17 commented on the issue:

    https://github.com/apache/maven-surefire/pull/168
 
    I had to prefer pushing my commit regarding Jigsaw modularity supported in Surefire project because it was too big to merge after yours. Please create a new PR with your changes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-surefire issue #168: SUREFIRE-1424 javax.transaction.TransactionManage...

Tcharl
In reply to this post by Tcharl
Github user Tibor17 commented on the issue:

    https://github.com/apache/maven-surefire/pull/168
 
    Try to name the PR like this ([] brackets):
    [SUREFIRE-1424] javax.transaction.TransactionManager not visible with Java9


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-surefire issue #168: [SUREFIRE-1424] javax.transaction.TransactionMana...

Tcharl
In reply to this post by Tcharl
Github user Tibor17 commented on the issue:

    https://github.com/apache/maven-surefire/pull/168
 
    It was done. But I don't think you can easily rebase it since some classes were deleted or methods moved.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-surefire issue #168: [SUREFIRE-1424] javax.transaction.TransactionMana...

Tcharl
In reply to this post by Tcharl
Github user eolivelli commented on the issue:

    https://github.com/apache/maven-surefire/pull/168
 
    Ok will do asap


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-surefire pull request #168: [SUREFIRE-1424] javax.transaction.Transact...

Tcharl
In reply to this post by Tcharl
Github user eolivelli commented on a diff in the pull request:

    https://github.com/apache/maven-surefire/pull/168#discussion_r152835233
 
    --- Diff: surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/Java9FullApiIT.java ---
    @@ -78,12 +83,13 @@ public void shouldLoadMultipleJavaModules_ToolchainsXML() throws IOException
                                                 .addGoal( "--toolchains" )
                                                 .addGoal( System.getProperty( "maven.toolchains.file" ) )
                                                 .execute( "verify" )
    -                                            .verifyErrorFree( 2 );
    +                                            .verifyErrorFree( 1 );
    --- End diff --
   
    @Tibor17 do you think it has some value to have an IT for corba ? I think that the given one is already a good proof, it tests other more important modules.
    Tell me, if you want I will clone this IT test only of corba


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-surefire issue #168: [SUREFIRE-1424] javax.transaction.TransactionMana...

Tcharl
In reply to this post by Tcharl
Github user eolivelli commented on the issue:

    https://github.com/apache/maven-surefire/pull/168
 
    @Tibor17 ok I will do this change. Will send tomorrow.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-surefire issue #168: [SUREFIRE-1424] javax.transaction.TransactionMana...

Tcharl
In reply to this post by Tcharl
Github user eolivelli commented on the issue:

    https://github.com/apache/maven-surefire/pull/168
 
    Oh, got it, I have to run "mvn site" on the root of the project not only on maven-surefire-plugin


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-surefire issue #168: [SUREFIRE-1424] javax.transaction.TransactionMana...

Tcharl
In reply to this post by Tcharl
Github user Tibor17 commented on the issue:

    https://github.com/apache/maven-surefire/pull/168
 
    If you could squash these two commits in one, it would be great.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]