[GitHub] maven-surefire pull request #166: Support filtering of tests from Base Class...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-surefire pull request #166: Support filtering of tests from Base Class...

Tibor17-2
Github user Tibor17 commented on a diff in the pull request:

    https://github.com/apache/maven-surefire/pull/166#discussion_r154519321
 
    --- Diff: surefire-providers/surefire-testng-utils/src/main/java/org/apache/maven/surefire/testng/utils/MethodSelector.java ---
    @@ -62,6 +62,17 @@ private static boolean shouldRun( ITestNGMethod test )
         {
             TestListResolver resolver = testListResolver;
             boolean hasTestResolver = resolver != null && !resolver.isEmpty();
    -        return hasTestResolver && resolver.shouldRun( test.getRealClass(), test.getMethodName() );
    +        boolean resolved = false;
    +        Class<?> clazz = test.getRealClass();
    +        if (resolver != null) {
    --- End diff --
   
    Please rework the code style according to Maven convention in our project and use `git commit --ammend`. There should be only single commit per PR and the message should refer to JIRA ID, something like:
    [SUREFIRE-12345] Support filtering of tests from Base Class (TestNG)
    and you can register at our Jira here:
    https://issues.apache.org/jira/projects/SUREFIRE


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]