[GitHub] maven-surefire pull request #157: SUREFIRE-1383 dependenciesToScan Does Not ...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven-surefire pull request #157: SUREFIRE-1383 dependenciesToScan Does Not ...

grkvlt
Github user Tibor17 commented on a diff in the pull request:

    https://github.com/apache/maven-surefire/pull/157#discussion_r125169778
 
    --- Diff: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java ---
    @@ -847,12 +847,33 @@ private DefaultScanResult scanDependencies()
             {
                 try
                 {
    +                DefaultScanResult scanResult = new DefaultScanResult( Collections.EMPTY_LIST );
    +                
    +                List<String> dependenciesToScanList = new ArrayList( Arrays.asList( getDependenciesToScan() ) );
    --- End diff --
   
    No need to create two collections with
    `List<String> dependenciesToScanList = new ArrayList( Arrays.asList( getDependenciesToScan() ) );`
    One modifiable collection can be with this code:
    `List<String> dependenciesToScanList = new ArrayList();`
    `Collections.addAll( dependenciesToScanList, getDependenciesToScan() );`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Loading...