[GitHub] maven-surefire pull request #151: Fixing build on Windows cmd.exe.

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-surefire pull request #151: Fixing build on Windows cmd.exe.

Tibor17-2
GitHub user Tunaki opened a pull request:

    https://github.com/apache/maven-surefire/pull/151

    Fixing build on Windows cmd.exe.

    Files generated with the XJC tool were using the platform encoding, that can be different from the project source encoding. In this case, the project source encoding is UTF-8, but cmd.exe can use another (e.g. code page 850). In turn, this created an error while compiling the generated sources because they contain unmappable characters for UTF-8 as expected by the compiler. The encoding that should be used by XJC is specified through the -encoding option.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Tunaki/maven-surefire master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven-surefire/pull/151.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #151
   
----
commit 92efe82cf2b1a81fb184e89146119b84e6334a25
Author: Tunaki <[hidden email]>
Date:   2017-05-28T19:16:46Z

    Fixing build on Windows cmd.exe.
   
    Files generated with the XJC tool were using the platform encoding, that can be different from the project source encoding. In this case, the project source encoding is UTF-8, but cmd.exe can use another (e.g. code page 850). In turn, this created an error while compiling the generated sources because they contain unmappable characters for UTF-8 as expected by the compiler. The encoding that should be used by XJC is specified through the -encoding option.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]