[GitHub] maven-surefire pull request #114: Parallel runner should not drop away runne...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
24 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-surefire pull request #114: Parallel runner should not drop away runne...

Tibor17-2
GitHub user Fuud opened a pull request:

    https://github.com/apache/maven-surefire/pull/114

    Parallel runner should not drop away runners that have zero children.

    JUnit does not force runners to include all child tests in Description. Therefore Parallel Runner should not throw such tests away.
    For example Spock does not report parametrized tests.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Fuud/maven-surefire master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven-surefire/pull/114.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #114
   
----
commit b99002933101eb30074b544c2848f9305503482a
Author: Fedor Bobin <[hidden email]>
Date:   2016-07-12T12:10:37Z

    Parallel runner should not drop away runners that have zero children. Childrens can be added during test (for example Spock framework does not report parametrized tests)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Tibor17-2
Github user Fuud commented on the issue:

    https://github.com/apache/maven-surefire/pull/114
 
    any updates?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Tibor Digana-2
I am sure the code had a reason but currently sorry I have not
answered since I have being preparing fixes for bugs and feature which
are really big.
I keep in mind that I should come back soon.

On 8/29/16, Fuud <[hidden email]> wrote:

> Github user Fuud commented on the issue:
>
>     https://github.com/apache/maven-surefire/pull/114
>
>     any updates?
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at [hidden email] or file a JIRA ticket
> with INFRA.
> ---
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>


--
Cheers
Tibor

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Tibor17-2
In reply to this post by Tibor17-2
Github user szpak commented on the issue:

    https://github.com/apache/maven-surefire/pull/114
 
    Is there a plan to make it merged?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-surefire pull request #114: Parallel runner should not drop away runne...

Tibor17-2
In reply to this post by Tibor17-2
Github user Tibor17 commented on a diff in the pull request:

    https://github.com/apache/maven-surefire/pull/114#discussion_r91397951
 
    --- Diff: surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/pc/ParallelComputerBuilder.java ---
    @@ -428,10 +428,10 @@ private void determineThreadCounts( long suites, long classes, long methods )
                     {
                         int children = countChildren( runner );
                         childrenCounter += children;
    -                    if ( children != 0 )
    -                    {
    +//                    if ( children != 0 )
    --- End diff --
   
    Pls remove the comments in code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Tibor17-2
In reply to this post by Tibor17-2
Github user Tibor17 commented on the issue:

    https://github.com/apache/maven-surefire/pull/114
 
    @szpak @Fuud
    Pls post the test result `mvn install -P run-its`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Tibor17-2
In reply to this post by Tibor17-2
Github user Fuud commented on the issue:

    https://github.com/apache/maven-surefire/pull/114
 
    Tests run: 701, Failures: 0, Errors: 0, Skipped: 133
   
    [INFO]
    [INFO] --- maven-checkstyle-plugin:2.13:check (checkstyle-check) @ surefire-integration-tests ---
    [INFO]
    [INFO]
    [INFO] --- maven-failsafe-plugin:2.12.4:verify (default) @ surefire-integration-tests ---
    [INFO] Failsafe report directory: /tmp/maven-surefire/surefire-integration-tests/target/failsafe-reports
    [INFO]
    [INFO] --- maven-install-plugin:2.5.2:install (default-install) @ surefire-integration-tests ---
    [INFO] Skipping artifact installation
    [INFO] ------------------------------------------------------------------------
    [INFO] Reactor Summary:
    [INFO]
    [INFO] Apache Maven Surefire ............................. SUCCESS [  2.059 s]
    [INFO] ShadeFire JUnit3 Provider ......................... SUCCESS [  0.831 s]
    [INFO] SureFire API ...................................... SUCCESS [  4.160 s]
    [INFO] SureFire Booter ................................... SUCCESS [  1.175 s]
    [INFO] Maven Surefire Test-Grouping Support .............. SUCCESS [  2.420 s]
    [INFO] SureFire Providers ................................ SUCCESS [  0.339 s]
    [INFO] Shared JUnit3 Provider Code ....................... SUCCESS [  0.522 s]
    [INFO] Shared Java 5 Provider Base ....................... SUCCESS [  0.674 s]
    [INFO] Shared JUnit4 Provider Code ....................... SUCCESS [  0.739 s]
    [INFO] Shared JUnit48 Provider Code ...................... SUCCESS [  1.103 s]
    [INFO] SureFire JUnit Runner ............................. SUCCESS [  0.542 s]
    [INFO] SureFire JUnit4 Runner ............................ SUCCESS [  0.982 s]
    [INFO] Maven Surefire Common ............................. SUCCESS [  4.611 s]
    [INFO] SureFire JUnitCore Runner ......................... SUCCESS [ 51.137 s]
    [INFO] SureFire TestNG Utils ............................. SUCCESS [  0.650 s]
    [INFO] SureFire TestNG Runner ............................ SUCCESS [  0.818 s]
    [INFO] Surefire Report Parser ............................ SUCCESS [  1.268 s]
    [INFO] Maven Surefire Plugin ............................. SUCCESS [  4.376 s]
    [INFO] Maven Failsafe Plugin ............................. SUCCESS [ 22.047 s]
    [INFO] Maven Surefire Report Plugin ...................... SUCCESS [  5.319 s]
    [INFO] Maven Surefire Integration Test Setup ............. SUCCESS [ 15.186 s]
    [INFO] Maven Surefire Integration Tests .................. SUCCESS [26:14 min]
    [INFO] ------------------------------------------------------------------------
    [INFO] BUILD SUCCESS
    [INFO] ------------------------------------------------------------------------
    [INFO] Total time: 28:16 min
    [INFO] Finished at: 2016-12-08T10:43:01+01:00
    [INFO] Final Memory: 72M/656M



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Tibor17-2
In reply to this post by Tibor17-2
Github user Fuud commented on the issue:

    https://github.com/apache/maven-surefire/pull/114
 
    Just FYI: integration tests suite does not pass on Windows.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-surefire pull request #114: Parallel runner should not drop away runne...

Tibor17-2
In reply to this post by Tibor17-2
Github user Fuud commented on a diff in the pull request:

    https://github.com/apache/maven-surefire/pull/114#discussion_r91491402
 
    --- Diff: surefire-providers/surefire-junit47/src/main/java/org/apache/maven/surefire/junitcore/pc/ParallelComputerBuilder.java ---
    @@ -428,10 +428,10 @@ private void determineThreadCounts( long suites, long classes, long methods )
                     {
                         int children = countChildren( runner );
                         childrenCounter += children;
    -                    if ( children != 0 )
    -                    {
    +//                    if ( children != 0 )
    --- End diff --
   
    Fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-surefire pull request #114: Parallel runner should not drop away runne...

Tibor17-2
In reply to this post by Tibor17-2
Github user Tibor17 commented on a diff in the pull request:

    https://github.com/apache/maven-surefire/pull/114#discussion_r91498487
 
    --- Diff: surefire-providers/surefire-junit47/src/test/java/org/apache/maven/surefire/junitcore/pc/ParallelComputerBuilderTest.java ---
    @@ -32,15 +32,13 @@
     import org.junit.runner.JUnitCore;
     import org.junit.runner.Result;
     import org.junit.runner.RunWith;
    +import org.junit.runner.notification.RunListener;
    +import org.junit.runner.notification.RunNotifier;
    +import org.junit.runners.ParentRunner;
     import org.junit.runners.Suite;
    +import org.junit.runners.model.InitializationError;
     
    -import java.util.ArrayList;
    --- End diff --
   
    Pls do not use wildcard `import java.util.*;` and revert this section back.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-surefire pull request #114: Parallel runner should not drop away runne...

Tibor17-2
In reply to this post by Tibor17-2
Github user Fuud commented on a diff in the pull request:

    https://github.com/apache/maven-surefire/pull/114#discussion_r91513593
 
    --- Diff: surefire-providers/surefire-junit47/src/test/java/org/apache/maven/surefire/junitcore/pc/ParallelComputerBuilderTest.java ---
    @@ -32,15 +32,13 @@
     import org.junit.runner.JUnitCore;
     import org.junit.runner.Result;
     import org.junit.runner.RunWith;
    +import org.junit.runner.notification.RunListener;
    +import org.junit.runner.notification.RunNotifier;
    +import org.junit.runners.ParentRunner;
     import org.junit.runners.Suite;
    +import org.junit.runners.model.InitializationError;
     
    -import java.util.ArrayList;
    --- End diff --
   
    Fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Tibor17-2
In reply to this post by Tibor17-2
Github user Tibor17 commented on the issue:

    https://github.com/apache/maven-surefire/pull/114
 
    @Fuud
    You mean this PR does not pass on Win or the master origin?
    Please see our Jenkins on Windows. It passed https://builds.apache.org/job/maven-surefire-windows


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Tibor17-2
In reply to this post by Tibor17-2
Github user Fuud commented on the issue:

    https://github.com/apache/maven-surefire/pull/114
 
    "Master Origin" integration tests suite does not pass on my Windows box.
     
    ```
    Results :
   
    Failed tests:   properNewlinesAndEncodingWithDifferentEncoding(org.apache.maven.surefire.its.ConsoleOutputIT): Did not find ex                    pected message in log
      properNewlinesAndEncodingWithDefaultEncodings(org.apache.maven.surefire.its.ConsoleOutputIT): Did not find expected message                     in log
      properNewlinesAndEncodingWithoutFork(org.apache.maven.surefire.its.ConsoleOutputIT): Did not find expected message in log
   
    Tests in error:
      testUmlautIsolatedClassLoader(org.apache.maven.surefire.its.UmlautDirIT): Exit code was non-zero: 1; command line and log =                     (..)
      testUmlaut(org.apache.maven.surefire.its.UmlautDirIT): Exit code was non-zero: 1; command line and log = (..)
    ```
   
    But this PR does nothing with encodings, I think we can ignore this errors now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Tibor17-2
In reply to this post by Tibor17-2
Github user szpak commented on the issue:

    https://github.com/apache/maven-surefire/pull/114
 
    @Tibor17 Is there something else that prevent that PR from being merged?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Tibor17-2
In reply to this post by Tibor17-2
Github user Tibor17 commented on the issue:

    https://github.com/apache/maven-surefire/pull/114
 
    I have this PR in my mind, do not worry. The problem is that we may cleanup
    our codeline and I do not want to loose your path in master after we
    revert. Pls wait few days.
   
    On Sun, Jan 8, 2017 at 12:33 AM, Marcin Zajączkowski <
    [hidden email]> wrote:
   
    > @Tibor17 <https://github.com/Tibor17> Is there something else that
    > prevent that PR from being merged?
    >
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/maven-surefire/pull/114#issuecomment-271117788>,
    > or mute the thread
    > <https://github.com/notifications/unsubscribe-auth/AA_yR6sSEkJR4g8Q_w-jFJyV_Guxut6Yks5rQCCygaJpZM4JKVF6>
    > .
    >
   
   
   
    --
    Cheers
    Tibor



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Tibor17-2
In reply to this post by Tibor17-2
Github user Fuud commented on the issue:

    https://github.com/apache/maven-surefire/pull/114
 
    Any updates?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Tibor17-2
In reply to this post by Tibor17-2
Github user Tibor17 commented on the issue:

    https://github.com/apache/maven-surefire/pull/114
 
    @Fuud
    We had an internal collision and I tried to recover from this and reverted 11 commits and now trying to fix them and add the last jira fix and then cut the release version. Please try to be patient. We want to continue on this project.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Tibor17-2
In reply to this post by Tibor17-2
Github user huzaus commented on the issue:

    https://github.com/apache/maven-surefire/pull/114
 
    Any updates?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Tibor Digana
I will check your PR, but it is not about pushing to master. The more
important is what we do. We cannot make release yet, but if we could I
would release your PR.
Currently we try to release Maven 3.5.0 and Surefire has 1200 tests and a
lot of them fail with new Maven. So our team cooperates with me and we are
fixing Surefire and Maven running on platform FreeBSD and we make hacks and
talk on IRC.
Pls be patient. We are working every day to release both maven and
surefire. For instance we started at 6pm and finished at 11:45 pm.

On Wed, Feb 15, 2017 at 3:29 PM, Tibor17-2 [via Maven] <
[hidden email]> wrote:

> Github user huzaus commented on the issue:
>
>     https://github.com/apache/maven-surefire/pull/114
>
>     Any updates?
>
>
> ---
> If your project is set up for it, you can reply to this email and have
> your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working,
> please
> contact infrastructure at [hidden email]
> <http:///user/SendEmail.jtp?type=node&node=5898753&i=0> or file a JIRA
> ticket
> with INFRA.
> ---
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> <http:///user/SendEmail.jtp?type=node&node=5898753&i=1>
> For additional commands, e-mail: [hidden email]
> <http:///user/SendEmail.jtp?type=node&node=5898753&i=2>
>
>
>
> ------------------------------
> If you reply to this email, your message will be added to the discussion
> below:
> http://maven.40175.n5.nabble.com/GitHub-maven-surefire-
> pull-request-114-Parallel-runner-should-not-drop-away-
> runne-tp5875060p5898753.html
> To start a new topic under Maven Developers, email
> [hidden email]
> To unsubscribe from Maven Developers, click here
> <
> .
> NAML
> <
http://maven.40175.n5.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml>
>




--
View this message in context: http://maven.40175.n5.nabble.com/Re-GitHub-maven-surefire-issue-114-Parallel-runner-should-not-drop-away-runners-that-tp5898774.html
Sent from the Maven Developers mailing list archive at Nabble.com.
Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-surefire issue #114: Parallel runner should not drop away runners that...

Tibor17-2
In reply to this post by Tibor17-2
Github user Fuud commented on the issue:

    https://github.com/apache/maven-surefire/pull/114
 
    any updates?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

12