[GitHub] [maven-surefire] klevis opened a new pull request #261: SUREFIRE-1744 - enable system-out for successful tests as well

classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-surefire] klevis opened a new pull request #261: SUREFIRE-1744 - enable system-out for successful tests as well

GitBox
klevis opened a new pull request #261: SUREFIRE-1744 - enable system-out for successful tests as well
URL: https://github.com/apache/maven-surefire/pull/261
 
 
   Original Tickete at : https://issues.apache.org/jira/projects/SUREFIRE/issues/SUREFIRE-1744?filter=allopenissues

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-surefire] Tibor17 commented on issue #261: SUREFIRE-1744 - enable system-out for successful tests as well

GitBox
Tibor17 commented on issue #261: SUREFIRE-1744 - enable system-out for successful tests as well
URL: https://github.com/apache/maven-surefire/pull/261#issuecomment-572974894
 
 
   @klevis
   So what is the change in real?
   Would you squash the commits to one in order to see the diff better?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-surefire] klevis commented on issue #261: SUREFIRE-1744 - enable system-out for successful tests as well

GitBox
In reply to this post by GitBox
klevis commented on issue #261: SUREFIRE-1744 - enable system-out for successful tests as well
URL: https://github.com/apache/maven-surefire/pull/261#issuecomment-572977125
 
 
   @Tibor17 commits are squashed now, the change is really tiny...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-surefire] Tibor17 commented on issue #261: SUREFIRE-1744 - enable system-out for successful tests as well

GitBox
In reply to this post by GitBox
Tibor17 commented on issue #261: SUREFIRE-1744 - enable system-out for successful tests as well
URL: https://github.com/apache/maven-surefire/pull/261#issuecomment-572982205
 
 
   How is it with rerun in the method `serializeTestClassWithRerun`? Do we need to do the same there and can we cover the std-out with rerun in some integration test?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-surefire] Tibor17 commented on issue #261: SUREFIRE-1744 - enable system-out for successful tests as well

GitBox
In reply to this post by GitBox
Tibor17 commented on issue #261: SUREFIRE-1744 - enable system-out for successful tests as well
URL: https://github.com/apache/maven-surefire/pull/261#issuecomment-572983344
 
 
   @klevis
   The CI for PRs is not executed. Can you make an extra commit rollbacking the https://github.com/apache/maven-surefire/commit/993214d2ba4bfe7952ecc62af66eaa77a8d381d1? Thx

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-surefire] klevis commented on issue #261: SUREFIRE-1744 - enable system-out for successful tests as well

GitBox
In reply to this post by GitBox
klevis commented on issue #261: SUREFIRE-1744 - enable system-out for successful tests as well
URL: https://github.com/apache/maven-surefire/pull/261#issuecomment-573009579
 
 
   @Tibor17 about serializeTestClassWithRerun is quite unclear the right place this might needed..
   Anyway looking at the code might be nessesary only for the success case and flaky
   `case success:
                   for ( WrappedReportEntry methodEntry : methodEntries )
                   {
                       if ( methodEntry.getReportEntryType() == SUCCESS )
                       {
                           startTestElement( ppw, methodEntry );
                           ppw.endElement();
                       }
                   }`
   `case flake:
                   WrappedReportEntry successful = null;
                   // Get the run time of the first successful run
                   for ( WrappedReportEntry singleRunEntry : methodEntries )
                   {
                       if ( singleRunEntry.getReportEntryType() == SUCCESS )
                       {
                           successful = singleRunEntry;
                           break;
                       }
                   }
                   WrappedReportEntry firstOrSuccessful = successful == null ? methodEntries.get( 0 ) : successful;
                   startTestElement( ppw, firstOrSuccessful );
                   for ( WrappedReportEntry singleRunEntry : methodEntries )
                   {
                       if ( singleRunEntry.getReportEntryType() != SUCCESS )
                       {
                           getTestProblems( fw, ppw, singleRunEntry, trimStackTrace, outputStream,
                                   singleRunEntry.getReportEntryType().getFlakyXmlTag(), true );
                       }
                   }
                   ppw.endElement();
                   break;`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-surefire] klevis edited a comment on issue #261: SUREFIRE-1744 - enable system-out for successful tests as well

GitBox
In reply to this post by GitBox
klevis edited a comment on issue #261: SUREFIRE-1744 - enable system-out for successful tests as well
URL: https://github.com/apache/maven-surefire/pull/261#issuecomment-573009579
 
 
   @Tibor17 about serializeTestClassWithRerun is quite unclear the right place this might needed..
   Anyway looking at the code might be nessesary only for the success case and flaky
   ```
   case success:
                   for ( WrappedReportEntry methodEntry : methodEntries )
                   {
                       if ( methodEntry.getReportEntryType() == SUCCESS )
                       {
                           startTestElement( ppw, methodEntry );
                           ppw.endElement();
                       }
                   }
   ```
   
   ```
   case flake:
                   WrappedReportEntry successful = null;
                   // Get the run time of the first successful run
                   for ( WrappedReportEntry singleRunEntry : methodEntries )
                   {
                       if ( singleRunEntry.getReportEntryType() == SUCCESS )
                       {
                           successful = singleRunEntry;
                           break;
                       }
                   }
                   WrappedReportEntry firstOrSuccessful = successful == null ? methodEntries.get( 0 ) : successful;
                   startTestElement( ppw, firstOrSuccessful );
                   for ( WrappedReportEntry singleRunEntry : methodEntries )
                   {
                       if ( singleRunEntry.getReportEntryType() != SUCCESS )
                       {
                           getTestProblems( fw, ppw, singleRunEntry, trimStackTrace, outputStream,
                                   singleRunEntry.getReportEntryType().getFlakyXmlTag(), true );
                       }
                   }
                   ppw.endElement();
                   break;
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-surefire] Tibor17 commented on issue #261: SUREFIRE-1744 - enable system-out for successful tests as well

GitBox
In reply to this post by GitBox
Tibor17 commented on issue #261: SUREFIRE-1744 - enable system-out for successful tests as well
URL: https://github.com/apache/maven-surefire/pull/261#issuecomment-573275070
 
 
   @klevis
   Pls run the build locally. The module `surefire-logger-api` failed and you have see the rootcause in the dump file in the directory `target/surefire-reports`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-surefire] Tibor17 edited a comment on issue #261: SUREFIRE-1744 - enable system-out for successful tests as well

GitBox
In reply to this post by GitBox
Tibor17 edited a comment on issue #261: SUREFIRE-1744 - enable system-out for successful tests as well
URL: https://github.com/apache/maven-surefire/pull/261#issuecomment-573275070
 
 
   @klevis
   Pls run the build locally. The module `surefire-logger-api` failed and you have to see the root cause in the dump file in the directory `target/surefire-reports` of the particular module.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-surefire] klevis commented on issue #261: SUREFIRE-1744 - enable system-out for successful tests as well

GitBox
In reply to this post by GitBox
klevis commented on issue #261: SUREFIRE-1744 - enable system-out for successful tests as well
URL: https://github.com/apache/maven-surefire/pull/261#issuecomment-573687111
 
 
   @Tibor17 For what I can see it seems fail is related to ubuntu(I have to start a virtual machine for that unless there is a way to get those files), for windows and mac is passing or is it general failing?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-surefire] Tibor17 commented on issue #261: SUREFIRE-1744 - enable system-out for successful tests as well

GitBox
In reply to this post by GitBox
Tibor17 commented on issue #261: SUREFIRE-1744 - enable system-out for successful tests as well
URL: https://github.com/apache/maven-surefire/pull/261#issuecomment-573854809
 
 
   @klevis
   Hi, I know it is related to Ubuntu. I have noticed the same in the pullrequest #240 , see my last 7 commits where I have investigated this issue. The problem is also with the docker and it seems that the lenght of a value in env var `CLASSPATH` or any other is limited to cca 1K. The reason why the tests do not fail with the old version `3.0.0-M3` is the number of libraries in classpath. We introduced some bug in `M4` where Sisu container and another Maven artifacts appear in surefire provider classpath too. This is bad and this prolonged the the value in the env var. So I see this has to be fixed in prior of all other work and still use M3 for `maven-surefire-plugin` in our POMs. Some debugging has to be done and a fix. This broke our progress but it has to be fixed because the same may happen to our users too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-surefire] Tibor17 edited a comment on issue #261: SUREFIRE-1744 - enable system-out for successful tests as well

GitBox
In reply to this post by GitBox
Tibor17 edited a comment on issue #261: SUREFIRE-1744 - enable system-out for successful tests as well
URL: https://github.com/apache/maven-surefire/pull/261#issuecomment-573854809
 
 
   @klevis
   Hi, I know it is related to Ubuntu. I have noticed the same in the pullrequest #240 , see my last 7 commits where I have investigated this issue. The problem is also with the docker and it seems that the lenght of a value in env var `CLASSPATH` or any other is limited to cca 1K. The reason why the tests do not fail with the old version `3.0.0-M3` is the number of libraries in classpath. We introduced some bug in `M4` where Sisu container and another Maven artifacts appear in surefire provider classpath too. This is bad and this prolonged the the value in the env var. So I see this has to be fixed in prior to all other work and still use M3 for `maven-surefire-plugin` in our POMs. Some debugging has to be done and a fix. This broke our progress but it has to be fixed because the same may happen to our users too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services