[GitHub] maven-surefire issue #157: SUREFIRE-1383 dependenciesToScan Does Not Leverag...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-surefire issue #157: SUREFIRE-1383 dependenciesToScan Does Not Leverag...

Tibor17-2
Github user owenfarrell commented on the issue:

    https://github.com/apache/maven-surefire/pull/157
 
    I don't think that logic would work for my scenario.
   
    For example:
   
    1. Create multi-module project with a test runner JAR (a la `org.apache.maven.surefire:surefire-1383:1.0-SNAPSHOT`)
    2. Recursively run the `install` goal over the multi-module project
    3. Modify the test runner module (`org.apache.maven.surefire:surefire-1383-runner:1.0-SNAPSHOT`)
    4. Run the `test` goal over the multi-module project
   
    According to your logic, Surefire would prefer the already-installed artifact, effectively ignoring those changes made in step 3. That would put us right back where we started.
   
    Using my logic, Surefire would prefer the working copy changes and execute accordingly. Since the existing `DependencyScanner` doesn't support classifiers as written, I don't think my approach is introducing any new limitations there.
   
    `DependencyScanner.java:114`
    ```
    String[] groupArtifact = groups.split( ":" );
    if ( groupArtifact.length != 2 )
    {
        throw new IllegalArgumentException(...);
    }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]