[GitHub] [maven-surefire] dejan2609 edited a comment on issue #233: [SUREFIRE-1494] default provider for JUnit4 integration tests is changed (from 'surefire-junit4' to 'surefire-junit47')

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-surefire] dejan2609 edited a comment on issue #233: [SUREFIRE-1494] default provider for JUnit4 integration tests is changed (from 'surefire-junit4' to 'surefire-junit47')

GitBox
dejan2609 edited a comment on issue #233: [SUREFIRE-1494] default provider for JUnit4 integration tests is changed (from 'surefire-junit4' to 'surefire-junit47')
URL: https://github.com/apache/maven-surefire/pull/233#issuecomment-527205154
 
 
   @Tibor17
   
   1. Ok, I need some explanation for this and hence I picked a Java class and corresponding pom.xml (i.e. test methods and their corresponding surefire-junit provider version values):
   ```
   maven-surefire\surefire-its\src\test\resources\junit44-dep\pom.xml
   maven-surefire\surefire-its\src\test\java\org\apache\maven\surefire\its\JUnitDepIT.java
   ```
   
   | java test method | surefire junit version |
   | --- | --- |
   | testJUnit44Dep() | surefire-junit4 |
   | testJUnit44DepWithSneaky38 | _activates maven profile **provided381**_|
   | testJUnit47Dep() | surefire-junit4 |
   | testJUnit48Dep | surefire-junit47 |
   
   Now, what I did so far is to simply switch testJUnit44Dep() surefire junit provider value from `surefire-junit4` to `surefire-junit47` (too good to be true, I assume).
   
   @Tibor17
   Addendum / additional questions:
   * best bet here is that surefire junit version has to be changed for both ***testJUnit44Dep()*** and ***testJUnit47Dep()*** methods, right ?
   * testJUnit44DepWithSneaky38() method is a kind of mystery; I assume is should be either left as-is **or** removed ?
   
   
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services