[GitHub] [maven-surefire] cowwoc opened a new pull request #299: Added integration test for surefire-1629

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-surefire] cowwoc opened a new pull request #299: Added integration test for surefire-1629

GitBox

cowwoc opened a new pull request #299:
URL: https://github.com/apache/maven-surefire/pull/299


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-surefire] cowwoc commented on pull request #299: Added integration test for surefire-1629

GitBox

cowwoc commented on pull request #299:
URL: https://github.com/apache/maven-surefire/pull/299#issuecomment-631878071


   The interesting bit is if you remove module1, module2 from the testcase (convert it to a single-module project) then Surefire returns the compiler error to the console without crashing. The presence of modules causes it to crash for some reason.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-surefire] Tibor17 commented on pull request #299: Added integration test for surefire-1629

GitBox
In reply to this post by GitBox

Tibor17 commented on pull request #299:
URL: https://github.com/apache/maven-surefire/pull/299#issuecomment-633021818


   I am waiting for our build process to complete. Then i will cherry pick your last three commits and i will execute it localy. Let's see what will happen afterwards...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-surefire] Tibor17 commented on pull request #299: Added integration test for surefire-1629

GitBox
In reply to this post by GitBox

Tibor17 commented on pull request #299:
URL: https://github.com/apache/maven-surefire/pull/299#issuecomment-633306815


   @cowwoc
   I have the result after running the test on our fix in #293 .
   The problem is that your package is named `java`. You should not create such of folder `module2/src/test/java/java/testcase` and create e.g. `module2/src/test/java/testcase`.
   This is the error found in the dump:
   ```
   Error occurred during initialization of boot layer
   java.lang.LayerInstantiationException: Class loader (instance of):
   'app' tried to define prohibited package name: java.testcase
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-surefire] cowwoc commented on pull request #299: Added integration test for surefire-1629

GitBox
In reply to this post by GitBox

cowwoc commented on pull request #299:
URL: https://github.com/apache/maven-surefire/pull/299#issuecomment-633385625


   @Tibor17 This is intentional. I am expecting to get the same error message in forked-mode as in non-forked mode. Meaning, Surefire should not crash/dump. It should output the compiler error as it does in non-forked mode.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]