[GitHub] [maven-surefire] Tibor17 commented on issue #256: repackaged external artifacts (utilities) with no duplicates and use in extensions-api with Commandline

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-surefire] Tibor17 commented on issue #256: repackaged external artifacts (utilities) with no duplicates and use in extensions-api with Commandline

GitBox
Tibor17 commented on issue #256: repackaged external artifacts (utilities) with no duplicates and use in extensions-api with Commandline
URL: https://github.com/apache/maven-surefire/pull/256#issuecomment-561068753
 
 
   @jon-bell
   How should be the std-out stream drained with all bytes from the process pipe if the process has finished? After the process was finished we have to close the streams but we also should read all bytes. Is it safe enough to rely on value `-1` returned from `InputStream#read()` of the open stream std-out? Wouldn't the method be still waiting?
   Pls see my last commit https://github.com/apache/maven-surefire/pull/256/commits/ccb823287d75e786e525cc43ebf06ddc62ec2071
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services