[GitHub] [maven-site] slawekjaranowski opened a new pull request #224: javadoc reproducible build requirement

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-site] slawekjaranowski opened a new pull request #224: javadoc reproducible build requirement

GitBox

slawekjaranowski opened a new pull request #224:
URL: https://github.com/apache/maven-site/pull/224


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-site] michael-o commented on a change in pull request #224: javadoc reproducible build requirement

GitBox

michael-o commented on a change in pull request #224:
URL: https://github.com/apache/maven-site/pull/224#discussion_r550916734



##########
File path: content/apt/guides/mini/guide-reproducible-builds.apt
##########
@@ -47,6 +48,9 @@ Configuring for Reproducible Builds
      <project.build.outputTimestamp>2019-10-02T08:04:00Z</project.build.outputTimestamp>
    </properties>
 +--------+
+
+ [[3]] Configure <<<maven-javadoc-plugin>>> with option <<<notimestamp>>> set to <<<true>>> in order to avoid timestamp in generated files.

Review comment:
       Maybe we should consider making this default to have it out of the box.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-site] slawekjaranowski commented on a change in pull request #224: javadoc reproducible build requirement

GitBox
In reply to this post by GitBox

slawekjaranowski commented on a change in pull request #224:
URL: https://github.com/apache/maven-site/pull/224#discussion_r550917474



##########
File path: content/apt/guides/mini/guide-reproducible-builds.apt
##########
@@ -47,6 +48,9 @@ Configuring for Reproducible Builds
      <project.build.outputTimestamp>2019-10-02T08:04:00Z</project.build.outputTimestamp>
    </properties>
 +--------+
+
+ [[3]] Configure <<<maven-javadoc-plugin>>> with option <<<notimestamp>>> set to <<<true>>> in order to avoid timestamp in generated files.

Review comment:
       Such change will be easy from code perspective.
   So please. take decision about change default value - but until change will be release info about it will be appreciated.
   I spend an hour looking why javadoc build is not reproducible.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-site] michael-o commented on a change in pull request #224: javadoc reproducible build requirement

GitBox
In reply to this post by GitBox

michael-o commented on a change in pull request #224:
URL: https://github.com/apache/maven-site/pull/224#discussion_r550917635



##########
File path: content/apt/guides/mini/guide-reproducible-builds.apt
##########
@@ -47,6 +48,9 @@ Configuring for Reproducible Builds
      <project.build.outputTimestamp>2019-10-02T08:04:00Z</project.build.outputTimestamp>
    </properties>
 +--------+
+
+ [[3]] Configure <<<maven-javadoc-plugin>>> with option <<<notimestamp>>> set to <<<true>>> in order to avoid timestamp in generated files.

Review comment:
       Let's merge this and file and issue with MJAVADOC about that. I see litlte benefit in the timestamp.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]