[GitHub] [maven-site-plugin] olamy opened a new pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x

classic Classic list List threaded Threaded
19 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-site-plugin] olamy opened a new pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x

GitBox

olamy opened a new pull request #21:
URL: https://github.com/apache/maven-site-plugin/pull/21


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-site-plugin] mthmulders commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x

GitBox

mthmulders commented on a change in pull request #21:
URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r425085702



##########
File path: pom.xml
##########
@@ -211,6 +211,9 @@ under the License.
     <projectInfoReportsPluginVersion>2.7</projectInfoReportsPluginVersion>
     <surefirePluginVersion>2.22.1</surefirePluginVersion>
     <project.build.outputTimestamp>2020-03-06T20:49:49Z</project.build.outputTimestamp>
+    <maven.compiler.target>1.8</maven.compiler.target>
+    <maven.compiler.source>1.8</maven.compiler.source>
+    <jettyVersion>9.4.12.v20180830</jettyVersion>

Review comment:
       `jettyVersion` is defined twice (here and in line 203)?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-site-plugin] elharo commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x

GitBox
In reply to this post by GitBox

elharo commented on a change in pull request #21:
URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r425124986



##########
File path: Jenkinsfile
##########
@@ -17,4 +17,4 @@
  * under the License.
  */
 
-asfMavenTlpPlgnBuild(jdk:['7','8','11','12'], maven:['3.0.x', '3.2.x', '3.3.x', '3.5.x'])
+asfMavenTlpPlgnBuild(jdk:['8','11','12'], maven:['3.2.x', '3.3.x', '3.5.x'])

Review comment:
       3.1 seems more important than 3.2
   and perhaps 3.6?

##########
File path: pom.xml
##########
@@ -196,11 +196,11 @@ under the License.
 
   <properties>
     <mavenVersion>3.0</mavenVersion>
-    <javaVersion>7</javaVersion>
+    <javaVersion>8</javaVersion>

Review comment:
       This change should probably be made, if at all, in its own PR, not as a driveby of a minor version dependency update




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-site-plugin] slachiewicz commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x

GitBox
In reply to this post by GitBox

slachiewicz commented on a change in pull request #21:
URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r425130232



##########
File path: Jenkinsfile
##########
@@ -17,4 +17,4 @@
  * under the License.
  */
 
-asfMavenTlpPlgnBuild(jdk:['7','8','11','12'], maven:['3.0.x', '3.2.x', '3.3.x', '3.5.x'])
+asfMavenTlpPlgnBuild(jdk:['8','11','12'], maven:['3.2.x', '3.3.x', '3.5.x'])

Review comment:
       Maybe we can define asfMavenTlpPlgnBuild8() function - more and more plugins will move to next java over time. Then we can controll centrally on what mvn versions we run tests.
   Cases to consider - new minimum mvn version, and java 8




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-site-plugin] olamy commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x

GitBox
In reply to this post by GitBox

olamy commented on a change in pull request #21:
URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r425567345



##########
File path: pom.xml
##########
@@ -211,6 +211,9 @@ under the License.
     <projectInfoReportsPluginVersion>2.7</projectInfoReportsPluginVersion>
     <surefirePluginVersion>2.22.1</surefirePluginVersion>
     <project.build.outputTimestamp>2020-03-06T20:49:49Z</project.build.outputTimestamp>
+    <maven.compiler.target>1.8</maven.compiler.target>
+    <maven.compiler.source>1.8</maven.compiler.source>
+    <jettyVersion>9.4.12.v20180830</jettyVersion>

Review comment:
       oops thanks




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-site-plugin] olamy commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x

GitBox
In reply to this post by GitBox

olamy commented on a change in pull request #21:
URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r425568135



##########
File path: pom.xml
##########
@@ -196,11 +196,11 @@ under the License.
 
   <properties>
     <mavenVersion>3.0</mavenVersion>
-    <javaVersion>7</javaVersion>
+    <javaVersion>8</javaVersion>

Review comment:
       we need 8 for the change so let's do it all together
   except having a sort of bureaucratic own PR I cannot see the technical need :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-site-plugin] rfscholte commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x

GitBox
In reply to this post by GitBox

rfscholte commented on a change in pull request #21:
URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r425670278



##########
File path: Jenkinsfile
##########
@@ -17,4 +17,4 @@
  * under the License.
  */
 
-asfMavenTlpPlgnBuild(jdk:['7','8','11','12'], maven:['3.0.x', '3.2.x', '3.3.x', '3.5.x'])
+asfMavenTlpPlgnBuild(jdk:['8','11','12'], maven:['3.2.x', '3.3.x', '3.5.x'])

Review comment:
       let's not make a separate method. My preferred solution would be to specify `[8..maxJdk]`, where `maxJdk` is an available constant in the script, but Groovy started to support this in the recent Groovy 3, not sure if Jenkins is already using this. Another solution would be `minJdk:'8'`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-site-plugin] olamy commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x

GitBox
In reply to this post by GitBox

olamy commented on a change in pull request #21:
URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r426105614



##########
File path: Jenkinsfile
##########
@@ -17,4 +17,4 @@
  * under the License.
  */
 
-asfMavenTlpPlgnBuild(jdk:['7','8','11','12'], maven:['3.0.x', '3.2.x', '3.3.x', '3.5.x'])
+asfMavenTlpPlgnBuild(jdk:['8','11','12'], maven:['3.2.x', '3.3.x', '3.5.x'])

Review comment:
       I changed it to `maven:['3.1.x', '3.3.x', '3.5.x', '3.6.x']` but looks to be a more generic issue than only this plugin/pr? :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-site-plugin] michael-o commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x implicit java8 requirement now

GitBox
In reply to this post by GitBox

michael-o commented on a change in pull request #21:
URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427583663



##########
File path: pom.xml
##########
@@ -196,11 +196,11 @@ under the License.
 
   <properties>
     <mavenVersion>3.0</mavenVersion>
-    <javaVersion>7</javaVersion>
+    <javaVersion>8</javaVersion>

Review comment:
       @olamy I am the bureaucratic person. This needs to be changelog visible.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-site-plugin] michael-o commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x implicit java8 requirement now

GitBox
In reply to this post by GitBox

michael-o commented on a change in pull request #21:
URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427584057



##########
File path: pom.xml
##########
@@ -211,6 +211,8 @@ under the License.
     <projectInfoReportsPluginVersion>2.7</projectInfoReportsPluginVersion>
     <surefirePluginVersion>2.22.1</surefirePluginVersion>
     <project.build.outputTimestamp>2020-03-06T20:49:49Z</project.build.outputTimestamp>
+    <maven.compiler.target>1.8</maven.compiler.target>

Review comment:
       I am confused. We have `javaVersion`. Why did you set these too?

##########
File path: pom.xml
##########
@@ -473,28 +474,28 @@ under the License.
     <dependency>
       <groupId>org.slf4j</groupId>
       <artifactId>slf4j-api</artifactId>
-      <version>1.5.3</version>
+      <version>1.7.29</version>
       <scope>test</scope>
     </dependency>
 
     <dependency>
       <groupId>org.slf4j</groupId>
       <artifactId>slf4j-simple</artifactId>
-      <version>1.5.3</version>
+      <version>1.7.29</version>
       <scope>test</scope>
     </dependency>
 
     <dependency>
       <groupId>org.slf4j</groupId>
       <artifactId>jcl-over-slf4j</artifactId>
-      <version>1.6.1</version>
+      <version>1.7.29</version>
       <scope>test</scope>
     </dependency>
 
     <dependency>
       <groupId>org.apache.commons</groupId>
       <artifactId>commons-lang3</artifactId>
-      <version>3.4</version>
+      <version>3.5</version>

Review comment:
       Seems unrelated.

##########
File path: pom.xml
##########
@@ -473,28 +474,28 @@ under the License.
     <dependency>
       <groupId>org.slf4j</groupId>
       <artifactId>slf4j-api</artifactId>
-      <version>1.5.3</version>
+      <version>1.7.29</version>
       <scope>test</scope>
     </dependency>
 
     <dependency>
       <groupId>org.slf4j</groupId>
       <artifactId>slf4j-simple</artifactId>
-      <version>1.5.3</version>
+      <version>1.7.29</version>
       <scope>test</scope>
     </dependency>
 
     <dependency>
       <groupId>org.slf4j</groupId>
       <artifactId>jcl-over-slf4j</artifactId>
-      <version>1.6.1</version>
+      <version>1.7.29</version>

Review comment:
       This should be a property and match the version on Maven core.

##########
File path: pom.xml
##########
@@ -623,6 +624,7 @@ under the License.
                 <maven.compiler.source>${maven.compiler.source}</maven.compiler.source>
                 <maven.compiler.target>${maven.compiler.target}</maven.compiler.target>
               </properties>
+              <javaHome>${java.home}</javaHome>

Review comment:
       Why is that necessary?

##########
File path: src/it/projects/new-configuration/pom.xml
##########
@@ -76,7 +76,7 @@ under the License.
             <plugin>
               <groupId>org.apache.maven.plugins</groupId>
               <artifactId>maven-javadoc-plugin</artifactId>
-              <version>2.7</version>
+              <version>@javadocPluginVersion@</version>

Review comment:
       How are these related?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-site-plugin] olamy commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x implicit java8 requirement now

GitBox
In reply to this post by GitBox

olamy commented on a change in pull request #21:
URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427587877



##########
File path: pom.xml
##########
@@ -196,11 +196,11 @@ under the License.
 
   <properties>
     <mavenVersion>3.0</mavenVersion>
-    <javaVersion>7</javaVersion>
+    <javaVersion>8</javaVersion>

Review comment:
       it's ALREADY there https://issues.apache.org/jira/browse/MSITE-828 and the git comment will clearly says that




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-site-plugin] olamy commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x implicit java8 requirement now

GitBox
In reply to this post by GitBox

olamy commented on a change in pull request #21:
URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427588408



##########
File path: src/it/projects/new-configuration/pom.xml
##########
@@ -76,7 +76,7 @@ under the License.
             <plugin>
               <groupId>org.apache.maven.plugins</groupId>
               <artifactId>maven-javadoc-plugin</artifactId>
-              <version>2.7</version>
+              <version>@javadocPluginVersion@</version>

Review comment:
       I use java11 so the IT tests was failing for locally because of this




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-site-plugin] michael-o commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x implicit java8 requirement now

GitBox
In reply to this post by GitBox

michael-o commented on a change in pull request #21:
URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427591526



##########
File path: pom.xml
##########
@@ -196,11 +196,11 @@ under the License.
 
   <properties>
     <mavenVersion>3.0</mavenVersion>
-    <javaVersion>7</javaVersion>
+    <javaVersion>8</javaVersion>

Review comment:
       Good, let's re-merge MSITE-828 first.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-site-plugin] olamy commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x implicit java8 requirement now

GitBox
In reply to this post by GitBox

olamy commented on a change in pull request #21:
URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427591510



##########
File path: pom.xml
##########
@@ -473,28 +474,28 @@ under the License.
     <dependency>
       <groupId>org.slf4j</groupId>
       <artifactId>slf4j-api</artifactId>
-      <version>1.5.3</version>
+      <version>1.7.29</version>
       <scope>test</scope>
     </dependency>
 
     <dependency>
       <groupId>org.slf4j</groupId>
       <artifactId>slf4j-simple</artifactId>
-      <version>1.5.3</version>
+      <version>1.7.29</version>
       <scope>test</scope>
     </dependency>
 
     <dependency>
       <groupId>org.slf4j</groupId>
       <artifactId>jcl-over-slf4j</artifactId>
-      <version>1.6.1</version>
+      <version>1.7.29</version>

Review comment:
       see slf4j version in core  https://github.com/apache/maven/blob/5397fb66e7ea45dd756cd48c18f7dc476e2a06a6/pom.xml#L69




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-site-plugin] michael-o commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x implicit java8 requirement now

GitBox
In reply to this post by GitBox

michael-o commented on a change in pull request #21:
URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427591833



##########
File path: src/it/projects/new-configuration/pom.xml
##########
@@ -76,7 +76,7 @@ under the License.
             <plugin>
               <groupId>org.apache.maven.plugins</groupId>
               <artifactId>maven-javadoc-plugin</artifactId>
-              <version>2.7</version>
+              <version>@javadocPluginVersion@</version>

Review comment:
       Makes sense, but should be a separate PR because it is logically not related.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-site-plugin] olamy commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x implicit java8 requirement now

GitBox
In reply to this post by GitBox

olamy commented on a change in pull request #21:
URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427588408



##########
File path: src/it/projects/new-configuration/pom.xml
##########
@@ -76,7 +76,7 @@ under the License.
             <plugin>
               <groupId>org.apache.maven.plugins</groupId>
               <artifactId>maven-javadoc-plugin</artifactId>
-              <version>2.7</version>
+              <version>@javadocPluginVersion@</version>

Review comment:
       I use java11 so the IT tests were failing for locally because of this and need more recent java version




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-site-plugin] olamy commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x implicit java8 requirement now

GitBox
In reply to this post by GitBox

olamy commented on a change in pull request #21:
URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427595053



##########
File path: pom.xml
##########
@@ -473,28 +474,28 @@ under the License.
     <dependency>
       <groupId>org.slf4j</groupId>
       <artifactId>slf4j-api</artifactId>
-      <version>1.5.3</version>
+      <version>1.7.29</version>
       <scope>test</scope>
     </dependency>
 
     <dependency>
       <groupId>org.slf4j</groupId>
       <artifactId>slf4j-simple</artifactId>
-      <version>1.5.3</version>
+      <version>1.7.29</version>
       <scope>test</scope>
     </dependency>
 
     <dependency>
       <groupId>org.slf4j</groupId>
       <artifactId>jcl-over-slf4j</artifactId>
-      <version>1.6.1</version>
+      <version>1.7.29</version>
       <scope>test</scope>
     </dependency>
 
     <dependency>
       <groupId>org.apache.commons</groupId>
       <artifactId>commons-lang3</artifactId>
-      <version>3.4</version>
+      <version>3.5</version>

Review comment:
       while investigating while java11 was failing local build I tought maybe it's the old bug from commons-lang3.
   anyway such upgrade doesn't hurt
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-site-plugin] olamy commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x implicit java8 requirement now

GitBox
In reply to this post by GitBox

olamy commented on a change in pull request #21:
URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427601611



##########
File path: src/it/projects/new-configuration/pom.xml
##########
@@ -76,7 +76,7 @@ under the License.
             <plugin>
               <groupId>org.apache.maven.plugins</groupId>
               <artifactId>maven-javadoc-plugin</artifactId>
-              <version>2.7</version>
+              <version>@javadocPluginVersion@</version>

Review comment:
       sorry but I will not do it. Maybe I should create a Jira ticket as well.
   Seriously stop such nit picking... I prefer spend my time on more useful stuff for the project than waste my time remove this commit creating a branch  and a separate PR only for this...
   I don't see why it's useful for the project.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-site-plugin] olamy commented on a change in pull request #21: [MSITE-829] Upgrade Jetty to 9.4.x implicit java8 requirement now

GitBox
In reply to this post by GitBox

olamy commented on a change in pull request #21:
URL: https://github.com/apache/maven-site-plugin/pull/21#discussion_r427603657



##########
File path: src/it/projects/new-configuration/pom.xml
##########
@@ -76,7 +76,7 @@ under the License.
             <plugin>
               <groupId>org.apache.maven.plugins</groupId>
               <artifactId>maven-javadoc-plugin</artifactId>
-              <version>2.7</version>
+              <version>@javadocPluginVersion@</version>

Review comment:
       LOL thanks you made my day




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]