[GitHub] [maven-site-plugin] elharo opened a new pull request #32: install dependabot

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-site-plugin] elharo opened a new pull request #32: install dependabot

GitBox

elharo opened a new pull request #32:
URL: https://github.com/apache/maven-site-plugin/pull/32


   @slachiewicz Dependabot seems to be working well on the parent repos. Let's try it here.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-site-plugin] michael-o commented on pull request #32: install dependabot

GitBox

michael-o commented on pull request #32:
URL: https://github.com/apache/maven-site-plugin/pull/32#issuecomment-647470345


   I have a huge problem with these PRs: no one create JIRA issues for these...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-site-plugin] michael-o edited a comment on pull request #32: install dependabot

GitBox
In reply to this post by GitBox

michael-o edited a comment on pull request #32:
URL: https://github.com/apache/maven-site-plugin/pull/32#issuecomment-647470345


   I have a huge problem with these PRs: no one creates JIRA issues for these...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-site-plugin] elharo commented on pull request #32: install dependabot

GitBox
In reply to this post by GitBox

elharo commented on pull request #32:
URL: https://github.com/apache/maven-site-plugin/pull/32#issuecomment-647508322


   Latest communication from @rfscholte was that dependency upgrades should just happen without JIRA issues. I'm inclined to agree, but if the community decides we must have JIRA issues for each dependency upgrade they can be added to dependabot PRs at the cost of some extra manual effort.
   
   There's a meta-issue here that every developer on the project has their own workflow, none of which fully match our outdated documentation on dev practices, and many of which contradict each other.
   
   As a general principle I prefer automation over convention. E.g. if we shouldn't use squash commits, then the squash commit button should be disabled on the repo rather than expecting devs not to press it. There are many other examples of this. If there are accepted conventions for code commits, it would be worth investing some time to enforce in our systems.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-site-plugin] hboutemy commented on pull request #32: install dependabot

GitBox
In reply to this post by GitBox

hboutemy commented on pull request #32:
URL: https://github.com/apache/maven-site-plugin/pull/32#issuecomment-647613135


   > If there are accepted conventions for code commits, it would be worth investing some time to enforce in our systems.
   
   implementing is just one line in .asf.yaml: https://cwiki.apache.org/confluence/display/INFRA/git+-+.asf.yaml+features#git.asf.yamlfeatures-Mergebuttons


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-site-plugin] mthmulders commented on pull request #32: install dependabot

GitBox
In reply to this post by GitBox

mthmulders commented on pull request #32:
URL: https://github.com/apache/maven-site-plugin/pull/32#issuecomment-657116214


   > As a general principle I prefer automation over convention. E.g. if we shouldn't use squash commits, then the squash commit button should be disabled on the repo rather than expecting devs not to press it. There are many other examples of this. If there are accepted conventions for code commits, it would be worth investing some time to enforce in our systems.
   
   Totally agree with this. If having a JIRA issue is relevant, I could spend some time trying to automate it with a Github action that could follow Dependabot. We'd probably need some kind of non-personal account to ASF JIRA but let's build that bridge when we get there.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-site-plugin] garydgregory commented on pull request #32: install dependabot

GitBox
In reply to this post by GitBox

garydgregory commented on pull request #32:
URL: https://github.com/apache/maven-site-plugin/pull/32#issuecomment-665593051






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]