[GitHub] [maven-site] ninj opened a new pull request #214: document all allowed elements inside profiles

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-site] ninj opened a new pull request #214: document all allowed elements inside profiles

GitBox

ninj opened a new pull request #214:
URL: https://github.com/apache/maven-site/pull/214


   Previously the list was incomplete but did not infer the list was partial, e.g.
   by using the word "some". If a user comes across the introductory guide first,
   then it is easy to miss the complete model documentation and not find the
   complete set of valid elements.
   
   As discussed, the following have been updated:
   - the remaining few elements have been added to complete the list.
   - a link to the full model documentation is now provided.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-site] ninj commented on a change in pull request #214: document all allowed elements inside profiles

GitBox

ninj commented on a change in pull request #214:
URL: https://github.com/apache/maven-site/pull/214#discussion_r523791519



##########
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##########
@@ -346,7 +346,8 @@ mvn groupId:artifactId:goal -P !profile-1,!profile-2
   it's reasonable to say you can add more information to them without the risk
   of that information being unavailable to other users.
 
-  Profiles specified in the POM can modify the following POM elements:
+  Profiles specified in the POM can modify the following POM elements as outlined
+  in the {{{/ref/current/maven-model/maven.html}maven model}}:

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-site] ninj commented on a change in pull request #214: document all allowed elements inside profiles

GitBox
In reply to this post by GitBox

ninj commented on a change in pull request #214:
URL: https://github.com/apache/maven-site/pull/214#discussion_r524476089



##########
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##########
@@ -346,7 +346,8 @@ mvn groupId:artifactId:goal -P !profile-1,!profile-2
   it's reasonable to say you can add more information to them without the risk
   of that information being unavailable to other users.
 
-  Profiles specified in the POM can modify the following POM elements:
+  Profiles specified in the POM can modify the
+  {{{/ref/current/maven-model/maven.html}the following POM elements}}:

Review comment:
       doh!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-site] elharo merged pull request #214: document all allowed elements inside profiles

GitBox
In reply to this post by GitBox

elharo merged pull request #214:
URL: https://github.com/apache/maven-site/pull/214


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]