[GitHub] [maven-site] mthmulders opened a new pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

[GitBox]

mthmulders opened a new pull request #225:
URL: https://github.com/apache/maven-site/pull/225


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

[GitBox]

slawekjaranowski commented on a change in pull request #225:
URL: https://github.com/apache/maven-site/pull/225#discussion_r553964597



##########
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##########
@@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test
   identifier with either the character '!' or '-' as shown below:
   
 +---+
-mvn groupId:artifactId:goal -P !profile-1,!profile-2
+mvn groupId:artifactId:goal -P !profile-1,!profile-2,!?profile-3

Review comment:
       did you try from console ... I have :
   ```
   $ mvn -N validate -P !profile-1,!profile-2
   bash: !profile-1,!profile-2: event not found
   ```
   
   ```
   $ bash --version
   GNU bash, version 5.1.4(1)-release (x86_64-apple-darwin19.6.0)
   ```
   
   ```
   $ mvn --version
   Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

[GitBox]

pzygielo commented on a change in pull request #225:
URL: https://github.com/apache/maven-site/pull/225#discussion_r554014876



##########
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##########
@@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test
   identifier with either the character '!' or '-' as shown below:
   
 +---+
-mvn groupId:artifactId:goal -P !profile-1,!profile-2
+mvn groupId:artifactId:goal -P !profile-1,!profile-2,!?profile-3

Review comment:
       > Instead of ! you can also use the minus sign, by the way.
   
   Then you might be affected by something like MNG-7011.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

[GitBox]

michael-o commented on a change in pull request #225:
URL: https://github.com/apache/maven-site/pull/225#discussion_r554041608



##########
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##########
@@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test
   identifier with either the character '!' or '-' as shown below:
   
 +---+
-mvn groupId:artifactId:goal -P !profile-1,!profile-2
+mvn groupId:artifactId:goal -P !profile-1,!profile-2,!?profile-3

Review comment:
       How do I interprete `!?`? Is it the same as `?!`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

[GitBox]

MartinKanters commented on a change in pull request #225:
URL: https://github.com/apache/maven-site/pull/225#discussion_r554007128



##########
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##########
@@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test
   identifier with either the character '!' or '-' as shown below:
   
 +---+
-mvn groupId:artifactId:goal -P !profile-1,!profile-2
+mvn groupId:artifactId:goal -P !profile-1,!profile-2,!?profile-3

Review comment:
       Instead of ! you can also use the minus sign, by the way.

##########
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##########
@@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test
   identifier with either the character '!' or '-' as shown below:
   
 +---+
-mvn groupId:artifactId:goal -P !profile-1,!profile-2
+mvn groupId:artifactId:goal -P !profile-1,!profile-2,!?profile-3

Review comment:
       In the current implementation there is an order in place:
   - !? is correct and means: "do not activate the profile, but do not fail if it does not exist"
   - ?! is not correct.. do you think we should support this as well?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]