[GitHub] [maven-site] kwin opened a new pull request #205: Feature/mng 6994 clarify repository order

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-site] kwin opened a new pull request #205: Feature/mng 6994 clarify repository order

GitBox

kwin opened a new pull request #205:
URL: https://github.com/apache/maven-site/pull/205


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-site] kwin commented on a change in pull request #205: MNG-6994 clarify repository order

GitBox

kwin commented on a change in pull request #205:
URL: https://github.com/apache/maven-site/pull/205#discussion_r499223023



##########
File path: content/apt/guides/mini/guide-multiple-repositories.apt
##########
@@ -52,11 +52,15 @@ Setting up Multiple Repositories
 
 +----+
 
+You can give repositories in a POM also in profiles.

Review comment:
       Fixed!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-site] kwin commented on a change in pull request #205: [MNG-6994] clarify repository order

GitBox
In reply to this post by GitBox

kwin commented on a change in pull request #205:
URL: https://github.com/apache/maven-site/pull/205#discussion_r499264802



##########
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##########
@@ -403,6 +403,56 @@ mvn groupId:artifactId:goal -P !profile-1,!profile-2
   One of the goals in Maven 2 is to consolidate all the information needed to

Review comment:
       This is a section I didn't touch at all. Do you really want me to do changes on unrelated and unchanged sections?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-site] elharo commented on a change in pull request #205: [MNG-6994] clarify repository order

GitBox
In reply to this post by GitBox

elharo commented on a change in pull request #205:
URL: https://github.com/apache/maven-site/pull/205#discussion_r499269010



##########
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##########
@@ -403,6 +403,56 @@ mvn groupId:artifactId:goal -P !profile-1,!profile-2
   One of the goals in Maven 2 is to consolidate all the information needed to
   run a build into a single file, or file hierarchy which is the POM.
 
+* Profile Order
+
+All profile elements in a POM from active profiles overwrite the global elements with the same name of the POM or extend those in case of collections.

Review comment:
       I think you can delete "of the POM"

##########
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##########
@@ -403,6 +403,56 @@ mvn groupId:artifactId:goal -P !profile-1,!profile-2
   One of the goals in Maven 2 is to consolidate all the information needed to
   run a build into a single file, or file hierarchy which is the POM.
 
+* Profile Order
+
+All profile elements in a POM from active profiles overwrite the global elements with the same name of the POM or extend those in case of collections.
+In case multiple profiles are active in the same POM or external file, the ones which are defined <<later>> take precedence over the ones defined <<earlier>> (independent of their profile id and activation order).

Review comment:
       I'm not sure you need "independent of their profile id and activation order" but if you do, you can drop the parentheses.

##########
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##########
@@ -403,6 +403,56 @@ mvn groupId:artifactId:goal -P !profile-1,!profile-2
   One of the goals in Maven 2 is to consolidate all the information needed to
   run a build into a single file, or file hierarchy which is the POM.
 
+* Profile Order
+
+All profile elements in a POM from active profiles overwrite the global elements with the same name of the POM or extend those in case of collections.
+In case multiple profiles are active in the same POM or external file, the ones which are defined <<later>> take precedence over the ones defined <<earlier>> (independent of their profile id and activation order).

Review comment:
       In case --> If
   

##########
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##########
@@ -403,6 +403,56 @@ mvn groupId:artifactId:goal -P !profile-1,!profile-2
   One of the goals in Maven 2 is to consolidate all the information needed to

Review comment:
       up to you, but otherwise I might be inspired to send a PR to fix this that conflicts with this one. :-)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-site] asfgit closed pull request #205: [MNG-6994] clarify repository order

GitBox
In reply to this post by GitBox

asfgit closed pull request #205:
URL: https://github.com/apache/maven-site/pull/205


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]