[GitHub] [maven-site] elharo commented on a change in pull request #212: [MNGSITE-393] Remove legacy Maven 2 info

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-site] elharo commented on a change in pull request #212: [MNGSITE-393] Remove legacy Maven 2 info

GitBox

elharo commented on a change in pull request #212:
URL: https://github.com/apache/maven-site/pull/212#discussion_r512861684



##########
File path: content/apt/guides/mini/guide-http-settings.apt
##########
@@ -33,28 +33,28 @@ Advanced Configuration of the HttpClient HTTP Wagon
   You can use the default wagon implementation for a given
   protocol, or you can select an alternative wagon <<<provider>>> on a per-protocol basis.
   For more information, see the {{{./guide-wagon-providers.html}Guide to Wagon Providers}} \[3\].
-  The default wagon http(s) is the HttpClient based on {{{http://hc.apache.org/httpcomponents-client-ga}Apache Http Client 4.1.2}}.
-  HTTP connection pooling prevents reopening http(s) to remote server for each requests.
+  The default wagon http(s) is the HttpClient based on {{{https://hc.apache.org/httpcomponents-client-4.5.x/}Apache Http Client 4.5}}.
+  HTTP connection pooling prevents reopening new connections to the same server for each request.
   This pool feature is configurable with some parameters \[4\].
   The default wagon comes with some default configuration:
 
   * http(s) connection pool: default to 20.
 
-  * readTimeout: default to 1800000ms (~30 minutes) (see section <<<Read time out>>> below)
+  * readTimeout: default to 1,800,000ms (~30 minutes) (see section <<<Read time out>>> below)

Review comment:
       Why? That risks breaking the line in the middle of the number.

##########
File path: content/apt/guides/mini/guide-http-settings.apt
##########
@@ -30,31 +30,13 @@ Advanced Configuration of the HttpClient HTTP Wagon
 
 %{toc}
 
-*Notice on Maven Versioning and Availability
-
-**Maven 2.2.0
-
-  Starting in <<Maven 2.2.0>>, the HttpClient wagon was the implementation in use. The remainder of this document
-  deals specifically with the differences between the HttpClient- and Sun-based HTTP wagons.
-
-**Maven 2.2.1
-  
-  Due to several critical issues introduced by the HttpClient-based HTTP wagon, <<Maven 2.2.1>> reverted back to
-  the Sun implementation (a.k.a. 'lightweight') of the HTTP wagon as the default for HTTP/HTTPS transfers.
-  The issues with the HttpClient-based wagon were mainly related to checksums, transfer timeouts, and NTLM proxies,
-  and served as the primary cause for the release of <<2.2.1>> in the first place.
-  
-  <<However>>, starting in <<Maven 2.2.1>> you have a choice: you can use the default wagon implementation for a given
-  protocol, or you can select an alternative wagon <<<provider>>> you'd like to use on a per-protocol basis.
+  You can use the default wagon implementation for a given
+  protocol, or you can select an alternative wagon <<<provider>>> on a per-protocol basis.
   For more information, see the {{{./guide-wagon-providers.html}Guide to Wagon Providers}} \[3\].
-
-**Maven 3.0.4
-
-  With 3.0.4, the default wagon http(s) is now the HttpClient based on {{{http://hc.apache.org/httpcomponents-client-ga}Apache Http Client 4.1.2}}.
-  There is now a http connection pooling to prevent reopening http(s) to remote server for each requests.
+  The default wagon http(s) is the HttpClient based on {{{http://hc.apache.org/httpcomponents-client-ga}Apache Http Client 4.1.2}}.
+  HTTP connection pooling prevents reopening http(s) to remote server for each requests.

Review comment:
       Thanks. I wasn't sure what this was trying to say.

##########
File path: content/apt/guides/mini/guide-http-settings.apt
##########
@@ -30,31 +30,13 @@ Advanced Configuration of the HttpClient HTTP Wagon
 
 %{toc}
 
-*Notice on Maven Versioning and Availability
-
-**Maven 2.2.0
-
-  Starting in <<Maven 2.2.0>>, the HttpClient wagon was the implementation in use. The remainder of this document
-  deals specifically with the differences between the HttpClient- and Sun-based HTTP wagons.
-
-**Maven 2.2.1
-  
-  Due to several critical issues introduced by the HttpClient-based HTTP wagon, <<Maven 2.2.1>> reverted back to
-  the Sun implementation (a.k.a. 'lightweight') of the HTTP wagon as the default for HTTP/HTTPS transfers.
-  The issues with the HttpClient-based wagon were mainly related to checksums, transfer timeouts, and NTLM proxies,
-  and served as the primary cause for the release of <<2.2.1>> in the first place.
-  
-  <<However>>, starting in <<Maven 2.2.1>> you have a choice: you can use the default wagon implementation for a given
-  protocol, or you can select an alternative wagon <<<provider>>> you'd like to use on a per-protocol basis.
+  You can use the default wagon implementation for a given
+  protocol, or you can select an alternative wagon <<<provider>>> on a per-protocol basis.
   For more information, see the {{{./guide-wagon-providers.html}Guide to Wagon Providers}} \[3\].
-
-**Maven 3.0.4
-
-  With 3.0.4, the default wagon http(s) is now the HttpClient based on {{{http://hc.apache.org/httpcomponents-client-ga}Apache Http Client 4.1.2}}.
-  There is now a http connection pooling to prevent reopening http(s) to remote server for each requests.
+  The default wagon http(s) is the HttpClient based on {{{http://hc.apache.org/httpcomponents-client-ga}Apache Http Client 4.1.2}}.

Review comment:
       done

##########
File path: content/apt/guides/mini/guide-http-settings.apt
##########
@@ -88,7 +88,7 @@ the target server's authentication.
 problems with HTTP servers and proxies that do not support HTTP/1.1 protocol.
 -----
 
-  Without this setting, PUT requests that require authentication will transfer their entire payload to the server before that server
+  Without this setting, PUT requests that require authentication transfer their entire payload to the server before that server

Review comment:
       What change do you suggest here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]