[GitHub] [maven-site] MartinKanters commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-site] MartinKanters commented on a change in pull request #225: [MNG-7051] Add examples of ? prefix in profile activation

GitBox

MartinKanters commented on a change in pull request #225:
URL: https://github.com/apache/maven-site/pull/225#discussion_r554058099



##########
File path: content/apt/guides/introduction/introduction-to-profiles.apt
##########
@@ -307,7 +309,7 @@ mvn groupId:artifactId:goal -Denvironment=test
   identifier with either the character '!' or '-' as shown below:
   
 +---+
-mvn groupId:artifactId:goal -P !profile-1,!profile-2
+mvn groupId:artifactId:goal -P !profile-1,!profile-2,!?profile-3

Review comment:
       In the current implementation there is an order in place:
   - !? is correct and means: "do not activate the profile, but do not fail if it does not exist"
   - ?! is not correct.. do you think we should support this as well?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]