[GitHub] [maven-shared-utils] elharo opened a new pull request #74: Windows 9X is long dead

[GitBox]

elharo opened a new pull request #74:
URL: https://github.com/apache/maven-shared-utils/pull/74


   @slawekjaranowski


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

slawekjaranowski commented on pull request #74:
URL: https://github.com/apache/maven-shared-utils/pull/74#issuecomment-765392013


   Maybe `org.apache.maven.shared.utils.cli.shell.CommandShell` should be also removed - I don't see usage of it in this project.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

michael-o commented on pull request #74:
URL: https://github.com/apache/maven-shared-utils/pull/74#issuecomment-765410713


   I agree with @slawekjaranowski


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

elharo commented on pull request #74:
URL: https://github.com/apache/maven-shared-utils/pull/74#issuecomment-765432876


   Eventually, yes. However it's public API so I don't want to remove it until it's been deprecated for a while longer and ideally we're ready for a major version bump.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

slawekjaranowski commented on pull request #74:
URL: https://github.com/apache/maven-shared-utils/pull/74#issuecomment-765451963


   I afraid that this never will happened developers don't look for deprecated ...
   The same result will be remove it and release next major version.
   
   Looking for this class on GitHub I found 4 repositories where it is used,  one of them is archived, two don't have any releases so impact will not be huge.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

elharo commented on pull request #74:
URL: https://github.com/apache/maven-shared-utils/pull/74#issuecomment-765945045


   I'm not comfortable removing public API without reasonable notice. Sounds like there are existing uses.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

slawekjaranowski commented on pull request #74:
URL: https://github.com/apache/maven-shared-utils/pull/74#issuecomment-766096218


   So please deprecate class with reason.
   
   Another case is that apache components don't have any release plan / calendar so nobody know when next release will be placed.
   Also there is no policy about clearing deprecated items.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

michael-o commented on pull request #74:
URL: https://github.com/apache/maven-shared-utils/pull/74#issuecomment-766152018


   @elharo This won't even run in Windows 9x because there isn't Java 7 for.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

elharo commented on pull request #74:
URL: https://github.com/apache/maven-shared-utils/pull/74#issuecomment-766155596


   That still doesn't mean we should break the build of projects that have this in their tree. Deprecate and warn them. We can take it out in a few releases.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

slachiewicz commented on pull request #74:
URL: https://github.com/apache/maven-shared-utils/pull/74#issuecomment-772603566


   `CmdShell` was marked as Deprecated with MSHARED-860 in https://github.com/apache/maven-shared-utils/commit/cb448b90918a5e894c38b86d00d402638f195502 and released with 3.3.3 version.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]

[GitBox]

slachiewicz edited a comment on pull request #74:
URL: https://github.com/apache/maven-shared-utils/pull/74#issuecomment-772603566


   `CommandShell` / Windows 95 was marked as Deprecated with MSHARED-860 in https://github.com/apache/maven-shared-utils/commit/cb448b90918a5e894c38b86d00d402638f195502 and released with 3.3.3 version.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]