[GitHub] [maven-shared-io] elharo opened a new pull request #5: limit maven-compat to test scope

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-shared-io] elharo opened a new pull request #5: limit maven-compat to test scope

GitBox

elharo opened a new pull request #5:
URL: https://github.com/apache/maven-shared-io/pull/5


   @hboutemy


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-shared-io] michael-o commented on pull request #5: limit maven-compat to test scope

GitBox

michael-o commented on pull request #5:
URL: https://github.com/apache/maven-shared-io/pull/5#issuecomment-652329966


   Interesting, why does it require compat at all?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-shared-io] elharo commented on pull request #5: limit maven-compat to test scope

GitBox
In reply to this post by GitBox

elharo commented on pull request #5:
URL: https://github.com/apache/maven-shared-io/pull/5#issuecomment-652375598


   Some of the tests use it. I'm trying to figure out how to eliminate it from tests here and elsewhere, but at least this will keep this artifact from slipping compat into the transitive dependency tree of everything that depends on shared-io.
   
   ```
   [ERROR] testShouldNotResolveWhenArtifactResolutionExceptionThrown(org.apache.maven.shared.io.location.ArtifactLocatorStrategyTest)  Time elapsed: 0.001 s  <<< ERROR!
   java.lang.NoClassDefFoundError: org/apache/maven/artifact/factory/ArtifactFactory
    at org.apache.maven.shared.io.location.ArtifactLocatorStrategyTest.setUp(ArtifactLocatorStrategyTest.java:52)
   
   [ERROR] testShouldFailToResolveSpecWithTwoTokens(org.apache.maven.shared.io.location.ArtifactLocatorStrategyTest)  Time elapsed: 0 s  <<< ERROR!
   java.lang.NoClassDefFoundError: org/apache/maven/artifact/factory/ArtifactFactory
    at org.apache.maven.shared.io.location.ArtifactLocatorStrategyTest.setUp(ArtifactLocatorStrategyTest.java:52)
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-shared-io] elharo edited a comment on pull request #5: limit maven-compat to test scope

GitBox
In reply to this post by GitBox

elharo edited a comment on pull request #5:
URL: https://github.com/apache/maven-shared-io/pull/5#issuecomment-652375598


   Some of the tests use it. I'm trying to figure out how to eliminate it from tests here and elsewhere, but at least this PR will keep compat from slipping into the transitive dependency tree of everything that depends on shared-io.
   
   ```
   [ERROR] testShouldNotResolveWhenArtifactResolutionExceptionThrown(org.apache.maven.shared.io.location.ArtifactLocatorStrategyTest)  Time elapsed: 0.001 s  <<< ERROR!
   java.lang.NoClassDefFoundError: org/apache/maven/artifact/factory/ArtifactFactory
    at org.apache.maven.shared.io.location.ArtifactLocatorStrategyTest.setUp(ArtifactLocatorStrategyTest.java:52)
   
   [ERROR] testShouldFailToResolveSpecWithTwoTokens(org.apache.maven.shared.io.location.ArtifactLocatorStrategyTest)  Time elapsed: 0 s  <<< ERROR!
   java.lang.NoClassDefFoundError: org/apache/maven/artifact/factory/ArtifactFactory
    at org.apache.maven.shared.io.location.ArtifactLocatorStrategyTest.setUp(ArtifactLocatorStrategyTest.java:52)
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-shared-io] elharo commented on pull request #5: limit maven-compat to test scope

GitBox
In reply to this post by GitBox

elharo commented on pull request #5:
URL: https://github.com/apache/maven-shared-io/pull/5#issuecomment-652376772


   or not. This one fails CI and needs more work.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-shared-io] elharo closed pull request #5: limit maven-compat to test scope

GitBox
In reply to this post by GitBox

elharo closed pull request #5:
URL: https://github.com/apache/maven-shared-io/pull/5


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]