[GitHub] [maven-shade-plugin] michaelboyles opened a new pull request #71: (doc) Dead link for source repo

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-shade-plugin] michaelboyles opened a new pull request #71: (doc) Dead link for source repo

GitBox

michaelboyles opened a new pull request #71:
URL: https://github.com/apache/maven-shade-plugin/pull/71


   The link for source repo was dead
   
   
   Following this checklist to help us incorporate your
   contribution quickly and easily:
   
    - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MSHADE) filed
          for the change (usually before you start working on it).  Trivial changes like typos do not
          require a JIRA issue.  Your pull request should address just this issue, without
          pulling in other changes.
    - [x] Each commit in the pull request should have a meaningful subject line and body.
    - [x] Format the pull request title like `[MSHADE-XXX] - Fixes bug in ApproximateQuantiles`,
          where you replace `MSHADE-XXX` with the appropriate JIRA issue. Best practice
          is to use the JIRA issue title in the pull request title and in the first line of the
          commit message.
    - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
          be performed on your pull request automatically.
    - [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-shade-plugin] rfscholte commented on a change in pull request #71: (doc) Dead link for source repo

GitBox

rfscholte commented on a change in pull request #71:
URL: https://github.com/apache/maven-shade-plugin/pull/71#discussion_r488861984



##########
File path: src/site/apt/index.apt.vm
##########
@@ -50,7 +50,7 @@ ${project.name}
   concern. Especially for fixing bugs it is crucial that the developers can reproduce your problem. For this reason,
   entire debug logs, POMs or most preferably little demo projects attached to the issue are very much appreciated.
   Of course, patches are welcome, too. Contributors can check out the project from our
-  {{{./source-repository.html}source repository}} and will find supplementary information in the
+  {{{https://github.com/apache/maven-shade-plugin}source repository}} and will find supplementary information in the

Review comment:
       It should be {{scm.html}}




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-shade-plugin] rfscholte commented on a change in pull request #71: (doc) Dead link for source repo

GitBox
In reply to this post by GitBox

rfscholte commented on a change in pull request #71:
URL: https://github.com/apache/maven-shade-plugin/pull/71#discussion_r488861984



##########
File path: src/site/apt/index.apt.vm
##########
@@ -50,7 +50,7 @@ ${project.name}
   concern. Especially for fixing bugs it is crucial that the developers can reproduce your problem. For this reason,
   entire debug logs, POMs or most preferably little demo projects attached to the issue are very much appreciated.
   Of course, patches are welcome, too. Contributors can check out the project from our
-  {{{./source-repository.html}source repository}} and will find supplementary information in the
+  {{{https://github.com/apache/maven-shade-plugin}source repository}} and will find supplementary information in the

Review comment:
       It should be `scm.html`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-shade-plugin] asfgit closed pull request #71: (doc) Dead link for source repo

GitBox
In reply to this post by GitBox

asfgit closed pull request #71:
URL: https://github.com/apache/maven-shade-plugin/pull/71


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]