[GitHub] maven pull request #151: [MNG-5968] Default plugin version updates

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] maven pull request #151: [MNG-5968] Default plugin version updates

Theoderich
GitHub user slachiewicz opened a pull request:

    https://github.com/apache/maven/pull/151

    [MNG-5968] Default plugin version updates

    o Updated default plugin versions to latest release version to bring in the latest fixes (and issues to report).
    o Updated to correct the 'ear' packaging bindings.
    o Downgraded the 'maven-plugin-plugin' from 3.4 to 3.3  due to MPLUGIN-296.
    o Updated to 'maven-site-plugin' 3.7

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/slachiewicz/maven fix/MNG-5968

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven/pull/151.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #151
   
----
commit 235eaaaad356c43802b6a0e96a982a95efe9313d
Author: Sylwester Lachiewicz <slachiewicz@...>
Date:   2018-01-07T01:10:35Z

    [MNG-5968] Default plugin version updates.
   
    o Updated default plugin versions to latest release version to bring in the latest fixes (and issues to report).
    o Updated to correct the 'ear' packaging bindings.
    o Downgraded the 'maven-plugin-plugin' from 3.4 to 3.3  due to MPLUGIN-296.
    o Updated to 'maven-site-plugin' 3.7

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven issue #151: [MNG-5968] Default plugin version updates

Theoderich
Github user hboutemy commented on the issue:

    https://github.com/apache/maven/pull/151
 
    I'm not a fan of default plugins updates in core:
    - depending on default versions is a bad practice, we expect users to explicitely choose their version through pluginManagement (and we display a big WARNING in case they don't do it)
    - it changes behaviour when switching from one mvn version to the other
   
    then IMHO changing default plugins version should really be driven by key issues that we really want to avoid for untrained people (who don't know the requirement to define their choice): for example MNG-5992 would such an exception (default security is more important than helping people know that they need to choose their plugins versions by letting old plugins versions by default)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven issue #151: [MNG-5968] Default plugin version updates

Theoderich
In reply to this post by Theoderich
Github user hboutemy commented on the issue:

    https://github.com/apache/maven/pull/151
 
    other topics:
    - MNG-5968 is closed
    - MNG-5968 is not about default plugins versions, but about Maven core build
   
    if you rework this PR to focus on MNG-5992, ie providing a more secure maven-release-plugin by default in Super POM, I would push this one
    If you want to update other plugins, please consider other PRs with other Jira issues, since I will challenge the change seriously :)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven issue #151: [MNG-5968] Default plugin version updates

Theoderich
In reply to this post by Theoderich
Github user slachiewicz commented on the issue:

    https://github.com/apache/maven/pull/151
 
    Thank you for the explanation, I have seen previous discussions about the update - for sure the refreshment of the topic will be useful like MNG-6169
    I have prepared fix for MNG-5992 and clossing this pull.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven pull request #151: [MNG-5968] Default plugin version updates

Theoderich
In reply to this post by Theoderich
Github user slachiewicz closed the pull request at:

    https://github.com/apache/maven/pull/151


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]