[GitHub] maven pull request #128: [MNG-6256] Surround variables in echo command with ...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven pull request #128: [MNG-6256] Surround variables in echo command with ...

lamyaa
GitHub user etzelc opened a pull request:

    https://github.com/apache/maven/pull/128

    [MNG-6256] Surround variables in echo command with double quotes

    This is a patch for issue MNG-6256. https://issues.apache.org/jira/browse/MNG-6256

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/etzelc/maven MNG-6256

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven/pull/128.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #128
   
----
commit f578a733ade77c3d11186c395d1d5199a65f532d
Author: Christoph Etzel <[hidden email]>
Date:   2017-07-14T08:26:06Z

    [MNG-6256] Surround variables in echo command with double quotes

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven issue #128: [MNG-6256] Surround variables in echo command with double ...

lamyaa
Github user etzelc commented on the issue:

    https://github.com/apache/maven/pull/128
 
    I will have a closer look next week, right now only tested with Windows (since only cmd script was modified). In the {{mvn}} script the string of the {{echo}} is already completely in double quotes, but I will have a look.
   
    I have already an IT with three tests (for space, bracket and ampersand), but found out that maven has problems with ampersands in folder names. Probably I will remove that special case. See https://github.com/etzelc/maven-integration-testing/tree/MNG-6256



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Loading...