[GitHub] maven pull request #127: Fix concat_lines in mvn to deal with CRLF

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven pull request #127: Fix concat_lines in mvn to deal with CRLF

lamyaa
GitHub user grkvlt opened a pull request:

    https://github.com/apache/maven/pull/127

    Fix concat_lines in mvn to deal with CRLF

    Change from `tr` to `paste` to deal with CRLF line endings properly

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/grkvlt/maven patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven/pull/127.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #127
   
----
commit b9762ae480d27bf0e4ee7a86c571234035a575c6
Author: Andrew Donald Kennedy <[hidden email]>
Date:   2017-07-10T15:58:33Z

    Fix concat_lines in mvn to deal with CRLF
   
    Change from `tr` to `paste` to deal with CRLF line endings properly

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven issue #127: Fix concat_lines in mvn to deal with CRLF

lamyaa
Github user Tunaki commented on the issue:

    https://github.com/apache/maven/pull/127
 
    This doesn't seem to work on CRLF files on Git Bash (or Ubuntu). Result is the same as with `tr`.
   
    ```sh
    $ echo -e "Foo\nBar" > test.txt
    $ cat -e test.txt
    Foo$
    Bar$
    $ paste -s -d' ' test.txt
    Foo Bar
    $ unix2dos test.txt
    unix2dos: converting file test.txt to DOS format ...
    $ cat -e test.txt
    Foo^M$
    Bar^M$
    $ paste -s -d' ' test.txt
     Bar
    ```
   
    When the line endings were changed to Windows format, only the last line was kept.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven issue #127: [MNG-6255] Fix concat_lines in mvn to deal with CRLF

lamyaa
In reply to this post by lamyaa
Github user grkvlt commented on the issue:

    https://github.com/apache/maven/pull/127
 
    @Tunaki I will disable the *CR* test, then


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Loading...