[GitHub] maven pull request #118: Upgrade SLF4J to 1.7.25 and expelled the groovy mon...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] maven pull request #118: Upgrade SLF4J to 1.7.25 and expelled the groovy mon...

Tibor17-2
GitHub user ebourg opened a pull request:

    https://github.com/apache/maven/pull/118

    Upgrade SLF4J to 1.7.25 and expelled the groovy monkey

    The changes to SLF4J required to support maven-slf4j-provider have been [released ](https://jira.qos.ch/browse/SLF4J-394) in the version 1.7.25. If I'm not mistaken it should be possible to remove the patching tweak now.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ebourg/maven master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven/pull/118.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #118
   
----
commit c0de5b5720626a21544c374018af922e793f4a88
Author: Emmanuel Bourg <[hidden email]>
Date:   2017-05-16T13:30:29Z

    Upgraded SLF4J to 1.7.25 and expelled the groovy monkey

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven issue #118: Upgrade SLF4J to 1.7.25

Tibor17-2
Github user ebourg commented on the issue:

    https://github.com/apache/maven/pull/118
 
    Is the StaticLoggerBinder implementation necessary? I built Maven without and it seemed to work, the resulting version was able to build a couple of random projects and the console output was colored.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven issue #118: Upgrade SLF4J to 1.7.25

Tibor17-2
In reply to this post by Tibor17-2
Github user ebourg commented on the issue:

    https://github.com/apache/maven/pull/118
 
    Understood, thank you. I've added a StaticLoggerBinder implementation but now SLF4J complains that there are two StaticLoggerBinder on the classpath (from maven-slf4j-provider and slf4j-simple). I'll try to shade slf4j-simple and remove its StaticLoggerBinder class.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven issue #118: Upgrade SLF4J to 1.7.25

Tibor17-2
In reply to this post by Tibor17-2
Github user ebourg commented on the issue:

    https://github.com/apache/maven/pull/118
 
    Thank you. The add-source trick is a bit problematic for the Debian packaging because we don't build the source jars, but we can live with a Debian specific patch using the shade plugin instead.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]