[GitHub] maven pull request #116: Fix jsr-330 injection of DefaultArtifactDescriptorR...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] maven pull request #116: Fix jsr-330 injection of DefaultArtifactDescriptorR...

Tibor17-2
GitHub user jdillon opened a pull request:

    https://github.com/apache/maven/pull/116

    Fix jsr-330 injection of DefaultArtifactDescriptorReader

    ... which is not setting the VersionRangeResolver; cause NPE when use w/o plexus requirement injection

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jdillon/maven DefaultArtifactDescriptorReader-injection-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven/pull/116.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #116
   
----
commit 0c3f3a42262c5692742abc73042a1deece0898e0
Author: Jason Dillon <[hidden email]>
Date:   2017-05-14T19:45:11Z

    Fix jsr-330 injection of DefaultArtifactDescriptorReader; which was not setting the VersionRangeResolver

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader

Tibor17-2
Github user jdillon commented on the issue:

    https://github.com/apache/maven/pull/116
 
    @ifedorenko howdy, i'm fine to wait if you are gonna adjust to jsr330 that will be better generally for the project anyways IMO; i'm just trying to learn how to use the api and can live with this change locally for now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader

Tibor17-2
In reply to this post by Tibor17-2
Github user jdillon commented on the issue:

    https://github.com/apache/maven/pull/116
 
    @ifedorenko can close this if you like, wasn't sure what you mean about "a JIRA either way".  If we close this and go with your changes (which if you have that mostly done for merge soon is what I would suggest over this).  For now I'm assuming you'll merge you changes and file a JIRA, but if you need a JIRA specifically about this bug I can file it if you need.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader

Tibor17-2
In reply to this post by Tibor17-2
Github user michael-o commented on the issue:

    https://github.com/apache/maven/pull/116
 
    @ifedorenko Closing PRs requires a ticket with INFRA on JIRA.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader

Tibor17-2
In reply to this post by Tibor17-2
Github user ifedorenko commented on the issue:

    https://github.com/apache/maven/pull/116
 
    Wow. That's backwards. I wonder what will happen if I push my change with github's magic "fixes 116" pseudo comment. Guess there is one way to find out :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader

Tibor17-2
In reply to this post by Tibor17-2
Github user michael-o commented on the issue:

    https://github.com/apache/maven/pull/116
 
    @jdillon I'd like to merge this but need a JIRA issue. At best, an IT too. Can you provide a simple one?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader

Tibor17-2
In reply to this post by Tibor17-2
Github user michael-o commented on the issue:

    https://github.com/apache/maven/pull/116
 
    Thanks for the explanation. So it is not a prerequisite directly. I'd still insist for an JIRA because I need another committer to second this and have this in our release notes. Do you have a simple usecase to turn into an IT? I am fine with merging your change, looks pretty reasonable to me. Clearly a bug.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]