[GitHub] maven pull request #112: Fix snapshot regular expression

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven pull request #112: Fix snapshot regular expression

lamyaa
GitHub user kevin-canadian opened a pull request:

    https://github.com/apache/maven/pull/112

    Fix snapshot regular expression

    The snapshot regular expression should only match an explicit period.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kevin-canadian/maven patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven/pull/112.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #112
   
----
commit 4711e19eaf4bc1ef081d2940a2416289a5e60a89
Author: kevin-canadian <[hidden email]>
Date:   2017-04-07T12:51:42Z

    Fix snapshot regular expression
   
    The snapshot regular expression should only match an explicit period.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven issue #112: Fix snapshot regular expression

lamyaa
Github user khmarbaise commented on the issue:

    https://github.com/apache/maven/pull/112
 
    First thanks for your pull request but it is really needed that you open a [JIRA ticket ](issues.apache.org/jira/browse/MNG) and furthermore it would be great if you could offer some unit tests which show the old behaviour and the new one which fix it by the appropriate fix.  Apart from that the commit message should contain a reference to the appropriate JIRA ticket cause it's can't followed later in the history and can't be seen in the release notes...



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven issue #112: Fix snapshot regular expression

lamyaa
In reply to this post by lamyaa
Github user kevin-canadian commented on the issue:

    https://github.com/apache/maven/pull/112
 
    I actually just wanted to let you know about the bug, and since the fix was so simple I made a PR rather than creating an issue.
   
    It will be a while before I have time look into the project's contribution guidelines or figure out how to add and run appropriate tests.
   
    If someone would like to incorporate this fix in the meantime that would be great, otherwise I'll try to get around to it eventually!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven issue #112: Fix snapshot regular expression

lamyaa
In reply to this post by lamyaa
Github user khmarbaise commented on the issue:

    https://github.com/apache/maven/pull/112
 
    If you will take some time it's not a problem...the PR will be kept here for a long time until you will close it yourself ..so you can be patient and take the time you need...no hurry needed...Furthermore it would be great if you have identified an error of any kind of or just realised by reading the code the issue? The circumstances are important...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven issue #112: Fix snapshot regular expression

lamyaa
In reply to this post by lamyaa
Github user kevin-canadian commented on the issue:

    https://github.com/apache/maven/pull/112
 
    Thanks for the quick reply.
   
    This PR was prompted by a bug we discovered in our production build environment.  When we updated our release artifact version number format to be <major>.<minor>.<patch>-YYYYMMDD-HHmmss-<build-number>, release artifacts were erroneously being sent to snapshot repositories, resulting in strange issues in our Archiva repository.
   
    The reason appears to be that the regex used to identify timestamp-tagged snapshot version numbers erroneously uses a wildcard "." instead of a literal "." to match the separator between date and time.  This results in our version format, which uses a "-" as the separator, being incorrectly identified as a timestamp-tagged snapshot version number instead of a release version number.
   
    For now we just modified our release artifact version number format to something else.  When I find the time I'll create a JIRA issue and a proper patch for this issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven issue #112: Fix snapshot regular expression

lamyaa
In reply to this post by lamyaa
Github user khmarbaise commented on the issue:

    https://github.com/apache/maven/pull/112
 
    It would be great if you could do that, cause it should be honoured to those who found the bug(s)...If I can support you please ask how?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven issue #112: Fix snapshot regular expression

lamyaa
In reply to this post by lamyaa
Github user kevin-canadian commented on the issue:

    https://github.com/apache/maven/pull/112
 
    If I run into any problems I'll mention them here, thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven issue #112: Fix snapshot regular expression

lamyaa
In reply to this post by lamyaa
Github user khmarbaise commented on the issue:

    https://github.com/apache/maven/pull/112
 
    If you like to get your pull request being integrated it is required to open an [issue on jira](https://issues.apache.org/jira/browse/MNG) and change your commit message accordingly. Something like:
    ```
    [MNG-XXXX] ..
     o description if needed
    ```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Loading...