Quantcast

[GitHub] maven-plugins pull request #112: Maven War Plugin eash fix

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven-plugins pull request #112: Maven War Plugin eash fix

asfgit
GitHub user eolivelli opened a pull request:

    https://github.com/apache/maven-plugins/pull/112

    Maven War Plugin eash fix

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/eolivelli/maven-plugins maven-war-plugin-easy-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven-plugins/pull/112.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #112
   
----
commit fd517a2be0fac4d7d94dc54bcf62bceb791d3d2f
Author: eolivelli <[hidden email]>
Date:   2017-04-11T08:07:36Z

    Maven War Plugin eash fix

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven-plugins pull request #112: MWAR-405 Workaround XStream incompatibility...

asfgit
GitHub user eolivelli reopened a pull request:

    https://github.com/apache/maven-plugins/pull/112

    MWAR-405  Workaround XStream incompatibility with Java9

    This is a proof-of-concept implementation of a possible way to word-around the actual incompatibility of xstreams default converters with java9.
    As the maven-war-plugin does not need all of the converters (like TreeMapConverter which is the primary cause of the issue) we can just register only the needed ones and bypass the java9 issue
   
    see
   
        Caused by: java.lang.reflect.InaccessibleObjectException: Unable to make field private final java.util.Comparator java.util.TreeMap.comparator accessible: module java.base does not "opens java.util" to unnamed module
        Happens while initializing org.apache.maven.plugins.war.util.WebappStructureSerializer
   
    at
    https://cwiki.apache.org/confluence/display/MAVEN/Java+9+-+Jigsaw
   
    this PR is just a proof-of-concept, there is an email thread on the dev list. If the idea is accepted I will submit a JIRA and official PR (some code cleanup is needed at least)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/eolivelli/maven-plugins maven-war-plugin-easy-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven-plugins/pull/112.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #112
   
----
commit d26db922d07425eb74d0cf1b42c1234f6953cd96
Author: eolivelli <[hidden email]>
Date:   2017-04-11T08:07:36Z

    Load only useful XStream converters

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven-plugins pull request #112: MWAR-405 Workaround XStream incompatibility...

asfgit
In reply to this post by asfgit
Github user eolivelli closed the pull request at:

    https://github.com/apache/maven-plugins/pull/112


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven-plugins pull request #112: MWAR-405 Workaround XStream incompatibility...

asfgit
In reply to this post by asfgit
GitHub user eolivelli reopened a pull request:

    https://github.com/apache/maven-plugins/pull/112

    MWAR-405  Workaround XStream incompatibility with Java9

    This is a proof-of-concept implementation of a possible way to word-around the actual incompatibility of xstreams default converters with java9.
    As the maven-war-plugin does not need all of the converters (like TreeMapConverter which is the primary cause of the issue) we can just register only the needed ones and bypass the java9 issue
   
    see
   
        Caused by: java.lang.reflect.InaccessibleObjectException: Unable to make field private final java.util.Comparator java.util.TreeMap.comparator accessible: module java.base does not "opens java.util" to unnamed module
        Happens while initializing org.apache.maven.plugins.war.util.WebappStructureSerializer
   
    at
    https://cwiki.apache.org/confluence/display/MAVEN/Java+9+-+Jigsaw
   
    this PR is just a proof-of-concept, there is an email thread on the dev list. If the idea is accepted I will submit a JIRA and official PR (some code cleanup is needed at least)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/eolivelli/maven-plugins maven-war-plugin-easy-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven-plugins/pull/112.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #112
   
----
commit 9bd4409a309d461ffc77dda06b11d295797d3b27
Author: eolivelli <[hidden email]>
Date:   2017-04-11T08:07:36Z

    MWAR-405 Workaround XStream incompatibility with Java9
    Register only used Converters

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven-plugins pull request #112: MWAR-405 Workaround XStream incompatibility...

asfgit
In reply to this post by asfgit
Github user eolivelli closed the pull request at:

    https://github.com/apache/maven-plugins/pull/112


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Loading...