[GitHub] [maven] mthmulders opened a new pull request #325: [MNG-4660] --resume-from flag resolves inter-module dependencies

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven] mthmulders opened a new pull request #325: [MNG-4660] --resume-from flag resolves inter-module dependencies

GitBox
mthmulders opened a new pull request #325: [MNG-4660] --resume-from flag resolves inter-module dependencies
URL: https://github.com/apache/maven/pull/325
 
 
   Following this checklist to help us incorporate your contribution quickly and easily:
   
   - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes. <br /> [**MNG-4660**](https://issues.apache.org/jira/browse/MNG-4660).
   - [X] Each commit in the pull request should have a meaningful subject line and body.
   - [X] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`,        where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message.
    - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   **This pull request makes sure that the `ReactorReader` looks at _all_ modules in the project, not only those that are part of the reactor. It also checks whether the workspace might contain built artifacts from earlier Maven invocations, and uses those files for the artifacts that they belong to.**
   - [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
   **Additionally, there is an extra integration test in maven-integration-testing: [apache/maven-integration-testing #54](https://github.com/apache/maven-integration-testing/pull/54).**
   - [X] You have run the [Core IT][core-its] successfully.
   
   If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list.
   
   To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box.
   
   - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   - [X] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   **ICLA has been signed by @MartinKanters and myself. CCLA has been signed by our employer, Info Support.**
   
   [core-its]: https://maven.apache.org/core-its/core-it-suite/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven] mthmulders commented on issue #325: [MNG-4660] --resume-from flag resolves inter-module dependencies

GitBox
mthmulders commented on issue #325: [MNG-4660] --resume-from flag resolves inter-module dependencies
URL: https://github.com/apache/maven/pull/325#issuecomment-586560167
 
 
   Forgot to mention, we actually started with an integration test: [apache/maven-integration-testing #54](https://github.com/apache/maven-integration-testing/pull/54).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services