[GitHub] [maven] michael-o opened a new pull request #398: [MNG-6268] When a reactor build fails Maven should include -f (if used) in command line suggestion

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven] michael-o opened a new pull request #398: [MNG-6268] When a reactor build fails Maven should include -f (if used) in command line suggestion

GitBox

michael-o opened a new pull request #398:
URL: https://github.com/apache/maven/pull/398


   I don't know whether this should be included, but it is trivial to provide. I will let the community decide. If accepted someone should write an IT for that.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven] rfscholte commented on pull request #398: [MNG-6268] When a reactor build fails Maven should include -f (if used) in command line suggestion

GitBox

rfscholte commented on pull request #398:
URL: https://github.com/apache/maven/pull/398#issuecomment-731731110


   Writing a unittest is much easier in this case and sufficient enough.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven] michael-o commented on pull request #398: [MNG-6268] When a reactor build fails Maven should include -f (if used) in command line suggestion

GitBox
In reply to this post by GitBox

michael-o commented on pull request #398:
URL: https://github.com/apache/maven/pull/398#issuecomment-731742284


   Just scratching my head how the full boostrap with a unit test would work here since I'd need to analyze stdout/err.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven] rfscholte commented on pull request #398: [MNG-6268] When a reactor build fails Maven should include -f (if used) in command line suggestion

GitBox
In reply to this post by GitBox

rfscholte commented on pull request #398:
URL: https://github.com/apache/maven/pull/398#issuecomment-731746432


   IIRC @mthmulders had a similar usecase recently


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven] mthmulders commented on pull request #398: [MNG-6268] When a reactor build fails Maven should include -f (if used) in command line suggestion

GitBox
In reply to this post by GitBox

mthmulders commented on pull request #398:
URL: https://github.com/apache/maven/pull/398#issuecomment-731818143


   > IIRC @mthmulders had a similar usecase recently
   
   Not sure if I understand correctly what you refer to. I recently had a contribution to Plexus Archiver where I wrote a [`CapturingLog`](https://github.com/codehaus-plexus/plexus-archiver/blob/master/src/test/java/org/codehaus/plexus/archiver/CapturingLog.java). But given that this is SLF4J, it might be easier to go with something like [SLF4J Test](https://projects.lidalia.org.uk/slf4j-test/).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven] michael-o commented on pull request #398: [MNG-6268] When a reactor build fails Maven should include -f (if used) in command line suggestion

GitBox
In reply to this post by GitBox

michael-o commented on pull request #398:
URL: https://github.com/apache/maven/pull/398#issuecomment-731819121


   The SFL4J test looks promising, but wouldn't it be easier to do just an IT instead of going through a new component?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven] rfscholte commented on pull request #398: [MNG-6268] When a reactor build fails Maven should include -f (if used) in command line suggestion

GitBox
In reply to this post by GitBox

rfscholte commented on pull request #398:
URL: https://github.com/apache/maven/pull/398#issuecomment-731853091


   Another option is to increase the visibility of `logBuildResumeHint( String resumeBuildHint )` a bit, in the unittest making a new MavenCli with an override of this method. To me an IT is overkill for this check, as it is simple input/output validation, only the difficulty here is that it is writing directly the the logging framework. Better adjust the class to make it testable


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven] michael-o commented on pull request #398: [MNG-6268] When a reactor build fails Maven should include -f (if used) in command line suggestion

GitBox
In reply to this post by GitBox

michael-o commented on pull request #398:
URL: https://github.com/apache/maven/pull/398#issuecomment-732116545


   Another option is to have no test at all since this change is straight forward. Pipe input to output unmodified as you can see.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven] rfscholte commented on pull request #398: [MNG-6268] When a reactor build fails Maven should include -f (if used) in command line suggestion

GitBox
In reply to this post by GitBox

rfscholte commented on pull request #398:
URL: https://github.com/apache/maven/pull/398#issuecomment-732268218


   I'm fine with no test in this case.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]