[GitHub] [maven] michael-o opened a new pull request #393: [MNG-7019] Notify also at start when profile is missing

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven] michael-o opened a new pull request #393: [MNG-7019] Notify also at start when profile is missing

GitBox

michael-o opened a new pull request #393:
URL: https://github.com/apache/maven/pull/393


   @rfscholte Here it is, prerequisite for release profile removal.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven] rfscholte commented on pull request #393: [MNG-7019] Notify also at start when profile is missing

GitBox

rfscholte commented on pull request #393:
URL: https://github.com/apache/maven/pull/393#issuecomment-726991312


   This is only one the warning part. It should also break the build, because what we've already seen due a bug in maven-release-plugin is that if the release-profile is not activated (and you are not aware of it) you'll end up with an incomplete release.
   Sebb also suggested to suppress that check, but I see that as optimization. https://issues.apache.org/jira/browse/MNG-6511 suffers the same issue. I suggested to introduce a ? prefix to mark it as optional. e.g. `-P ?apache-release` will active this profile, but won't break it when it is missing, whereas `-P apache-release` should break the build.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven] michael-o commented on pull request #393: [MNG-7019] Notify also at start when profile is missing

GitBox
In reply to this post by GitBox

michael-o commented on pull request #393:
URL: https://github.com/apache/maven/pull/393#issuecomment-726995047


   Correct, this PR is for the warning only. No other functionality intentionally. I agree with breaking the build and the options `?` prefix, but it must be handled in separate tickets.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven] michael-o commented on pull request #393: [MNG-7019] Notify also at start when profile is missing

GitBox
In reply to this post by GitBox

michael-o commented on pull request #393:
URL: https://github.com/apache/maven/pull/393#issuecomment-727065635


   Is this PR acceptable for you?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven] rfscholte commented on pull request #393: [MNG-7019] Notify also at start when profile is missing

GitBox
In reply to this post by GitBox

rfscholte commented on pull request #393:
URL: https://github.com/apache/maven/pull/393#issuecomment-727173164


   Once the separate ticket is created (with cross links to each other) this change is fine.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven] michael-o commented on pull request #393: [MNG-7019] Notify also at start when profile is missing

GitBox
In reply to this post by GitBox

michael-o commented on pull request #393:
URL: https://github.com/apache/maven/pull/393#issuecomment-727207084


   Isn't it MNG-6012?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven] rfscholte commented on pull request #393: [MNG-7019] Notify also at start when profile is missing

GitBox
In reply to this post by GitBox

rfscholte commented on pull request #393:
URL: https://github.com/apache/maven/pull/393#issuecomment-727213297


   Ok, now I understand the confusion, I wasn't aware this is a new subtask of MNG-6012.
   The description of MNG-6012 needs to be updated that (1) is fixed with MNG-7019, and that MNG-6012 is now about (2): breaking the build.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven] michael-o commented on pull request #393: [MNG-7019] Notify also at start when profile is missing

GitBox
In reply to this post by GitBox

michael-o commented on pull request #393:
URL: https://github.com/apache/maven/pull/393#issuecomment-727213827


   Agreed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven] michael-o commented on pull request #393: [MNG-7019] Notify also at start when profile is missing

GitBox
In reply to this post by GitBox

michael-o commented on pull request #393:
URL: https://github.com/apache/maven/pull/393#issuecomment-727215251


   Done: https://issues.apache.org/jira/browse/MNG-6012?focusedCommentId=17232034&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17232034


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven] michael-o commented on pull request #393: [MNG-7019] Notify also at start when profile is missing

GitBox
In reply to this post by GitBox

michael-o commented on pull request #393:
URL: https://github.com/apache/maven/pull/393#issuecomment-731754280


   @rfscholte Are we good to merge now?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]


Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven] asfgit merged pull request #393: [MNG-7019] Notify also at start when profile is missing

GitBox
In reply to this post by GitBox

asfgit merged pull request #393:
URL: https://github.com/apache/maven/pull/393


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[hidden email]