[GitHub] [maven-javadoc-plugin] maxcellent commented on issue #34: [MJAVADOC-628] - add javadoc.io link pattern when <detectLink> option is …

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [maven-javadoc-plugin] maxcellent commented on issue #34: [MJAVADOC-628] - add javadoc.io link pattern when <detectLink> option is …

GitBox
maxcellent commented on issue #34: [MJAVADOC-628] - add javadoc.io link pattern when <detectLink> option is …
URL: https://github.com/apache/maven-javadoc-plugin/pull/34#issuecomment-552084346
 
 
   yeah, I've been thinking about the same when implementing it. But it feels
   a bit overkill to add a generic mechanism if this is the only case.
   
   How about merge this for now? and then we can further extends it if there
   are more user requests to add more providers. Happy to help with the coding
   as well.
   
   On Sat, Nov 9, 2019 at 5:43 PM Enrico Olivelli <[hidden email]>
   wrote:
   
   > *@eolivelli* requested changes on this pull request.
   >
   > Very nice.
   > I wonder if we can make it more configurable, with a list of patterns.
   > For each provider you can define a pattern with placeholders
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/maven-javadoc-plugin/pull/34?email_source=notifications&email_token=AASET5IIE3RXJ6RHULK4MHTQS2A4ZA5CNFSM4JILJ74KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCK72PLQ#pullrequestreview-314550190>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AASET5OS3DNHKLBV53QNKU3QS2A4ZANCNFSM4JILJ74A>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services