[GitHub] maven issue #127: [MNG-6255] Fix concat_lines in mvn to deal with CRLF

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] maven issue #127: [MNG-6255] Fix concat_lines in mvn to deal with CRLF

agudian
Github user Tunaki commented on the issue:

    https://github.com/apache/maven/pull/127
 
    Looks like we have a similar bug in `mvn.cmd`. The added `testJvmConfigFileCR` test fails on Windows:
   
    ```
    testJvmConfigFileCR(org.apache.maven.it.MavenITmng6255FixConcatLines)  Time elapsed: 1.983 sec  <<< FAILURE!
    junit.framework.ComparisonFailure: null expected:<ok[]> but was:<ok[-Xms256m-Xmx512m]>
      at junit.framework.Assert.assertEquals(Assert.java:81)
      at junit.framework.Assert.assertEquals(Assert.java:87)
      at org.apache.maven.it.MavenITmng6255FixConcatLines.runWithLineEndings(MavenITmng6255FixConcatLines.java:89)
      at org.apache.maven.it.MavenITmng6255FixConcatLines.testJvmConfigFileCR(MavenITmng6255FixConcatLines.java:50)
    ```
   
    Looks like the carriage returns at the end of the line were stripped and everything was put on a single line.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Loading...