[GitHub] maven-integration-testing pull request #21: [MNG-6127] Add plugin execution ...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-integration-testing pull request #21: [MNG-6127] Add plugin execution ...

Tibor17-2
GitHub user mkrizmanic opened a pull request:

    https://github.com/apache/maven-integration-testing/pull/21

    [MNG-6127] Add plugin execution configuration interference test

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mkrizmanic/maven-integration-testing MNG-6127

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven-integration-testing/pull/21.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21
   
----
commit 33b3681c7ed55481cdfd0f7c8ec61781f979babd
Author: Mario Krizmanic <[hidden email]>
Date:   2016-11-23T21:25:34Z

    [MNG-6127] Add plugin execution configuration interference test

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-integration-testing pull request #21: [MNG-6127] Add plugin execution ...

Tibor17-2
Github user michael-o commented on a diff in the pull request:

    https://github.com/apache/maven-integration-testing/pull/21#discussion_r115049986
 
    --- Diff: core-it-suite/src/test/resources/mng-6127/plugin/pom.xml ---
    @@ -0,0 +1,55 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +
    +<!--
    +Licensed to the Apache Software Foundation (ASF) under one
    +or more contributor license agreements.  See the NOTICE file
    +distributed with this work for additional information
    +regarding copyright ownership.  The ASF licenses this file
    +to you under the Apache License, Version 2.0 (the
    +"License"); you may not use this file except in compliance
    +with the License.  You may obtain a copy of the License at
    +
    +  http://www.apache.org/licenses/LICENSE-2.0
    +
    +Unless required by applicable law or agreed to in writing,
    +software distributed under the License is distributed on an
    +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +KIND, either express or implied.  See the License for the
    +specific language governing permissions and limitations
    +under the License.
    +-->
    +
    +<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    +  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    +  <modelVersion>4.0.0</modelVersion>
    +
    +  <groupId>mng-6127</groupId>
    +  <artifactId>mng-6127-plugin</artifactId>
    +  <version>0.1</version>
    +  <packaging>maven-plugin</packaging>
    +
    +  <properties>
    +    <maven-version>3.3.1</maven-version>
    --- End diff --
   
    This should rather be `maven.version` as we always do in POMs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-integration-testing pull request #21: [MNG-6127] Add plugin execution ...

Tibor17-2
In reply to this post by Tibor17-2
Github user mkrizmanic commented on a diff in the pull request:

    https://github.com/apache/maven-integration-testing/pull/21#discussion_r115063523
 
    --- Diff: core-it-suite/src/test/resources/mng-6127/plugin/pom.xml ---
    @@ -0,0 +1,55 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +
    +<!--
    +Licensed to the Apache Software Foundation (ASF) under one
    +or more contributor license agreements.  See the NOTICE file
    +distributed with this work for additional information
    +regarding copyright ownership.  The ASF licenses this file
    +to you under the Apache License, Version 2.0 (the
    +"License"); you may not use this file except in compliance
    +with the License.  You may obtain a copy of the License at
    +
    +  http://www.apache.org/licenses/LICENSE-2.0
    +
    +Unless required by applicable law or agreed to in writing,
    +software distributed under the License is distributed on an
    +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +KIND, either express or implied.  See the License for the
    +specific language governing permissions and limitations
    +under the License.
    +-->
    +
    +<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    +  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    +  <modelVersion>4.0.0</modelVersion>
    +
    +  <groupId>mng-6127</groupId>
    +  <artifactId>mng-6127-plugin</artifactId>
    +  <version>0.1</version>
    +  <packaging>maven-plugin</packaging>
    +
    +  <properties>
    +    <maven-version>3.3.1</maven-version>
    --- End diff --
   
    Hi, it should be defined here because we do not have a parent pom which contains the next artifact versions.
   
    The same pattern is used in other ITs. For instance:
   
    https://github.com/apache/maven-integration-testing/blob/master/core-it-suite/src/test/resources/mng-5578-session-scope/plugin/pom.xml


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-integration-testing pull request #21: [MNG-6127] Add plugin execution ...

Tibor17-2
In reply to this post by Tibor17-2
Github user michael-o commented on a diff in the pull request:

    https://github.com/apache/maven-integration-testing/pull/21#discussion_r115065672
 
    --- Diff: core-it-suite/src/test/resources/mng-6127/plugin/pom.xml ---
    @@ -0,0 +1,55 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +
    +<!--
    +Licensed to the Apache Software Foundation (ASF) under one
    +or more contributor license agreements.  See the NOTICE file
    +distributed with this work for additional information
    +regarding copyright ownership.  The ASF licenses this file
    +to you under the Apache License, Version 2.0 (the
    +"License"); you may not use this file except in compliance
    +with the License.  You may obtain a copy of the License at
    +
    +  http://www.apache.org/licenses/LICENSE-2.0
    +
    +Unless required by applicable law or agreed to in writing,
    +software distributed under the License is distributed on an
    +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +KIND, either express or implied.  See the License for the
    +specific language governing permissions and limitations
    +under the License.
    +-->
    +
    +<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    +  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    +  <modelVersion>4.0.0</modelVersion>
    +
    +  <groupId>mng-6127</groupId>
    +  <artifactId>mng-6127-plugin</artifactId>
    +  <version>0.1</version>
    +  <packaging>maven-plugin</packaging>
    +
    +  <properties>
    +    <maven-version>3.3.1</maven-version>
    --- End diff --
   
    Alright, my bad. Thanks for the clarification.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]