[GitHub] maven-indexer pull request #23: Full codebase reformat, minor cleanup, no co...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-indexer pull request #23: Full codebase reformat, minor cleanup, no co...

Tcharl
GitHub user cstamas opened a pull request:

    https://github.com/apache/maven-indexer/pull/23

    Full codebase reformat, minor cleanup, no code/logic change

    Reformatted full codebase, as there was mixed formatting, and
    checkstyle did report a huge amount of errors. Now, mostly the
    javadoc ones :) remain, and few minor issues. As part of cleanup,
    applied some changes proposed by checkstyle, like removing public
    modifiers from inner enums etc.
   
    No code/logic change happened.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cstamas/maven-indexer reformat

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven-indexer/pull/23.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #23
   
----
commit d01a354aeb53126968e8020ec423b17326f35c14
Author: Tamas Cservenak <[hidden email]>
Date:   2017-11-24T14:42:56Z

    Full codebase reformat, minor cleanup, no code/logic change
   
    Reformatted full codebase, as there was mixed formatting. Also,
    checkstyle did report a huge amount of errors. Now, mostly the
    javadoc ones :) remain, and few minor issues. As part of cleanup,
    applied some changes proposed by checkstyle, like removing public
    modifiers from inner enums etc.
   
    No code/logic change happened.

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-indexer pull request #23: Full codebase reformat, minor cleanup, no co...

Tcharl
Github user cstamas closed the pull request at:

    https://github.com/apache/maven-indexer/pull/23


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

[GitHub] maven-indexer issue #23: Full codebase reformat, minor cleanup, no code/logi...

Tcharl
In reply to this post by Tcharl
Github user cstamas commented on the issue:

    https://github.com/apache/maven-indexer/pull/23
 
    Not merged, gave up.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]